Indent a note to make folding work nicer

[tesuji]

Sublime Text folds code based on indentation. It maybe an unnecessary change, but does it look nicer after that ?

[jyn514]

r=me with nit fixed

[jyn514]

You also need to run x.py test src/test/ui --bless.

[scottmcm]

Nit: this is changing it to visual indent (following the position of the ""), but it should be block-indented instead, per https://github.com/rust-dev-tools/fmt-rfcs/blob/master/guide/principles.md#overarching-guidelines

So something like

    on(
        all(any(T = "str", T = "&str", T = "std::string::String"), _Self = "{integer}"),
        note = "you can use `.chars().nth()` or `.bytes().nth()`\n\
            For more information, see chapter 8 in The Book: \

(Note how the all is indented 4, not 3 as it would be if it were following on()

[tesuji]

That case is more like:

// Block indent
a_function_call(foo,
    bar,
);

[jyn514]

LGTM, r? @scottmcm #76309 (comment)

[scottmcm]

Looks like there are some more test failures in PR here, @lzutao?

[jyn514]

Needs you to run --bless again.

---- [ui] ui/str/str-mut-idx.rs stdout ----
diff of stderr:

39	   |
40	   = help: the trait `SliceIndex<str>` is not implemented for `{integer}`
41	   = note: you can use `.chars().nth()` or `.bytes().nth()`
-	           For more information, see chapter 8 in The Book: <https://doc.rust-lang.org/book/ch08-02-strings.html#indexing-into-strings>
+	           for more information, see chapter 8 in The Book: <https://doc.rust-lang.org/book/ch08-02-strings.html#indexing-into-strings>
43	
44	error[E0277]: the type `str` cannot be indexed by `{integer}`
45	  --> $DIR/str-mut-idx.rs:11:25

49	   |
50	   = help: the trait `SliceIndex<str>` is not implemented for `{integer}`
51	   = note: you can use `.chars().nth()` or `.bytes().nth()`
-	           For more information, see chapter 8 in The Book: <https://doc.rust-lang.org/book/ch08-02-strings.html#indexing-into-strings>
+	           for more information, see chapter 8 in The Book: <https://doc.rust-lang.org/book/ch08-02-strings.html#indexing-into-strings>
53	
54	error[E0277]: the type `str` cannot be indexed by `char`
55	  --> $DIR/str-mut-idx.rs:13:5

[tesuji]

Thanks, blessed the tests.

[jyn514]

@bors r+ rollup

@scottmcm if you want to fix the block indentation feel free to make a follow-up PR ;) but I think this is an improvement over the current code

[bors]

📌 Commit dfd219d has been approved by jyn514

[scottmcm]

@jyn514 All good -- I looked at the other places that attribute is used and there's at least two different indentation styles in use already 🤷‍♀️