Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test #76257

Merged
merged 1 commit into from
Oct 31, 2020
Merged

Add regression test #76257

merged 1 commit into from
Oct 31, 2020

Conversation

JulianKnodt
Copy link
Contributor

@JulianKnodt JulianKnodt commented Sep 2, 2020 •
edited by JohnTitor
Loading

This adds a regression test for #75777, effectively closing it since it is solved on nightly and beta.

Closes #75777

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 2, 2020
@JulianKnodt
Copy link
Contributor Author

cc: @Dylan-DPC
Probs can just roll up, but I need to actually run the test on my machine.

@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

@jyn514 jyn514 added the A-testsuite Area: The testsuite used to check the correctness of rustc label Sep 3, 2020
@Dylan-DPC-zz
Copy link

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Sep 4, 2020

📌 Commit acac5c6 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2020
@Dylan-DPC-zz
Copy link

@bors rollup=always :D

matklad added a commit to matklad/rust that referenced this pull request Sep 4, 2020
@matklad
Rollup merge of rust-lang#76257 - JulianKnodt:i75777, r=Dylan-DPC
0f9bbea 
Add regression test

This adds a regression test for rust-lang#75777, effectively closing it since it is solved on nightly and beta.
@matklad matklad mentioned this pull request Sep 4, 2020
Closed
matklad added a commit to matklad/rust that referenced this pull request Sep 4, 2020
@matklad
Rollup merge of rust-lang#76257 - JulianKnodt:i75777, r=Dylan-DPC
64e87ec 
Add regression test

This adds a regression test for rust-lang#75777, effectively closing it since it is solved on nightly and beta.
@matklad matklad mentioned this pull request Sep 4, 2020
Closed
@matklad
Copy link
Member

matklad commented Sep 4, 2020

Failed in rollup:

#76317

https://github.com/rust-lang/rust/pull/76317/checks?check_run_id=1070864339#step:23:1526

probably needs a rebase

@JulianKnodt JulianKnodt force-pushed the i75777 branch 2 times, most recently from 7da258c to 4bfdcea Compare September 4, 2020 19:07
@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 25, 2020
@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 25, 2020

📌 Commit 4bfdcea has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2020
@jonas-schievink jonas-schievink mentioned this pull request Sep 25, 2020
Closed
@jonas-schievink
Copy link
Contributor

@bors r- failed in #77191 (comment)

@JulianKnodt
Copy link
Contributor Author

ah ok I updated that test, so maybe now... it should be fine? Just curious, is there documentation for the nll mode? I should probably read up on it

@camelid camelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 30, 2020

@bors r=@Dylan-DPC rollup=iffy

@bors
Copy link
Contributor

bors commented Oct 30, 2020

📌 Commit 41b40279e7178f19ce6c8c66e75e32d731fa24ed has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2020
@bors
Copy link
Contributor

bors commented Oct 30, 2020

⌛ Testing commit 41b40279e7178f19ce6c8c66e75e32d731fa24ed with merge 9f569d1f93bee4040b86204ee082d4e991022525...

@bors
Copy link
Contributor

bors commented Oct 30, 2020

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 30, 2020
@jyn514
Copy link
Member

jyn514 commented Oct 30, 2020 

 ---- [ui] ui/issues/issue-75777.rs stdout ----
diff of stderr:

14	   |
15	LL |     Box::new(move |_| fut)
16	   |              ^^^^^^^^^^^^
-	   = note: expected `Pin<Box<dyn Future<Output = A> + Send>>`
-	              found `Pin<Box<(dyn Future<Output = A> + Send + 'a)>>`
+	   = note: expected `(Pin<Box<dyn Future<Output = A> + Send>>,)`
+	              found `(Pin<Box<(dyn Future<Output = A> + Send + 'a)>>,)`

@jyn514 jyn514 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2020
@JulianKnodt
Copy link
Contributor Author

It should be all good hopefully since I blessed the output and it fixed the error

@jyn514
Copy link
Member

jyn514 commented Oct 30, 2020

@bors r=Dylan-DPC rollup=iffy

@bors
Copy link
Contributor

bors commented Oct 30, 2020

📌 Commit a7e8208 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 30, 2020
@jonas-schievink jonas-schievink mentioned this pull request Oct 30, 2020
Closed
@bors
Copy link
Contributor

bors commented Oct 31, 2020

⌛ Testing commit a7e8208 with merge 3478d7c...

@bors
Copy link
Contributor

bors commented Oct 31, 2020

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing 3478d7c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 31, 2020
@bors bors merged commit 3478d7c into rust-lang:master Oct 31, 2020
@rustbot rustbot added this to the 1.49.0 milestone Oct 31, 2020
@JulianKnodt JulianKnodt deleted the i75777 branch November 1, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.49.0
Development

Successfully merging this pull request may close these issues.

The following error was constructed but not emitted: cannot infer an appropriate lifetime