Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Backport fix for swapped stability attributes #76032

Merged
merged 1 commit into from
Aug 28, 2020
Merged

[beta] Backport fix for swapped stability attributes #76032

merged 1 commit into from
Aug 28, 2020

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Aug 28, 2020

This backports the only commit in #75953, fixing one unstable lint which ran on stable and one stable lint which only ran on nightly. This change can be replicated with

git fetch origin
git checkout origin/beta
git cherry-pick 29399fad5f961f0e235d28ed2f4c68e7a1ae5062

@jyn514
Fix swapped stability attributes
adc747e 
This fixes a regression introduced in
rust-lang#74855.
@rust-highfive
Copy link
Collaborator

r? @ollie27

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 28, 2020
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Aug 28, 2020

📌 Commit adc747e has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2020
@jyn514 jyn514 added A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 28, 2020
@jyn514 jyn514 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2020
@bors
Copy link
Contributor

bors commented Aug 28, 2020

⌛ Testing commit adc747e with merge 84b047b...

@bors
Copy link
Contributor

bors commented Aug 28, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: Mark-Simulacrum
Pushing 84b047b to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 28, 2020
@bors bors merged commit 84b047b into rust-lang:beta Aug 28, 2020
@jyn514 jyn514 deleted the lint-backport branch August 28, 2020 21:53
@jyn514 jyn514 mentioned this pull request Sep 17, 2020
Merged
@cuviper cuviper added this to the 1.47.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-lints Area: Lints (warnings about flaws in source code) such as unused_mut. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
6 participants
@jyn514 @rust-highfive @Mark-Simulacrum @bors @cuviper @ollie27