Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve E0118 #76028

Merged
merged 2 commits into from
Sep 17, 2020
Merged

Improve E0118 #76028

merged 2 commits into from
Sep 17, 2020

Conversation

aticu
Copy link
Contributor

@aticu aticu commented Aug 28, 2020 •
edited
Loading

  • Changes the "base type" terminology to "nominal type" (according to the reference).
  • Suggests removing a reference, if one is present on the type.
  • Clarify what is meant by a "nominal type".

closes #69392

This is my first not-entirely-trivial PR, so please let me know if I missed anything or if something could be improved. Though I probably won't be able to fix anything in the upcoming week.

@rust-highfive
Copy link
Collaborator

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 28, 2020
@bors

This comment has been minimized.

Sign in to view
@jyn514 jyn514 added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 3, 2020
@jyn514
Copy link
Member

jyn514 commented Sep 15, 2020

r? @GuillaumeGomez

@aticu
Adjust spelling
81161be 
Co-authored-by: Joshua Nelson <[email protected]>
@estebank
Copy link
Contributor

Sorry for the delay in reviewing. I'll defer to @GuillaumeGomez on the wording, but otherwise r=me.

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented Sep 16, 2020 •
edited
Loading

Thanks!

@bors: r=estebank,jyn514,GuillaumeGomez

@bors
Copy link
Contributor

bors commented Sep 16, 2020

📌 Commit 81161be has been approved by estebank,jyn514,GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 16, 2020
@bors
Copy link
Contributor

bors commented Sep 17, 2020

⌛ Testing commit 81161be with merge 95386b6...

@bors
Copy link
Contributor

bors commented Sep 17, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: estebank,jyn514,GuillaumeGomez
Pushing 95386b6 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 17, 2020
@bors bors merged commit 95386b6 into rust-lang:master Sep 17, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 17, 2020
@aticu aticu deleted the improve_e0118 branch September 18, 2020 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-diagnostics Area: Messages for errors, warnings, and lints merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.

E0118 probably shouldn't use the terminology of "base type"
7 participants
@aticu @rust-highfive @bors @jyn514 @estebank @GuillaumeGomez @rustbot