Rollup of 12 pull requests #75797
Merged
Rollup of 12 pull requests #75797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: lzutao <[email protected]>
Builds with debuginfo have additional information in backtrace.
To separate the astconv.rs file, I split it into its own module with a subtrait called GenericAstConv. This subtrait handles methods related to generics, be it types or lifetimes. typeck: Add bounds module and Bounds struct bounds: Run fmt, add documentation generic_astconv: Add subtrait GenericAstConv Some methods of AstConv deal exclusively with Generics. Therefore, it makes sense to have them in their own trait. Some other methods from AstConv might be added to it later generic_astconv: Add more methods from AstConv Add check_generic_arg_count_for_call() and check_generic_arg_count() astconv: Add module for clarity generic: Rename GenericAstConv -> AstConvGeneric generic: add more methods to AstConvGeneric astconv: Remove AstConvGeneric trait, add impl dyn AstConv in other module astconv: Add errors module to handle AstConv complaints fmt: format code in astconv/ astconv: Remove old file astconv: Fix visibility on GenericArgPosition astconv: Fix visibility on GenericArgPosition astconv: Fix function visibility on other originally private functions
…jyn514 Use intra-doc-links in `alloc` I didn't have time to test this, so I will let the CI do it for me. r? @jyn514 cc rust-lang#75080
Remove duplication in `fold_item` r? @Manishearth
Another motivation for CFG: return-oriented programming
Minor, remove double nesting of a test module
…alize, r=jonas-schievink Extend normalization in const-eval-query-stack test Builds with debuginfo have additional information in backtrace.
More inline asm register name fixups for LLVM Fixes rust-lang#75761 r? @nagisa
Convert core/src/str/pattern.rs to Intra-doc links Part of rust-lang#75080.
…yn514 Use intra-doc-links in `core::ops::*` Helps with rust-lang#75080. r? @jyn514
…ywiser MIR call terminator represents diverging calls too @bors rollup=always
|
@bors r+ rollup=never p=5 |
|
📌 Commit 2ab6fef has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
This was referenced Aug 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
astconv.rsinto its own submodule #75711 (Splitastconv.rsinto its own submodule)alloc#75725 (Use intra-doc-links inalloc)fold_item#75745 (Remove duplication infold_item)core::ops::*#75787 (Use intra-doc-links incore::ops::*)Failed merges:
r? @ghost