Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up E0730 explanation #74751

Merged
merged 2 commits into from
Jul 30, 2020
Merged

Clean up E0730 explanation #74751

merged 2 commits into from
Jul 30, 2020

Conversation

GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 25, 2020
jyn514
jyn514 reviewed Jul 30, 2020
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but the existing suggestion looks odd. The erroneous code already has .. - the fix is to use slices, not arrays, which isn't mentioned.

@GuillaumeGomez
Copy link
Member Author

This is a good point, I'll add it this.

@GuillaumeGomez
Copy link
Member Author

Updated!

@jyn514
Copy link
Member

jyn514 commented Jul 30, 2020

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Jul 30, 2020

📌 Commit 89e4fe3 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2020
@Manishearth Manishearth mentioned this pull request Jul 30, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2020
@bors
Auto merge of rust-lang#74957 - Manishearth:rollup-3wudwlg, r=Manishe…
cfc572c 
…arth

Rollup of 9 pull requests

Successful merges:

 - rust-lang#74751 (Clean up E0730 explanation)
 - rust-lang#74782 (Don't use "weak count" around Weak::from_raw_ptr)
 - rust-lang#74835 (Clean up E0734 explanation)
 - rust-lang#74871 (Enable docs on dist-x86_64-musl)
 - rust-lang#74905 (Avoid bool-like naming)
 - rust-lang#74907 (Clean up E0740 explanation)
 - rust-lang#74915 (rustc: Ignore fs::canonicalize errors in metadata)
 - rust-lang#74934 (Improve diagnostics when constant pattern is too generic)
 - rust-lang#74951 (Cherry-pick the release notes for 1.45.1)

Failed merges:

r? @ghost
@bors bors merged commit 7e86c8e into rust-lang:master Jul 30, 2020
@GuillaumeGomez GuillaumeGomez deleted the cleanup-e0730 branch July 31, 2020 08:00
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@Dylan-DPC-zz Dylan-DPC-zz

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @jyn514 @bors @cuviper @rust-highfive @Dylan-DPC-zz