-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly mark the ending span of a match arm #74125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jul 7, 2020
ayazhafiz
force-pushed
the
i/74050
branch
2 times, most recently
from
July 8, 2020 00:45
906e5ff
to
55e6af0
Compare
matthewjasper
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good, r=me with commits squashed
@bors r=matthewjasper |
@ayazhafiz: 🔑 Insufficient privileges: Not in reviewers |
@matthewjasper can you r+ for bors |
@bors r+ |
📌 Commit 3c63fba has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jul 8, 2020
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 8, 2020
Correctly mark the ending span of a match arm Closes rust-lang#74050 r? @matthewjasper
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 8, 2020
Correctly mark the ending span of a match arm Closes rust-lang#74050 r? @matthewjasper
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 9, 2020
Correctly mark the ending span of a match arm Closes rust-lang#74050 r? @matthewjasper
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 9, 2020
Correctly mark the ending span of a match arm Closes rust-lang#74050 r? @matthewjasper
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 10, 2020
Correctly mark the ending span of a match arm Closes rust-lang#74050 r? @matthewjasper
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 10, 2020
Correctly mark the ending span of a match arm Closes rust-lang#74050 r? @matthewjasper
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 10, 2020
Correctly mark the ending span of a match arm Closes rust-lang#74050 r? @matthewjasper
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 10, 2020
Correctly mark the ending span of a match arm Closes rust-lang#74050 r? @matthewjasper
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Jul 11, 2020
Correctly mark the ending span of a match arm Closes rust-lang#74050 r? @matthewjasper
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 11, 2020
…arth Rollup of 19 pull requests Successful merges: - rust-lang#71322 (Accept tuple.0.0 as tuple indexing (take 2)) - rust-lang#72303 (Add core::future::{poll_fn, PollFn}) - rust-lang#73862 (Stabilize casts and coercions to `&[T]` in const fn) - rust-lang#73887 (stabilize const mem::forget) - rust-lang#73989 (adjust ub-enum test to be endianess-independent) - rust-lang#74045 (Explain effects of debugging options from config.toml) - rust-lang#74076 (Add `read_exact_at` and `write_all_at` to WASI's `FileExt`) - rust-lang#74099 (Add VecDeque::range* methods) - rust-lang#74100 (Use str::strip* in bootstrap) - rust-lang#74103 (Only add CFGuard on `windows-msvc` targets) - rust-lang#74109 (Only allow `repr(i128/u128)` on enum) - rust-lang#74122 (Start-up clean-up) - rust-lang#74125 (Correctly mark the ending span of a match arm) - rust-lang#74127 (Avoid "whitelist") - rust-lang#74129 (:arrow_up: rust-analyzer) - rust-lang#74135 (Update books) - rust-lang#74145 (Update rust-installer to latest version) - rust-lang#74161 (Fix disabled dockerfiles) - rust-lang#74162 (take self by value in ToPredicate) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #74050
r? @matthewjasper