Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RawFd to WASI's std::os::wasi::prelude. #74075

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

sunfishcode
Copy link
Member

Add RawFd to WASI's std::os::wasi::prelude, making it consistent
with all other platforms which also have AsRawFd, FromRawFd, and
IntoRawFd in their respective preludes.

Add `RawFd` to WASI's `std::os::wasi::prelude`, making it consistent
with all other platforms which also have `AsRawFd`, `FromRawFd`, and
`IntoRawFd` in their respective preludes.
@rust-highfive
Copy link
Collaborator

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 5, 2020
@sunfishcode
Copy link
Member Author

r? @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Jul 20, 2020

📌 Commit 83bd3d3 has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 20, 2020
@bors
Copy link
Contributor

bors commented Jul 21, 2020

⌛ Testing commit 83bd3d3 with merge 8ad7bc3...

@bors
Copy link
Contributor

bors commented Jul 21, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: alexcrichton
Pushing 8ad7bc3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 21, 2020
@bors bors merged commit 8ad7bc3 into rust-lang:master Jul 21, 2020
@bors bors mentioned this pull request Jul 21, 2020
@sunfishcode sunfishcode deleted the wasi-prelude-rawfd branch July 24, 2020 20:53
sunfishcode added a commit to sunfishcode/wasmtime that referenced this pull request Jul 24, 2020
Remove the workarounds for rust-lang/rust#74075
now that it's landed on nightly Rust.
sunfishcode added a commit to sunfishcode/wasmtime that referenced this pull request Jul 28, 2020
Remove the workarounds for rust-lang/rust#74075
now that it's landed on nightly Rust.
sunfishcode added a commit to sunfishcode/wasmtime that referenced this pull request Aug 4, 2020
Remove the workarounds for rust-lang/rust#74075
now that it's landed on nightly Rust.
sunfishcode added a commit to sunfishcode/wasmtime that referenced this pull request Aug 10, 2020
Remove the workarounds for rust-lang/rust#74075
now that it's landed on nightly Rust.
sunfishcode added a commit to sunfishcode/wasmtime that referenced this pull request Aug 17, 2020
Remove the workarounds for rust-lang/rust#74075
now that it's landed on nightly Rust.
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants