Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #72898

Closed
wants to merge 15 commits into from

Commits on May 31, 2020

  1. remove trivial calls to mk_const

    lcnr committed May 31, 2020
    Configuration menu
    Copy the full SHA
    9f83d36 View commit details
    Browse the repository at this point in the history
  2. changed *nix to Unix-like

    Miller authored May 31, 2020
    Configuration menu
    Copy the full SHA
    186b274 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2020

  1. Fix off-by-one error in DroplessArena::alloc_raw.

    This causes unnecessary calls to `grow` when the allocation would fit
    exactly in the remaining space.
    nnethercote committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    a80dc28 View commit details
    Browse the repository at this point in the history
  2. Remove the reserve_in_place calls in {Typed,Dropless}Arena::grow.

    They are pointless. No reasonable allocator will be able to satisfy a
    `reserve_in_place` request that *doubles* the size of an allocation when
    dealing with allocations that are 4 KiB and larger.
    
    Just to be sure, I confirmed on Linux that the `reserve_in_place` calls
    never succeed.
    
    (Note however that the `reserve_in_place` call for `DroplessArena::grow`
    did occasionally succeed prior to the off-by-one fix in the previous
    commit, because we would sometimes do a `reserve_in_place` request for
    the chunk's current size, which would trivially succeed!)
    nnethercote committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    b789617 View commit details
    Browse the repository at this point in the history
  3. Remove RawVec::reserve_in_place.

    Also remove a now-unnecessary `placement` argument.
    nnethercote committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    301d0af View commit details
    Browse the repository at this point in the history
  4. Rename some identifiers in RawVec and libarena.

    - Use `len` more consistently for the number of elements in a vector,
      because that's the usual name.
    - Use `additional` more consistently for the number of elements we want
      to add, because that's what `Vec::reserve()` uses.
    - Use `cap` consistently rather than `capacity`.
    - Plus a few other tweaks.
    
    This increases consistency and conciseness.
    nnethercote committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    2391497 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    576a97b View commit details
    Browse the repository at this point in the history
  6. Remove allow missing_debug_implementations for MaybeUninit

    It already has a Debug implementation.
    KamilaBorowska authored Jun 1, 2020
    Configuration menu
    Copy the full SHA
    664222a View commit details
    Browse the repository at this point in the history
  7. rustc: Remove the --passive-segments LLD flag on wasm

    This flag looks like it's been removed in LLVM 10, so this removes rustc
    unconditionally passing the flag.
    alexcrichton committed Jun 1, 2020
    Configuration menu
    Copy the full SHA
    0fd9a37 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#72417 - nnethercote:rm-RawVec-reserve_in_pl…

    …ace, r=Amanieu
    
    Remove `RawVec::reserve_in_place`.
    
    And some related clean-ups.
    
    r? @oli-obk
    Dylan-DPC authored Jun 1, 2020
    Configuration menu
    Copy the full SHA
    c799c48 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#72822 - lcnr:intern-me, r=estebank

    remove trivial calls to mk_const
    
    similar to rust-lang#72754
    Dylan-DPC authored Jun 1, 2020
    Configuration menu
    Copy the full SHA
    79e0055 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#72827 - milrope:patch-1, r=nikomatsakis

    changed *nix to Unix-like
    Dylan-DPC authored Jun 1, 2020
    Configuration menu
    Copy the full SHA
    ea44f39 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#72880 - GuillaumeGomez:cleanup-e0637, r=Dyl…

    …an-DPC
    
    Clean up E0637 explanation
    
    r? @Dylan-DPC
    Dylan-DPC authored Jun 1, 2020
    Configuration menu
    Copy the full SHA
    85c4073 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#72886 - xfix:patch-21, r=jonas-schievink

    Remove allow missing_debug_implementations for MaybeUninit
    
    It already has a Debug implementation.
    Dylan-DPC authored Jun 1, 2020
    Configuration menu
    Copy the full SHA
    32f36bd View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#72889 - alexcrichton:update-wasm-threads, r…

    …=nikomatsakis
    
    rustc: Remove the `--passive-segments` LLD flag on wasm
    
    This flag looks like it's been removed in LLVM 10, so this removes rustc
    unconditionally passing the flag.
    Dylan-DPC authored Jun 1, 2020
    Configuration menu
    Copy the full SHA
    67dab8c View commit details
    Browse the repository at this point in the history