Add preloading hints for default fonts #72843
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds preloading hints to rustdoc's HTML for certain fonts
that are always loaded from the server. This enables browsers
to improve loading performance of the page.
This is an attempt to improve on the situation discussed in #20962 and also for historical interest it is following up on lessons learned in #72557 (comment)
Browsers lazy-load fonts in
@font-face
rules. The generation, calculation, and styling of astd
doc page takes entire seconds, whereas loading a font takes milliseconds. It's hard to know when exactly the fonts are requested, but examining results from webpagetest.org suggests it could take entire seconds into the page load. Using<link>
for all of rustdoc's webfonts might be unwise (it would be wasted loads if the fonts are local), and CSS extensions can override these, but as long as the CSS is unaltered we can be confident a visitor to a rustdoc page will want these fonts.