compare consts using ptr equality #72675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit ef5aa6a with merge 7c7aeef41db36aadc9d940c74e5f21cdb9905c34... |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-author
bjorn3
reviewed
May 28, 2020
src/librustc_middle/ty/sty.rs
Outdated
| @@ -2178,21 +2180,38 @@ impl<'tcx> TyS<'tcx> { | |||
| } | |||
|
|
|||
| /// Typed constant value. | |||
| #[derive(Copy, Clone, Debug, Hash, RustcEncodable, RustcDecodable, Eq, PartialEq, Ord, PartialOrd)] | |||
| #[derive(Debug, Hash, RustcEncodable, RustcDecodable, Eq, Ord, PartialOrd)] | |||
There was a problem hiding this comment.
Hash can hash the address now.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
May 29, 2020
remove redundant `mk_const` Taken from rust-lang#72675 as this is fairly unrelated and that PR is more difficult than I imagined, so it may take some time until it lands.
|
I am currently getting the following errors: Even after looking at #48923 I am still kind of stuck with what to do here. |
bjorn3
reviewed
May 29, 2020
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
Will close this PR for now as I don't know how to fix the current issues and we do not often compare |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
Ty<'tcx>this PR now comparesConsts using pointer equality.To prevent ourselves from accidentally creating a const on the stack I added a new
zero sized field to
Const. This field has to bepublic, to allow pattern matching on constsand has a private field, to prevent construction outside of
rustc_middle::ty.Let's see if this actually changes perf in any meaningful way 🤷
I did not yet update the test output.