Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #71985

Merged
merged 22 commits into from
May 7, 2020
Merged

Rollup of 6 pull requests #71985

merged 22 commits into from
May 7, 2020

Commits on May 6, 2020

  1. Configuration menu
    Copy the full SHA
    9ed9200 View commit details
    Browse the repository at this point in the history
  2. Add test for rust-lang#29988

    JohnTitor committed May 6, 2020
    Configuration menu
    Copy the full SHA
    96d4e0b View commit details
    Browse the repository at this point in the history
  3. Add test for rust-lang#34979

    JohnTitor committed May 6, 2020
    Configuration menu
    Copy the full SHA
    be2d553 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f22bc7b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    8e76663 View commit details
    Browse the repository at this point in the history
  6. grammar: which vs that

    jsoref authored May 6, 2020
    Configuration menu
    Copy the full SHA
    6425413 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    39b5b70 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5f54ce7 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    c8aba78 View commit details
    Browse the repository at this point in the history
  10. grammar: noun not verb

    jsoref authored May 6, 2020
    Configuration menu
    Copy the full SHA
    488e660 View commit details
    Browse the repository at this point in the history
  11. grammar: stray comma

    jsoref authored May 6, 2020
    Configuration menu
    Copy the full SHA
    5d2d7e7 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    eb12784 View commit details
    Browse the repository at this point in the history
  13. grammar: dealing-with

    jsoref authored May 6, 2020
    Configuration menu
    Copy the full SHA
    6c8c3f8 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2020

  1. Configuration menu
    Copy the full SHA
    d1ea287 View commit details
    Browse the repository at this point in the history
  2. Allow a few warnings.

    On Windows, these types were causing warnings to be emitted during the
    build. These types are allowed to not have idiomatic names, so the
    warning should be supressed.
    steveklabnik committed May 7, 2020
    Configuration menu
    Copy the full SHA
    d14f000 View commit details
    Browse the repository at this point in the history
  3. Add some skip flags

    JohnTitor committed May 7, 2020
    Configuration menu
    Copy the full SHA
    d717e55 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#71938 - mark-i-m:de-abuse-err-4, r=eddyb

    Use trait_object_dummy_self instead of err
    
    r? @eddyb
    
    cc rust-lang#70866.
    Dylan-DPC authored May 7, 2020
    Configuration menu
    Copy the full SHA
    037ae40 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#71952 - JohnTitor:add-tests, r=Dylan-DPC

    Add some regression tests
    
    Closes rust-lang#29988
    Closes rust-lang#34979
    Pick up two snippets that have been fixed from rust-lang#67945 (shouldn't be closed yet!)
    Dylan-DPC authored May 7, 2020
    Configuration menu
    Copy the full SHA
    480f718 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#71959 - petrochenkov:chelpers, r=Mark-Simul…

    …acrum
    
    tests: Fix warnings in `rust_test_helpers.c`
    
    MSVC is silly and doesn't recognize `assert` as diverging.
    Dylan-DPC authored May 7, 2020
    Configuration menu
    Copy the full SHA
    9e4a745 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#71962 - jsoref:grammar, r=Dylan-DPC

    Grammar
    
    I've split this into individual changes so that people can veto individually. I'm not attached to most of them.
    
    `zeroes` vs. `zeros` is why I took the effort to run this through app.grammarly (which disappointingly didn't even notice).
    Dylan-DPC authored May 7, 2020
    Configuration menu
    Copy the full SHA
    2e9db8d View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#71972 - RalfJung:miri-validity-error-refine…

    …, r=oli-obk
    
    use hex for pointers in Miri error messages
    
    Also refine vtable error message: distinguish between "drop fn does not point to a function" and "drop fn points to a function with the wrong signature".
    Dylan-DPC authored May 7, 2020
    Configuration menu
    Copy the full SHA
    806089a View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#71980 - steveklabnik:warnings-fixes, r=Mark…

    …-Simulacrum
    
    Allow a few warnings.
    
    On Windows, these types were causing warnings to be emitted during the
    build. These types are allowed to not have idiomatic names, so the
    warning should be supressed.
    Dylan-DPC authored May 7, 2020
    Configuration menu
    Copy the full SHA
    c818e84 View commit details
    Browse the repository at this point in the history