Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miri: tweak error print #71704

Merged
merged 5 commits into from
May 1, 2020
Merged

Miri: tweak error print #71704

merged 5 commits into from
May 1, 2020

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Apr 30, 2020 •
edited
Loading

I started by adjusting the "invalid use of int as pointer" message (it wasn't really clear what is invalid about the use). But then I realized that these are all Debug impls we use for these errors, for some reason, so I fixed that to use Display instead.

This includes #71590 (to get the Display impl for Pointer), so the diff will look better once that finally lands. Here's the relative diff.

r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 30, 2020
@RalfJung RalfJung force-pushed the miri-error-print branch from c5b4332 to cce0cb3 Compare May 1, 2020 08:56
@RalfJung
Copy link
Member Author

RalfJung commented May 1, 2020

#71590 landed, so I rebased.

@oli-obk
Copy link
Contributor

oli-obk commented May 1, 2020

@bors r+

@bors
Copy link
Contributor

bors commented May 1, 2020

📌 Commit cce0cb3 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2020
@bors
Copy link
Contributor

bors commented May 1, 2020

⌛ Testing commit cce0cb3 with merge fd61d06...

@bors
Copy link
Contributor

bors commented May 1, 2020

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing fd61d06 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 1, 2020
@bors bors merged commit fd61d06 into rust-lang:master May 1, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #71704!

Tested on commit fd61d06.
Direct link to PR: #71704

💔 miri on windows: test-fail → build-fail (cc @oli-obk @eddyb @RalfJung).
💔 miri on linux: test-fail → build-fail (cc @oli-obk @eddyb @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 1, 2020
@rust-highfive
📣 Toolstate changed by rust-lang/rust#71704!
e3bbaa6 
Tested on commit rust-lang/rust@fd61d06.
Direct link to PR: <rust-lang/rust#71704>

💔 miri on windows: test-fail → build-fail (cc @oli-obk @eddyb @RalfJung).
💔 miri on linux: test-fail → build-fail (cc @oli-obk @eddyb @RalfJung).
@bors bors mentioned this pull request May 1, 2020
Merged
@RalfJung RalfJung deleted the miri-error-print branch May 1, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RalfJung @oli-obk @bors @rust-highfive