Miri terminator handling: only do progress sanity check for 'Call' terminator #70771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
RalfJung
force-pushed
the
ctfe-loop
branch
2 times, most recently
from
8e736f2 to
f8b6e83
Compare
This comment has been minimized.
This comment has been minimized.
oli-obk
reviewed
Apr 6, 2020
| @@ -0,0 +1,5 @@ | |||
| #![feature(const_loop)] | |||
|
|
|||
| static _X: () = loop {}; //~ ERROR could not evaluate static initializer | |||
There was a problem hiding this comment.
how long does this test take? If more than a second, please lower the step limit
There was a problem hiding this comment.
It takes not even 200ms here:
$ time rustc +rustc.2-s1 src/test/ui/consts/const-eval/issue-70723.rs
error[E0080]: could not evaluate static initializer
--> src/test/ui/consts/const-eval/issue-70723.rs:3:17
|
3 | static _X: () = loop {}; //~ ERROR could not evaluate static initializer
| ^^^^^^^ exceeded interpreter step limit (see `#[const_eval_limit]`)
error: aborting due to previous error
For more information about this error, try `rustc --explain E0080`.
real 0m0,125s
user 0m0,064s
sys 0m0,029s
|
r=me after ensuring that the new test doesn't consume too much time |
|
@bors r=oli-obk |
|
📌 Commit e92bde3 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will still catch mistakes in bad intrinsic/foreign-item shims, which is the main source of errors here.
Fixes #70723
r? @oli-obk