Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't bail out before linting in generic contexts. #70566

Merged
merged 3 commits into from
Apr 16, 2020
Merged

Don't bail out before linting in generic contexts. #70566

merged 3 commits into from
Apr 16, 2020

Conversation

jumbatm
Copy link
Contributor

@jumbatm jumbatm commented Mar 30, 2020 •
edited
Loading

Fixes #69021.

cc #70017

r? @RalfJung

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2020
@jumbatm jumbatm changed the title Ensure const prop lints run on used associated consts. Run the optimized_mir query on all associated consts. Mar 30, 2020
@jumbatm jumbatm force-pushed the exceeding-bitshifts-constprop branch from d355157 to 40eae5b Compare March 30, 2020 12:49
@Centril
Copy link
Contributor

Centril commented Mar 30, 2020

(Let's make sure we perf test this before landing.)

@RalfJung RalfJung mentioned this pull request Mar 30, 2020
Closed
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-03-30T13:44:14.1358276Z ========================== Starting Command Output ===========================
2020-03-30T13:44:14.1362703Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/b1876859-32d6-4d39-a3a1-f838992a2334.sh
2020-03-30T13:44:14.1363213Z 
2020-03-30T13:44:14.1367097Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-30T13:44:14.1387638Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70566/merge to s
2020-03-30T13:44:14.1390904Z Task         : Get sources
2020-03-30T13:44:14.1391184Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-30T13:44:14.1391456Z Version      : 1.0.0
2020-03-30T13:44:14.1392057Z Author       : Microsoft
---
2020-03-30T13:44:15.3371757Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-30T13:44:15.3379317Z ##[command]git config gc.auto 0
2020-03-30T13:44:15.3386046Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-30T13:44:15.3391732Z ##[command]git config --get-all http.proxy
2020-03-30T13:44:15.3402944Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70566/merge:refs/remotes/pull/70566/merge
---
2020-03-30T13:53:23.0604297Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-03-30T13:53:24.6731045Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-03-30T13:53:26.4012785Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-03-30T13:53:26.8626229Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-03-30T13:53:37.0076185Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-03-30T13:53:39.0316196Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-03-30T13:53:43.8751374Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-03-30T13:53:48.3302351Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-03-30T13:53:59.2679844Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-03-30T14:18:08.2884721Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-03-30T14:18:10.2636502Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-03-30T14:18:12.5206758Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-03-30T14:18:14.5001626Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-03-30T14:18:25.8755434Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-03-30T14:18:29.7285844Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-03-30T14:18:35.5661924Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-03-30T14:18:41.7728583Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-03-30T14:18:52.7390027Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-03-30T14:46:04.6807849Z .................................................................................................... 1700/9858
2020-03-30T14:46:08.7894571Z .................................................................................................... 1800/9858
2020-03-30T14:46:17.9762918Z ............................................................................................i....... 1900/9858
2020-03-30T14:46:26.0342328Z .................................................................................................... 2000/9858
2020-03-30T14:46:32.6591596Z ..................................................................................iiiii............. 2100/9858
2020-03-30T14:46:54.7762808Z .................................................................................................... 2300/9858
2020-03-30T14:46:57.0261632Z .................................................................................................... 2400/9858
2020-03-30T14:46:59.4130291Z .................................................................................................... 2500/9858
2020-03-30T14:47:05.4882600Z .................................................................................................... 2600/9858
---
2020-03-30T14:49:59.6033418Z .................................................................................................... 4900/9858
2020-03-30T14:50:04.5890124Z ........................................................i...............i........................... 5000/9858
2020-03-30T14:50:12.6012479Z .................................................................................................... 5100/9858
2020-03-30T14:50:20.2840615Z .................................................................................................... 5200/9858
2020-03-30T14:50:25.5352749Z .i.................................................................................................. 5300/9858
2020-03-30T14:50:36.5258533Z .......................................................................................ii.ii........ 5400/9858
2020-03-30T14:50:40.3473919Z i...i............................................................................................... 5500/9858
2020-03-30T14:50:49.4976737Z ................................i................................................................... 5700/9858
2020-03-30T14:51:00.0028338Z ..................................................ii....................................i........... 5800/9858
2020-03-30T14:51:07.9951007Z .................................................................................................... 5900/9858
2020-03-30T14:51:13.2505902Z .................................................................................................... 6000/9858
2020-03-30T14:51:13.2505902Z .................................................................................................... 6000/9858
2020-03-30T14:51:22.8609173Z ..................................................................................ii...i..ii........ 6100/9858
2020-03-30T14:51:44.4564638Z .................................................................................................... 6300/9858
2020-03-30T14:51:51.6488368Z .................................................................................................... 6400/9858
2020-03-30T14:51:58.8759211Z .................................................................................................... 6500/9858
2020-03-30T14:51:58.8759211Z .................................................................................................... 6500/9858
2020-03-30T14:52:16.4229343Z ............i..ii................................................................................... 6600/9858
2020-03-30T14:52:38.0398998Z .................................................................................................... 6800/9858
2020-03-30T14:52:40.2965791Z ............i....................................................................................... 6900/9858
2020-03-30T14:52:42.5150112Z .................................................................................................... 7000/9858
2020-03-30T14:52:44.7623334Z .................................................i.................................................. 7100/9858
---
2020-03-30T14:54:31.7629326Z .................................................................................................... 7800/9858
2020-03-30T14:54:37.2251681Z .................................................................................................... 7900/9858
2020-03-30T14:54:43.2838399Z .................................................................................................... 8000/9858
2020-03-30T14:54:52.3998010Z .........i.......................................................................................... 8100/9858
2020-03-30T14:55:00.5650702Z ..........................................................iiiiiiiiii.i.............................. 8200/9858
2020-03-30T14:55:15.6542901Z ..i......i.......................................................................................... 8400/9858
2020-03-30T14:55:20.9056922Z .................................................................................................... 8500/9858
2020-03-30T14:55:33.6337130Z .................................................................................................... 8600/9858
2020-03-30T14:55:43.9263801Z .................................................................................................... 8700/9858
---
2020-03-30T14:57:30.8713732Z ..............................................................i..................................... 9800/9858
2020-03-30T14:57:43.7481516Z ..........................................................
2020-03-30T14:57:43.7484287Z failures:
2020-03-30T14:57:43.7526338Z 
2020-03-30T14:57:43.7527605Z ---- [ui] ui/associated-const/lints-used-unused.rs#unused stdout ----
2020-03-30T14:57:43.7528587Z error: this arithmetic operation will overflow
2020-03-30T14:57:43.7529210Z   --> $DIR/lints-used-unused.rs:10:20
2020-03-30T14:57:43.7529543Z    |
2020-03-30T14:57:43.7529831Z LL |     const N: i32 = 1 << 42;
---
2020-03-30T14:57:43.7536240Z 
2020-03-30T14:57:43.7536565Z error: this arithmetic operation will overflow
2020-03-30T14:57:43.7537180Z   --> $DIR/lints-used-unused.rs:21:29
2020-03-30T14:57:43.7537580Z    |
2020-03-30T14:57:43.7538129Z LL |     const N: i32 = --T::N + (-i32::MIN);
2020-03-30T14:57:43.7538950Z 
2020-03-30T14:57:43.7539265Z error: aborting due to 3 previous errors
2020-03-30T14:57:43.7539540Z 
2020-03-30T14:57:43.7539737Z 
2020-03-30T14:57:43.7539737Z 
2020-03-30T14:57:43.7539944Z 
2020-03-30T14:57:43.7540147Z 
2020-03-30T14:57:43.7540481Z The actual stderr differed from the expected stderr.
2020-03-30T14:57:43.7541381Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-const/lints-used-unused.unused/lints-used-unused.unused.stderr
2020-03-30T14:57:43.7542260Z To update references, rerun the tests and pass the `--bless` flag
2020-03-30T14:57:43.7543240Z To only update this specific test, also pass `--test-args associated-const/lints-used-unused.rs`
2020-03-30T14:57:43.7543972Z error in revision `unused`: 1 errors occurred comparing output.
2020-03-30T14:57:43.7544366Z status: exit code: 1
2020-03-30T14:57:43.7544366Z status: exit code: 1
2020-03-30T14:57:43.7546603Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/associated-const/lints-used-unused.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "unused" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-const/lints-used-unused.unused" "-Crpath" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-A" "unused" "-Copt-level=2" "--emit" "link" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-const/lints-used-unused.unused/auxiliary"
2020-03-30T14:57:43.7550774Z ------------------------------------------
2020-03-30T14:57:43.7551094Z 
2020-03-30T14:57:43.7551572Z ------------------------------------------
2020-03-30T14:57:43.7551916Z stderr:
2020-03-30T14:57:43.7551916Z stderr:
2020-03-30T14:57:43.7552405Z ------------------------------------------
2020-03-30T14:57:43.7552799Z error: this arithmetic operation will overflow
2020-03-30T14:57:43.7553477Z   --> /checkout/src/test/ui/associated-const/lints-used-unused.rs:10:20
2020-03-30T14:57:43.7554038Z    |
2020-03-30T14:57:43.7554898Z LL |     const N: i32 = 1 << 42; //~ ERROR this arithmetic operation will overflow
2020-03-30T14:57:43.7556327Z    |
2020-03-30T14:57:43.7556871Z note: the lint level is defined here
2020-03-30T14:57:43.7558215Z   --> /checkout/src/test/ui/associated-const/lints-used-unused.rs:7:9
2020-03-30T14:57:43.7558605Z    |
---
2020-03-30T14:57:43.7561903Z 
2020-03-30T14:57:43.7562216Z error: this arithmetic operation will overflow
2020-03-30T14:57:43.7572916Z   --> /checkout/src/test/ui/associated-const/lints-used-unused.rs:21:29
2020-03-30T14:57:43.7573322Z    |
2020-03-30T14:57:43.7574054Z LL |     const N: i32 = --T::N + (-i32::MIN); //~ ERROR this arithmetic operation will overflow
2020-03-30T14:57:43.7574948Z 
2020-03-30T14:57:43.7575145Z error: aborting due to 3 previous errors
2020-03-30T14:57:43.7575498Z 
2020-03-30T14:57:43.7575594Z 
2020-03-30T14:57:43.7575594Z 
2020-03-30T14:57:43.7576009Z ------------------------------------------
2020-03-30T14:57:43.7576183Z 
2020-03-30T14:57:43.7576279Z 
2020-03-30T14:57:43.7576722Z ---- [ui] ui/associated-const/lints-used-unused.rs#used stdout ----
2020-03-30T14:57:43.7577223Z error: this arithmetic operation will overflow
2020-03-30T14:57:43.7577683Z   --> $DIR/lints-used-unused.rs:10:20
2020-03-30T14:57:43.7578195Z    |
2020-03-30T14:57:43.7578386Z LL |     const N: i32 = 1 << 42;
---
2020-03-30T14:57:43.7582760Z 
2020-03-30T14:57:43.7582967Z error: this arithmetic operation will overflow
2020-03-30T14:57:43.7583393Z   --> $DIR/lints-used-unused.rs:21:29
2020-03-30T14:57:43.7583587Z    |
2020-03-30T14:57:43.7583983Z LL |     const N: i32 = --T::N + (-i32::MIN);
2020-03-30T14:57:43.7584746Z 
2020-03-30T14:57:43.7584947Z error: aborting due to 3 previous errors
2020-03-30T14:57:43.7585280Z 
2020-03-30T14:57:43.7585372Z 
2020-03-30T14:57:43.7585372Z 
2020-03-30T14:57:43.7585468Z 
2020-03-30T14:57:43.7585559Z 
2020-03-30T14:57:43.7585951Z The actual stderr differed from the expected stderr.
2020-03-30T14:57:43.7586845Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-const/lints-used-unused.used/lints-used-unused.used.stderr
2020-03-30T14:57:43.7587881Z To update references, rerun the tests and pass the `--bless` flag
2020-03-30T14:57:43.7588689Z To only update this specific test, also pass `--test-args associated-const/lints-used-unused.rs`
2020-03-30T14:57:43.7589172Z error in revision `used`: 1 errors occurred comparing output.
2020-03-30T14:57:43.7589456Z status: exit code: 1
2020-03-30T14:57:43.7589456Z status: exit code: 1
2020-03-30T14:57:43.7591963Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/associated-const/lints-used-unused.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "used" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-const/lints-used-unused.used" "-Crpath" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-A" "unused" "-Copt-level=2" "--emit" "link" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-const/lints-used-unused.used/auxiliary"
2020-03-30T14:57:43.7594038Z ------------------------------------------
2020-03-30T14:57:43.7594214Z 
2020-03-30T14:57:43.7594867Z ------------------------------------------
2020-03-30T14:57:43.7595071Z stderr:
2020-03-30T14:57:43.7595071Z stderr:
2020-03-30T14:57:43.7595433Z ------------------------------------------
2020-03-30T14:57:43.7595725Z error: this arithmetic operation will overflow
2020-03-30T14:57:43.7596270Z   --> /checkout/src/test/ui/associated-const/lints-used-unused.rs:10:20
2020-03-30T14:57:43.7596534Z    |
2020-03-30T14:57:43.7596923Z LL |     const N: i32 = 1 << 42; //~ ERROR this arithmetic operation will overflow
2020-03-30T14:57:43.7597556Z    |
2020-03-30T14:57:43.7597761Z note: the lint level is defined here
2020-03-30T14:57:43.7598297Z   --> /checkout/src/test/ui/associated-const/lints-used-unused.rs:7:9
2020-03-30T14:57:43.7598553Z    |
---
2020-03-30T14:57:43.7600865Z 
2020-03-30T14:57:43.7601063Z error: this arithmetic operation will overflow
2020-03-30T14:57:43.7601789Z   --> /checkout/src/test/ui/associated-const/lints-used-unused.rs:21:29
2020-03-30T14:57:43.7602039Z    |
2020-03-30T14:57:43.7602553Z LL |     const N: i32 = --T::N + (-i32::MIN); //~ ERROR this arithmetic operation will overflow
2020-03-30T14:57:43.7603217Z 
2020-03-30T14:57:43.7603397Z error: aborting due to 3 previous errors
2020-03-30T14:57:43.7603561Z 
2020-03-30T14:57:43.7603653Z 
2020-03-30T14:57:43.7603653Z 
2020-03-30T14:57:43.7604013Z ------------------------------------------
2020-03-30T14:57:43.7604180Z 
2020-03-30T14:57:43.7604272Z 
2020-03-30T14:57:43.7604364Z 
2020-03-30T14:57:43.7604504Z failures:
2020-03-30T14:57:43.7604898Z     [ui] ui/associated-const/lints-used-unused.rs#unused
2020-03-30T14:57:43.7605369Z     [ui] ui/associated-const/lints-used-unused.rs#used
2020-03-30T14:57:43.7606100Z test result: FAILED. 9796 passed; 2 failed; 60 ignored; 0 measured; 0 filtered out
2020-03-30T14:57:43.7606366Z 
2020-03-30T14:57:43.7606833Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-03-30T14:57:43.7607250Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-03-30T14:57:43.7607250Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-03-30T14:57:43.7607476Z 
2020-03-30T14:57:43.7607569Z 
2020-03-30T14:57:43.7611183Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-03-30T14:57:43.7613876Z 
2020-03-30T14:57:43.7613971Z 
2020-03-30T14:57:43.7614528Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
2020-03-30T14:57:43.7614898Z Build completed unsuccessfully in 1:08:09
2020-03-30T14:57:43.7614898Z Build completed unsuccessfully in 1:08:09
2020-03-30T14:57:43.7638632Z == clock drift check ==
2020-03-30T14:57:43.7664088Z   local time: Mon Mar 30 14:57:43 UTC 2020
2020-03-30T14:57:44.0357775Z   network time: Mon, 30 Mar 2020 14:57:44 GMT
2020-03-30T14:57:44.0360583Z == end clock drift check ==
2020-03-30T14:57:44.4751863Z 
2020-03-30T14:57:44.4831608Z ##[error]Bash exited with code '1'.
2020-03-30T14:57:44.4846888Z ##[section]Finishing: Run build
2020-03-30T14:57:44.4894984Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70566/merge to s
2020-03-30T14:57:44.4900472Z Task         : Get sources
2020-03-30T14:57:44.4900820Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-30T14:57:44.4901284Z Version      : 1.0.0
2020-03-30T14:57:44.4901488Z Author       : Microsoft
2020-03-30T14:57:44.4901488Z Author       : Microsoft
2020-03-30T14:57:44.4901853Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-30T14:57:44.4902232Z ==============================================================================
2020-03-30T14:57:44.8493413Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-30T14:57:44.8549042Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/70566/merge to s
2020-03-30T14:57:44.8648215Z Cleaning up task key
2020-03-30T14:57:44.8649594Z Start cleaning up orphan processes.
2020-03-30T14:57:44.8843369Z Terminate orphan process: pid (6340) (python)
2020-03-30T14:57:44.9061483Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-04-01T18:16:52.1693803Z ========================== Starting Command Output ===========================
2020-04-01T18:16:52.1696857Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/d1cb5b58-8730-43c6-b0f0-c1c2d8deb718.sh
2020-04-01T18:16:52.1697071Z 
2020-04-01T18:16:52.1700243Z ##[section]Finishing: Disable git automatic line ending conversion
2020-04-01T18:16:52.1726628Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70566/merge to s
2020-04-01T18:16:52.1732024Z Task         : Get sources
2020-04-01T18:16:52.1732471Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-01T18:16:52.1732909Z Version      : 1.0.0
2020-04-01T18:16:52.1733406Z Author       : Microsoft
---
2020-04-01T18:16:53.1807537Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-04-01T18:16:53.1812561Z ##[command]git config gc.auto 0
2020-04-01T18:16:53.1815518Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-04-01T18:16:53.1819518Z ##[command]git config --get-all http.proxy
2020-04-01T18:16:53.1824787Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70566/merge:refs/remotes/pull/70566/merge
---
2020-04-01T18:19:15.5862915Z Looks like docker image is the same as before, not uploading
2020-04-01T18:19:23.5741918Z [CI_JOB_NAME=x86_64-gnu-llvm-7]
2020-04-01T18:19:23.6109795Z [CI_JOB_NAME=x86_64-gnu-llvm-7]
2020-04-01T18:19:23.6141201Z == clock drift check ==
2020-04-01T18:19:23.6160287Z   local time: Wed Apr  1 18:19:23 UTC 2020
2020-04-01T18:19:23.9066162Z   network time: Wed, 01 Apr 2020 18:19:23 GMT
2020-04-01T18:19:23.9082091Z Starting sccache server...
2020-04-01T18:19:23.9903492Z configure: processing command line
2020-04-01T18:19:23.9903768Z configure: 
2020-04-01T18:19:23.9904548Z configure: rust.dist-src        := False
---
2020-04-01T18:24:37.6027655Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-01T18:24:39.1261051Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-01T18:24:40.7600510Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-01T18:24:42.3818250Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-01T18:24:51.3535131Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-01T18:24:54.4915832Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-01T18:24:59.2035813Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-01T18:25:03.6289935Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-01T18:25:12.4716618Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-01T18:47:54.3676839Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-01T18:47:56.1524104Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-01T18:47:58.1013342Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-01T18:48:00.3341362Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-01T18:48:10.2506906Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-01T18:48:14.1919685Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-01T18:48:19.5081436Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-01T18:48:24.9596997Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-01T18:48:34.9300448Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-01T19:14:01.5832236Z .................................................................................................... 1700/9869
2020-04-01T19:14:05.6140429Z .................................................................................................... 1800/9869
2020-04-01T19:14:14.5102989Z .................................................................................................i.. 1900/9869
2020-04-01T19:14:22.4386774Z .................................................................................................... 2000/9869
2020-04-01T19:14:28.7736849Z .......................................................................................iiiii........ 2100/9869
2020-04-01T19:14:49.5671678Z .................................................................................................... 2300/9869
2020-04-01T19:14:51.7501370Z .................................................................................................... 2400/9869
2020-04-01T19:14:54.0235360Z .................................................................................................... 2500/9869
2020-04-01T19:14:59.9549755Z .................................................................................................... 2600/9869
---
2020-04-01T19:17:48.9148465Z .............................................................i...............i...................... 5000/9869
2020-04-01T19:17:56.2354274Z .................................................................................................... 5100/9869
2020-04-01T19:18:03.8888459Z .................................................................................................... 5200/9869
2020-04-01T19:18:08.9464934Z ......i............................................................................................. 5300/9869
2020-04-01T19:18:18.8339092Z ............................................................................................ii.ii... 5400/9869
2020-04-01T19:18:23.2747889Z .....i...i.......................................................................................... 5500/9869
2020-04-01T19:18:26.7907705Z ................................i.....................................FF...F........................ 5600/9869
2020-04-01T19:18:41.4372221Z .........................................................ii....................................i.... 5800/9869
2020-04-01T19:18:48.8119893Z .................................................................................................... 5900/9869
2020-04-01T19:18:53.5511808Z .................................................................................................... 6000/9869
2020-04-01T19:18:53.5511808Z .................................................................................................... 6000/9869
2020-04-01T19:19:03.2492060Z .........................................................................................ii...i..ii. 6100/9869
2020-04-01T19:19:22.3816350Z .................................................................................................... 6300/9869
2020-04-01T19:19:29.9767971Z .................................................................................................... 6400/9869
2020-04-01T19:19:35.7974620Z .................................................................................................... 6500/9869
2020-04-01T19:19:35.7974620Z .................................................................................................... 6500/9869
2020-04-01T19:19:52.9383540Z ...................i..ii............................................................................ 6600/9869
2020-04-01T19:20:13.6373602Z .................................................................................................... 6800/9869
2020-04-01T19:20:15.6991999Z ...................i................................................................................ 6900/9869
2020-04-01T19:20:17.7148950Z .................................................................................................... 7000/9869
2020-04-01T19:20:19.9438058Z ..........................................................i......................................... 7100/9869
---
2020-04-01T19:22:00.5416484Z .................................................................................................... 7800/9869
2020-04-01T19:22:05.2955107Z .................................................................................................... 7900/9869
2020-04-01T19:22:11.3971215Z .................................................................................................... 8000/9869
2020-04-01T19:22:19.7570658Z ....................i............................................................................... 8100/9869
2020-04-01T19:22:28.0864167Z .....................................................................iiiiiiiiii.i................... 8200/9869
2020-04-01T19:22:44.0964432Z .............i......i............................................................................... 8400/9869
2020-04-01T19:22:48.9133672Z .................................................................................................... 8500/9869
2020-04-01T19:23:00.3162841Z .................................................................................................... 8600/9869
2020-04-01T19:23:11.8613923Z .................................................................................................... 8700/9869
---
2020-04-01T19:25:06.5314865Z failures:
2020-04-01T19:25:06.5340051Z 
2020-04-01T19:25:06.5341351Z ---- [ui] ui/lint/lint-exceeding-bitshifts.rs#noopt stdout ----
2020-04-01T19:25:06.5341780Z 
2020-04-01T19:25:06.5342418Z error in revision `noopt`: /checkout/src/test/ui/lint/lint-exceeding-bitshifts.rs:18: expected error not found: arithmetic operation will overflow
2020-04-01T19:25:06.5342756Z 
2020-04-01T19:25:06.5342976Z error in revision `noopt`: 0 unexpected errors found, 1 expected errors not found
2020-04-01T19:25:06.5343243Z status: exit code: 1
2020-04-01T19:25:06.5344912Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/lint-exceeding-bitshifts.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "noopt" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts.noopt" "-Crpath" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-A" "unused" "-C" "opt-level=0" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts.noopt/auxiliary"
2020-04-01T19:25:06.5346496Z     Error {
2020-04-01T19:25:06.5346657Z         line_num: 18,
2020-04-01T19:25:06.5346815Z         kind: Some(
2020-04-01T19:25:06.5346961Z             Error,
---
2020-04-01T19:25:06.5352152Z error in revision `opt`: /checkout/src/test/ui/lint/lint-exceeding-bitshifts.rs:18: expected error not found: arithmetic operation will overflow
2020-04-01T19:25:06.5352489Z 
2020-04-01T19:25:06.5352703Z error in revision `opt`: 0 unexpected errors found, 1 expected errors not found
2020-04-01T19:25:06.5352949Z status: exit code: 1
2020-04-01T19:25:06.5354586Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/lint-exceeding-bitshifts.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "opt" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts.opt" "-Crpath" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-A" "unused" "-O" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts.opt/auxiliary"
2020-04-01T19:25:06.5361431Z     Error {
2020-04-01T19:25:06.5361756Z         line_num: 18,
2020-04-01T19:25:06.5361932Z         kind: Some(
2020-04-01T19:25:06.5362089Z             Error,
---
2020-04-01T19:25:06.5364044Z ---- [ui] ui/lint/lint-exceeding-bitshifts.rs#opt_with_overflow_checks stdout ----
2020-04-01T19:25:06.5364234Z 
2020-04-01T19:25:06.5364841Z error in revision `opt_with_overflow_checks`: /checkout/src/test/ui/lint/lint-exceeding-bitshifts.rs:18: expected error not found: arithmetic operation will overflow
2020-04-01T19:25:06.5365187Z 
2020-04-01T19:25:06.5365432Z error in revision `opt_with_overflow_checks`: 0 unexpected errors found, 1 expected errors not found
2020-04-01T19:25:06.5365726Z status: exit code: 1
2020-04-01T19:25:06.5368098Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/lint-exceeding-bitshifts.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "opt_with_overflow_checks" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts.opt_with_overflow_checks" "-Crpath" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-A" "unused" "-C" "overflow-checks=on" "-O" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts.opt_with_overflow_checks/auxiliary"
2020-04-01T19:25:06.5369575Z     Error {
2020-04-01T19:25:06.5369730Z         line_num: 18,
2020-04-01T19:25:06.5369901Z         kind: Some(
2020-04-01T19:25:06.5370079Z             Error,
---
2020-04-01T19:25:06.5378731Z 
2020-04-01T19:25:06.5379213Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-04-01T19:25:06.5379443Z 
2020-04-01T19:25:06.5379541Z 
2020-04-01T19:25:06.5383428Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-04-01T19:25:06.5388498Z 
2020-04-01T19:25:06.5388592Z 
2020-04-01T19:25:06.5389220Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
2020-04-01T19:25:06.5389592Z Build completed unsuccessfully in 1:04:04
2020-04-01T19:25:06.5389592Z Build completed unsuccessfully in 1:04:04
2020-04-01T19:25:06.5446721Z == clock drift check ==
2020-04-01T19:25:06.5466378Z   local time: Wed Apr  1 19:25:06 UTC 2020
2020-04-01T19:25:06.7105904Z   network time: Wed, 01 Apr 2020 19:25:06 GMT
2020-04-01T19:25:07.1356427Z 
2020-04-01T19:25:07.1356427Z 
2020-04-01T19:25:07.1441580Z ##[error]Bash exited with code '1'.
2020-04-01T19:25:07.1454510Z ##[section]Finishing: Run build
2020-04-01T19:25:07.1499992Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70566/merge to s
2020-04-01T19:25:07.1504667Z Task         : Get sources
2020-04-01T19:25:07.1504997Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-01T19:25:07.1505292Z Version      : 1.0.0
2020-04-01T19:25:07.1505490Z Author       : Microsoft
2020-04-01T19:25:07.1505490Z Author       : Microsoft
2020-04-01T19:25:07.1505820Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-04-01T19:25:07.1506193Z ==============================================================================
2020-04-01T19:25:07.4787739Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-04-01T19:25:07.4833639Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/70566/merge to s
2020-04-01T19:25:07.4935423Z Cleaning up task key
2020-04-01T19:25:07.4936603Z Start cleaning up orphan processes.
2020-04-01T19:25:07.5127416Z Terminate orphan process: pid (3926) (python)
2020-04-01T19:25:07.5310558Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-04-01T19:45:24.4236856Z ========================== Starting Command Output ===========================
2020-04-01T19:45:24.4239245Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/121c1ea6-b093-439e-8a0b-0657e586e43f.sh
2020-04-01T19:45:24.4239526Z 
2020-04-01T19:45:24.4243202Z ##[section]Finishing: Disable git automatic line ending conversion
2020-04-01T19:45:24.4261781Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70566/merge to s
2020-04-01T19:45:24.4264759Z Task         : Get sources
2020-04-01T19:45:24.4265044Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-01T19:45:24.4265322Z Version      : 1.0.0
2020-04-01T19:45:24.4265508Z Author       : Microsoft
---
2020-04-01T19:45:25.4196405Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-04-01T19:45:25.4205307Z ##[command]git config gc.auto 0
2020-04-01T19:45:25.4211628Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-04-01T19:45:25.4217407Z ##[command]git config --get-all http.proxy
2020-04-01T19:45:25.4227373Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70566/merge:refs/remotes/pull/70566/merge
---
2020-04-01T19:47:35.2788434Z Looks like docker image is the same as before, not uploading
2020-04-01T19:47:42.8922731Z [CI_JOB_NAME=x86_64-gnu-llvm-7]
2020-04-01T19:47:42.9167308Z [CI_JOB_NAME=x86_64-gnu-llvm-7]
2020-04-01T19:47:42.9190472Z == clock drift check ==
2020-04-01T19:47:42.9198194Z   local time: Wed Apr  1 19:47:42 UTC 2020
2020-04-01T19:47:43.2153421Z   network time: Wed, 01 Apr 2020 19:47:43 GMT
2020-04-01T19:47:43.2181329Z Starting sccache server...
2020-04-01T19:47:43.2991543Z configure: processing command line
2020-04-01T19:47:43.2992359Z configure: 
2020-04-01T19:47:43.2993944Z configure: rust.dist-src        := False
---
2020-04-01T19:52:35.4291280Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-01T19:52:36.8263270Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-01T19:52:38.3299377Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-01T19:52:40.2089934Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-01T19:52:47.8196249Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-01T19:52:50.1624451Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-01T19:52:54.1439834Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-01T19:52:57.9646965Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-01T19:53:06.9035594Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-01T20:13:58.9126881Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-01T20:14:00.4890825Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-01T20:14:02.3200241Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-01T20:14:03.3314076Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-01T20:14:14.1016383Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-01T20:14:16.1925622Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-01T20:14:21.2628315Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-01T20:14:26.4144979Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-01T20:14:39.5539300Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-01T20:38:30.6713152Z .................................................................................................... 1700/9872
2020-04-01T20:38:34.7321252Z .................................................................................................... 1800/9872
2020-04-01T20:38:43.2609447Z .................................................................................................i.. 1900/9872
2020-04-01T20:38:50.6910305Z .................................................................................................... 2000/9872
2020-04-01T20:38:56.7936765Z .......................................................................................iiiii........ 2100/9872
2020-04-01T20:39:16.8480234Z .................................................................................................... 2300/9872
2020-04-01T20:39:18.9207364Z .................................................................................................... 2400/9872
2020-04-01T20:39:21.1438922Z .................................................................................................... 2500/9872
2020-04-01T20:39:26.7557853Z .................................................................................................... 2600/9872
---
2020-04-01T20:42:09.2295072Z .............................................................i...............i...................... 5000/9872
2020-04-01T20:42:16.4893983Z .................................................................................................... 5100/9872
2020-04-01T20:42:24.0758260Z .................................................................................................... 5200/9872
2020-04-01T20:42:29.3546860Z ......i............................................................................................. 5300/9872
2020-04-01T20:42:38.9807472Z ............................................................................................ii.ii... 5400/9872
2020-04-01T20:42:43.2482969Z .....i...i.......................................................................................... 5500/9872
2020-04-01T20:42:46.5327389Z ................................i.....................................FFF........................... 5600/9872
2020-04-01T20:42:51.3320005Z ........................................i........................................................... 5700/9872
2020-04-01T20:43:00.1257935Z ............................................................ii....................................i. 5800/9872
2020-04-01T20:43:11.4788049Z .................................................................................................... 6000/9872
2020-04-01T20:43:11.4788049Z .................................................................................................... 6000/9872
2020-04-01T20:43:20.6540832Z ............................................................................................ii...i.. 6100/9872
2020-04-01T20:43:31.9021718Z ii...........i...................................................................................... 6200/9872
2020-04-01T20:43:46.7344877Z .................................................................................................... 6400/9872
2020-04-01T20:43:49.4976874Z .................................................................................................... 6500/9872
2020-04-01T20:43:49.4976874Z .................................................................................................... 6500/9872
2020-04-01T20:44:01.2730017Z ......................i..ii......................................................................... 6600/9872
2020-04-01T20:44:20.8681600Z .................................................................................................... 6800/9872
2020-04-01T20:44:22.8629400Z ......................i............................................................................. 6900/9872
2020-04-01T20:44:24.8798976Z .................................................................................................... 7000/9872
2020-04-01T20:44:26.9935247Z .............................................................i...................................... 7100/9872
---
2020-04-01T20:46:01.3254036Z .................................................................................................... 7800/9872
2020-04-01T20:46:05.7915822Z .................................................................................................... 7900/9872
2020-04-01T20:46:11.4752729Z .................................................................................................... 8000/9872
2020-04-01T20:46:19.2322320Z .......................i............................................................................ 8100/9872
2020-04-01T20:46:27.0931455Z ........................................................................iiiiiiiiii.i................ 8200/9872
2020-04-01T20:46:42.5737481Z ................i......i............................................................................ 8400/9872
2020-04-01T20:46:47.0304998Z .................................................................................................... 8500/9872
2020-04-01T20:46:56.9645457Z .................................................................................................... 8600/9872
2020-04-01T20:47:07.6530673Z .................................................................................................... 8700/9872
---
2020-04-01T20:48:56.0822794Z normalized stderr:
2020-04-01T20:48:56.0823071Z error: this arithmetic operation will overflow
2020-04-01T20:48:56.0823589Z   --> $DIR/lint-exceeding-bitshifts-assoc-const.rs:19:20
2020-04-01T20:48:56.0823827Z    |
2020-04-01T20:48:56.0824037Z LL |     const N: i32 = T::N << 42;
2020-04-01T20:48:56.0824562Z    |
2020-04-01T20:48:56.0824758Z note: the lint level is defined here
2020-04-01T20:48:56.0825235Z   --> $DIR/lint-exceeding-bitshifts-assoc-const.rs:10:9
2020-04-01T20:48:56.0825463Z    |
---
2020-04-01T20:48:56.0826460Z 
2020-04-01T20:48:56.0826550Z 
2020-04-01T20:48:56.0826639Z 
2020-04-01T20:48:56.0826932Z The actual stderr differed from the expected stderr.
2020-04-01T20:48:56.0827639Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts-assoc-const.noopt/lint-exceeding-bitshifts-assoc-const.noopt.stderr
2020-04-01T20:48:56.0828717Z To update references, rerun the tests and pass the `--bless` flag
2020-04-01T20:48:56.0829575Z To only update this specific test, also pass `--test-args lint/lint-exceeding-bitshifts-assoc-const.rs`
2020-04-01T20:48:56.0829860Z 
2020-04-01T20:48:56.0830102Z error in revision `noopt`: 1 errors occurred comparing output.
2020-04-01T20:48:56.0830403Z status: exit code: 1
2020-04-01T20:48:56.0832634Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/lint-exceeding-bitshifts-assoc-const.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "noopt" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts-assoc-const.noopt" "-Crpath" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-A" "unused" "-C" "opt-level=0" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts-assoc-const.noopt/auxiliary"
2020-04-01T20:48:56.0837072Z ------------------------------------------
2020-04-01T20:48:56.0837253Z 
2020-04-01T20:48:56.0837668Z ------------------------------------------
2020-04-01T20:48:56.0837877Z stderr:
2020-04-01T20:48:56.0837877Z stderr:
2020-04-01T20:48:56.0838270Z ------------------------------------------
2020-04-01T20:48:56.0838570Z error: this arithmetic operation will overflow
2020-04-01T20:48:56.0839164Z   --> /checkout/src/test/ui/lint/lint-exceeding-bitshifts-assoc-const.rs:19:20
2020-04-01T20:48:56.0839453Z    |
2020-04-01T20:48:56.0839790Z LL |     const N: i32 = T::N << 42; //~ ERROR: arithmetic operation will overflow
2020-04-01T20:48:56.0840627Z    |
2020-04-01T20:48:56.0840901Z note: the lint level is defined here
2020-04-01T20:48:56.0841478Z   --> /checkout/src/test/ui/lint/lint-exceeding-bitshifts-assoc-const.rs:10:9
2020-04-01T20:48:56.0841752Z    |
---
2020-04-01T20:48:56.0844230Z normalized stderr:
2020-04-01T20:48:56.0844448Z error: this arithmetic operation will overflow
2020-04-01T20:48:56.0844954Z   --> $DIR/lint-exceeding-bitshifts-assoc-const.rs:19:20
2020-04-01T20:48:56.0845189Z    |
2020-04-01T20:48:56.0845382Z LL |     const N: i32 = T::N << 42;
2020-04-01T20:48:56.0845921Z    |
2020-04-01T20:48:56.0846097Z note: the lint level is defined here
2020-04-01T20:48:56.0846584Z   --> $DIR/lint-exceeding-bitshifts-assoc-const.rs:10:9
2020-04-01T20:48:56.0846813Z    |
---
2020-04-01T20:48:56.0847781Z 
2020-04-01T20:48:56.0847874Z 
2020-04-01T20:48:56.0847954Z 
2020-04-01T20:48:56.0848122Z The actual stderr differed from the expected stderr.
2020-04-01T20:48:56.0848787Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts-assoc-const.opt/lint-exceeding-bitshifts-assoc-const.opt.stderr
2020-04-01T20:48:56.0849413Z To update references, rerun the tests and pass the `--bless` flag
2020-04-01T20:48:56.0849948Z To only update this specific test, also pass `--test-args lint/lint-exceeding-bitshifts-assoc-const.rs`
2020-04-01T20:48:56.0850387Z error in revision `opt`: 1 errors occurred comparing output.
2020-04-01T20:48:56.0850615Z status: exit code: 1
2020-04-01T20:48:56.0850615Z status: exit code: 1
2020-04-01T20:48:56.0852385Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/lint-exceeding-bitshifts-assoc-const.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "opt" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts-assoc-const.opt" "-Crpath" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-A" "unused" "-O" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts-assoc-const.opt/auxiliary"
2020-04-01T20:48:56.0853817Z ------------------------------------------
2020-04-01T20:48:56.0853962Z 
2020-04-01T20:48:56.0854273Z ------------------------------------------
2020-04-01T20:48:56.0854442Z stderr:
2020-04-01T20:48:56.0854442Z stderr:
2020-04-01T20:48:56.0854773Z ------------------------------------------
2020-04-01T20:48:56.0855000Z error: this arithmetic operation will overflow
2020-04-01T20:48:56.0855563Z   --> /checkout/src/test/ui/lint/lint-exceeding-bitshifts-assoc-const.rs:19:20
2020-04-01T20:48:56.0855780Z    |
2020-04-01T20:48:56.0856001Z LL |     const N: i32 = T::N << 42; //~ ERROR: arithmetic operation will overflow
2020-04-01T20:48:56.0856469Z    |
2020-04-01T20:48:56.0856602Z note: the lint level is defined here
2020-04-01T20:48:56.0857000Z   --> /checkout/src/test/ui/lint/lint-exceeding-bitshifts-assoc-const.rs:10:9
2020-04-01T20:48:56.0857255Z    |
---
2020-04-01T20:48:56.0859559Z normalized stderr:
2020-04-01T20:48:56.0859749Z error: this arithmetic operation will overflow
2020-04-01T20:48:56.0860174Z   --> $DIR/lint-exceeding-bitshifts-assoc-const.rs:19:20
2020-04-01T20:48:56.0860391Z    |
2020-04-01T20:48:56.0860555Z LL |     const N: i32 = T::N << 42;
2020-04-01T20:48:56.0861030Z    |
2020-04-01T20:48:56.0861190Z note: the lint level is defined here
2020-04-01T20:48:56.0861598Z   --> $DIR/lint-exceeding-bitshifts-assoc-const.rs:10:9
2020-04-01T20:48:56.0861795Z    |
---
2020-04-01T20:48:56.0862661Z 
2020-04-01T20:48:56.0862738Z 
2020-04-01T20:48:56.0862817Z 
2020-04-01T20:48:56.0862999Z The actual stderr differed from the expected stderr.
2020-04-01T20:48:56.0863746Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts-assoc-const.opt_with_overflow_checks/lint-exceeding-bitshifts-assoc-const.opt_with_overflow_checks.stderr
2020-04-01T20:48:56.0864406Z To update references, rerun the tests and pass the `--bless` flag
2020-04-01T20:48:56.0864954Z To only update this specific test, also pass `--test-args lint/lint-exceeding-bitshifts-assoc-const.rs`
2020-04-01T20:48:56.0865188Z 
2020-04-01T20:48:56.0865818Z error in revision `opt_with_overflow_checks`: 1 errors occurred comparing output.
2020-04-01T20:48:56.0866162Z status: exit code: 1
2020-04-01T20:48:56.0868569Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/lint-exceeding-bitshifts-assoc-const.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--cfg" "opt_with_overflow_checks" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts-assoc-const.opt_with_overflow_checks" "-Crpath" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-A" "unused" "-C" "overflow-checks=on" "-O" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts-assoc-const.opt_with_overflow_checks/auxiliary"
2020-04-01T20:48:56.0870509Z ------------------------------------------
2020-04-01T20:48:56.0870704Z 
2020-04-01T20:48:56.0871091Z ------------------------------------------
2020-04-01T20:48:56.0871300Z stderr:
2020-04-01T20:48:56.0871300Z stderr:
2020-04-01T20:48:56.0871690Z ------------------------------------------
2020-04-01T20:48:56.0871988Z error: this arithmetic operation will overflow
2020-04-01T20:48:56.0872573Z   --> /checkout/src/test/ui/lint/lint-exceeding-bitshifts-assoc-const.rs:19:20
2020-04-01T20:48:56.0872877Z    |
2020-04-01T20:48:56.0885891Z LL |     const N: i32 = T::N << 42; //~ ERROR: arithmetic operation will overflow
2020-04-01T20:48:56.0886543Z    |
2020-04-01T20:48:56.0886717Z note: the lint level is defined here
2020-04-01T20:48:56.0887564Z   --> /checkout/src/test/ui/lint/lint-exceeding-bitshifts-assoc-const.rs:10:9
2020-04-01T20:48:56.0887979Z    |
---
2020-04-01T20:48:56.0892652Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-04-01T20:48:56.0892971Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-04-01T20:48:56.0893138Z 
2020-04-01T20:48:56.0893207Z 
2020-04-01T20:48:56.0896400Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-04-01T20:48:56.0898610Z 
2020-04-01T20:48:56.0898694Z 
2020-04-01T20:48:56.0899135Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
2020-04-01T20:48:56.0899445Z Build completed unsuccessfully in 0:59:35
2020-04-01T20:48:56.0899445Z Build completed unsuccessfully in 0:59:35
2020-04-01T20:48:56.0938874Z == clock drift check ==
2020-04-01T20:48:56.0950597Z   local time: Wed Apr  1 20:48:56 UTC 2020
2020-04-01T20:48:56.2644926Z   network time: Wed, 01 Apr 2020 20:48:56 GMT
2020-04-01T20:48:56.7024343Z 
2020-04-01T20:48:56.7024343Z 
2020-04-01T20:48:56.7110398Z ##[error]Bash exited with code '1'.
2020-04-01T20:48:56.7124981Z ##[section]Finishing: Run build
2020-04-01T20:48:56.7169449Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70566/merge to s
2020-04-01T20:48:56.7175606Z Task         : Get sources
2020-04-01T20:48:56.7175989Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-01T20:48:56.7176319Z Version      : 1.0.0
2020-04-01T20:48:56.7176553Z Author       : Microsoft
2020-04-01T20:48:56.7176553Z Author       : Microsoft
2020-04-01T20:48:56.7176933Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-04-01T20:48:56.7177457Z ==============================================================================
2020-04-01T20:48:57.0281863Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-04-01T20:48:57.0329988Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/70566/merge to s
2020-04-01T20:48:57.0415599Z Cleaning up task key
2020-04-01T20:48:57.0416760Z Start cleaning up orphan processes.
2020-04-01T20:48:57.0596601Z Terminate orphan process: pid (3633) (python)
2020-04-01T20:48:57.0802757Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@jumbatm jumbatm force-pushed the exceeding-bitshifts-constprop branch from c3eaa3e to 19a665b Compare April 2, 2020 01:57
@oli-obk
Copy link
Contributor

oli-obk commented Apr 2, 2020

@bors try

@bors
Copy link
Contributor

bors commented Apr 2, 2020

⌛ Trying commit 19a665b1640d614ee7f76533f83e4743866060b5 with merge 3b9ef566a383a39e6b30850d4c26521d95e051fc...

@oli-obk
Copy link
Contributor

oli-obk commented Apr 2, 2020

@rust-timer build

@bors
Copy link
Contributor

bors commented Apr 2, 2020

☀️ Try build successful - checks-azure
Build commit: 3b9ef566a383a39e6b30850d4c26521d95e051fc (3b9ef566a383a39e6b30850d4c26521d95e051fc)

@RalfJung
Copy link
Member

RalfJung commented Apr 2, 2020 •
edited
Loading

@jumbatm you used to have some new tests for arithmetic in associated consts in an earlier version of this PR. Those tests already pass, but having the order of operators swapped might still be interesting just in case their order in the MIR ever matters. Care to submit a separate PR that extends the existing src/test/ui/consts/issue-69020.rs with those cases?
You could also rename it to src/test/ui/consts/issue-69020-assoc-const-arith-overflow.rs. (@oli-obk is there another folder this could move into?)

@oli-obk
Copy link
Contributor

oli-obk commented Apr 2, 2020

We could start a const_prop folder to separate out the const prop things from the const eval things

@jumbatm
Copy link
Contributor Author

jumbatm commented Apr 2, 2020

Care to submit a separate PR that extends the existing src/test/ui/consts/issue-69020.rs with those cases?

Sure thing!

is there another folder this could move into?

We could start a const_prop folder to separate out the const prop things from the const eval things

In my opinion, a const_prop folder would imply testing the mir after propagation was correct (and indeed, we already have a const_prop folder for this in mir-opt). Additionally, if this lint's implementation was moved out of const_prop (which could happen to solve the issue of debug and release builds giving different lints), we'd have to move the test somewhere else.

I'd say because we're checking lints get emitted properly (ie, a ui test), it makes sense to me to put it under the existing src/test/ui/associated-const.

@oli-obk
Copy link
Contributor

oli-obk commented Apr 2, 2020

I'd say because we're checking lints get emitted properly (ie, a ui test), it makes sense to me to put it under the existing src/test/ui/associated-const.

That's a good place indeed

@RalfJung
Copy link
Member

RalfJung commented Apr 2, 2020 •
edited
Loading

There's also src/test/ui/lint. That's where the bitshift test is. We have too many folders.^^

@jumbatm jumbatm force-pushed the exceeding-bitshifts-constprop branch from 19a665b to 4e7b6b6 Compare April 2, 2020 12:30
@jumbatm jumbatm mentioned this pull request Apr 2, 2020
Merged
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
2020-04-02T12:37:44.2158096Z ========================== Starting Command Output ===========================
2020-04-02T12:37:44.2160320Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/72798034-e5b2-4852-a680-176b8bfb908f.sh
2020-04-02T12:37:44.2160582Z 
2020-04-02T12:37:44.2164140Z ##[section]Finishing: Disable git automatic line ending conversion
2020-04-02T12:37:44.2182192Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70566/merge to s
2020-04-02T12:37:44.2185466Z Task         : Get sources
2020-04-02T12:37:44.2185775Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-02T12:37:44.2186092Z Version      : 1.0.0
2020-04-02T12:37:44.2186296Z Author       : Microsoft
---
2020-04-02T12:37:45.2121064Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-04-02T12:37:45.2125872Z ##[command]git config gc.auto 0
2020-04-02T12:37:45.2129125Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-04-02T12:37:45.2131762Z ##[command]git config --get-all http.proxy
2020-04-02T12:37:45.2135962Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70566/merge:refs/remotes/pull/70566/merge
---
2020-04-02T12:40:35.0631758Z Looks like docker image is the same as before, not uploading
2020-04-02T12:40:42.1091703Z [CI_JOB_NAME=x86_64-gnu-llvm-7]
2020-04-02T12:40:42.7656992Z [CI_JOB_NAME=x86_64-gnu-llvm-7]
2020-04-02T12:40:42.7663645Z == clock drift check ==
2020-04-02T12:40:42.7664041Z   local time: Thu Apr  2 12:40:42 UTC 2020
2020-04-02T12:40:42.7664444Z   network time: Thu, 02 Apr 2020 12:40:42 GMT
2020-04-02T12:40:42.7665062Z Starting sccache server...
2020-04-02T12:40:42.7665345Z configure: processing command line
2020-04-02T12:40:42.7665629Z configure: 
2020-04-02T12:40:42.7666481Z configure: rust.dist-src        := False
---
2020-04-02T12:45:14.5551798Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-02T12:45:15.8869766Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-02T12:45:17.3046642Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-02T12:45:18.3472661Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-02T12:45:26.3674780Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-02T12:45:27.8595601Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-02T12:45:31.7219150Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-02T12:45:35.3399798Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-02T12:45:44.4059896Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-02T13:05:38.1830321Z    Compiling rustc_feature v0.0.0 (/checkout/src/librustc_feature)
2020-04-02T13:05:39.7899058Z    Compiling fmt_macros v0.0.0 (/checkout/src/libfmt_macros)
2020-04-02T13:05:41.5857152Z    Compiling rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty)
2020-04-02T13:05:42.9724136Z    Compiling rustc_hir v0.0.0 (/checkout/src/librustc_hir)
2020-04-02T13:05:53.0540371Z    Compiling rustc_query_system v0.0.0 (/checkout/src/librustc_query_system)
2020-04-02T13:05:55.4758900Z    Compiling rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty)
2020-04-02T13:06:00.1344347Z    Compiling rustc_attr v0.0.0 (/checkout/src/librustc_attr)
2020-04-02T13:06:05.2830731Z    Compiling rustc_parse v0.0.0 (/checkout/src/librustc_parse)
2020-04-02T13:06:15.7274240Z    Compiling rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering)
---
2020-04-02T13:29:32.7735852Z .................................................................................................... 1700/9869
2020-04-02T13:29:37.0611316Z .................................................................................................... 1800/9869
2020-04-02T13:29:45.8078029Z ................................................................................................i... 1900/9869
2020-04-02T13:29:53.4502625Z .................................................................................................... 2000/9869
2020-04-02T13:29:59.5397294Z ......................................................................................iiiii......... 2100/9869
2020-04-02T13:30:18.9121411Z .................................................................................................... 2300/9869
2020-04-02T13:30:21.0124699Z .................................................................................................... 2400/9869
2020-04-02T13:30:23.2048292Z .................................................................................................... 2500/9869
2020-04-02T13:30:28.9870173Z .................................................................................................... 2600/9869
---
2020-04-02T13:33:05.8315184Z ............................................................i...............i....................... 5000/9869
2020-04-02T13:33:12.2969329Z .................................................................................................... 5100/9869
2020-04-02T13:33:18.9421190Z .................................................................................................... 5200/9869
2020-04-02T13:33:23.4287430Z .....i.............................................................................................. 5300/9869
2020-04-02T13:33:32.6556142Z ...........................................................................................ii.ii.... 5400/9869
2020-04-02T13:33:36.8483485Z ....i...i........................................................................................... 5500/9869
2020-04-02T13:33:44.9323379Z ....................................i............................................................... 5700/9869
2020-04-02T13:33:54.4513970Z ........................................................ii....................................i..... 5800/9869
2020-04-02T13:34:01.6327999Z .................................................................................................... 5900/9869
2020-04-02T13:34:06.0552227Z .................................................................................................... 6000/9869
2020-04-02T13:34:06.0552227Z .................................................................................................... 6000/9869
2020-04-02T13:34:14.4190148Z ........................................................................................ii...i..ii.. 6100/9869
2020-04-02T13:34:33.7048122Z .................................................................................................... 6300/9869
2020-04-02T13:34:37.9924697Z .................................................................................................... 6400/9869
2020-04-02T13:34:40.5531482Z .................................................................................................... 6500/9869
2020-04-02T13:34:40.5531482Z .................................................................................................... 6500/9869
2020-04-02T13:34:51.6250002Z ..................i..ii............................................................................. 6600/9869
2020-04-02T13:35:10.3584369Z .................................................................................................... 6800/9869
2020-04-02T13:35:12.2803244Z ..................i................................................................................. 6900/9869
2020-04-02T13:35:14.1641249Z .................................................................................................... 7000/9869
2020-04-02T13:35:16.0806541Z .........................................................i.......................................... 7100/9869
---
2020-04-02T13:36:43.8537172Z .................................................................................................... 7800/9869
2020-04-02T13:36:47.9764973Z .................................................................................................... 7900/9869
2020-04-02T13:36:53.1365938Z .................................................................................................... 8000/9869
2020-04-02T13:37:00.0883550Z ...................i................................................................................ 8100/9869
2020-04-02T13:37:07.4241330Z ....................................................................iiiiiiiiii.i.................... 8200/9869
2020-04-02T13:37:20.4954020Z ............i......i................................................................................ 8400/9869
2020-04-02T13:37:24.5756666Z .................................................................................................... 8500/9869
2020-04-02T13:37:34.3900263Z .................................................................................................... 8600/9869
2020-04-02T13:37:44.7266863Z .................................................................................................... 8700/9869
---
2020-04-02T13:39:27.7369774Z 
2020-04-02T13:39:27.7370117Z error: this arithmetic operation will overflow
2020-04-02T13:39:27.7370617Z   --> $DIR/lints-used-unused.rs:21:35
2020-04-02T13:39:27.7370806Z    |
2020-04-02T13:39:27.7371328Z LL |     const USED: i32 = --T::USED + (-i32::MIN);
2020-04-02T13:39:27.7371830Z 
2020-04-02T13:39:27.7371983Z error: aborting due to 5 previous errors
2020-04-02T13:39:27.7372135Z 
2020-04-02T13:39:27.7372214Z 
2020-04-02T13:39:27.7372214Z 
2020-04-02T13:39:27.7372291Z 
2020-04-02T13:39:27.7372369Z 
2020-04-02T13:39:27.7372538Z The actual stderr differed from the expected stderr.
2020-04-02T13:39:27.7373125Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-const/lints-used-unused/lints-used-unused.stderr
2020-04-02T13:39:27.7373663Z To update references, rerun the tests and pass the `--bless` flag
2020-04-02T13:39:27.7374184Z To only update this specific test, also pass `--test-args associated-const/lints-used-unused.rs`
2020-04-02T13:39:27.7374561Z error: 1 errors occurred comparing output.
2020-04-02T13:39:27.7374756Z status: exit code: 1
2020-04-02T13:39:27.7374756Z status: exit code: 1
2020-04-02T13:39:27.7376462Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/associated-const/lints-used-unused.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-const/lints-used-unused" "-Crpath" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-A" "unused" "-Copt-level=2" "--emit" "link" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/associated-const/lints-used-unused/auxiliary"
2020-04-02T13:39:27.7380580Z ------------------------------------------
2020-04-02T13:39:27.7380729Z 
2020-04-02T13:39:27.7381047Z ------------------------------------------
2020-04-02T13:39:27.7381231Z stderr:
2020-04-02T13:39:27.7381231Z stderr:
2020-04-02T13:39:27.7381534Z ------------------------------------------
2020-04-02T13:39:27.7381775Z error: this arithmetic operation will overflow
2020-04-02T13:39:27.7382217Z   --> /checkout/src/test/ui/associated-const/lints-used-unused.rs:9:23
2020-04-02T13:39:27.7382430Z    |
2020-04-02T13:39:27.7382679Z LL |     const USED: i32 = 1 << 42; //~ ERROR this arithmetic operation will overflow
2020-04-02T13:39:27.7383202Z    |
2020-04-02T13:39:27.7383369Z note: the lint level is defined here
2020-04-02T13:39:27.7383783Z   --> /checkout/src/test/ui/associated-const/lints-used-unused.rs:6:9
2020-04-02T13:39:27.7383998Z    |
2020-04-02T13:39:27.7383998Z    |
2020-04-02T13:39:27.7384150Z LL | #![deny(arithmetic_overflow)]
2020-04-02T13:39:27.7384352Z    |         ^^^^^^^^^^^^^^^^^^^
2020-04-02T13:39:27.7384477Z 
2020-04-02T13:39:27.7384640Z error: this arithmetic operation will overflow
2020-04-02T13:39:27.7385094Z   --> /checkout/src/test/ui/associated-const/lints-used-unused.rs:10:25
2020-04-02T13:39:27.7385307Z    |
2020-04-02T13:39:27.7385542Z LL |     const UNUSED: i32 = 1 << 123; //~ ERROR this arithmetic operation will overflow
2020-04-02T13:39:27.7386072Z 
2020-04-02T13:39:27.7386234Z error: this arithmetic operation will overflow
2020-04-02T13:39:27.7386852Z   --> /checkout/src/test/ui/associated-const/lints-used-unused.rs:16:23
2020-04-02T13:39:27.7387107Z    |
2020-04-02T13:39:27.7387107Z    |
2020-04-02T13:39:27.7387374Z LL |     const USED: i32 = 1 << 4242; //~ ERROR this arithmetic operation will overflow
2020-04-02T13:39:27.7395115Z 
2020-04-02T13:39:27.7395352Z error: this arithmetic operation will overflow
2020-04-02T13:39:27.7396402Z   --> /checkout/src/test/ui/associated-const/lints-used-unused.rs:17:25
2020-04-02T13:39:27.7396690Z    |
2020-04-02T13:39:27.7396690Z    |
2020-04-02T13:39:27.7397240Z LL |     const UNUSED: i32 = 1 << 123123; //~ ERROR this arithmetic operation will overflow
2020-04-02T13:39:27.7398020Z 
2020-04-02T13:39:27.7398212Z error: this arithmetic operation will overflow
2020-04-02T13:39:27.7398923Z   --> /checkout/src/test/ui/associated-const/lints-used-unused.rs:21:35
2020-04-02T13:39:27.7399189Z    |
2020-04-02T13:39:27.7399189Z    |
2020-04-02T13:39:27.7399871Z LL |     const USED: i32 = --T::USED + (-i32::MIN); //~ ERROR this arithmetic operation will overflow
2020-04-02T13:39:27.7400667Z 
2020-04-02T13:39:27.7400970Z error: aborting due to 5 previous errors
2020-04-02T13:39:27.7401110Z 
2020-04-02T13:39:27.7401189Z 
---
2020-04-02T13:39:27.7403516Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-04-02T13:39:27.7403855Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-04-02T13:39:27.7404045Z 
2020-04-02T13:39:27.7404123Z 
2020-04-02T13:39:27.7407194Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-04-02T13:39:27.7409425Z 
2020-04-02T13:39:27.7409520Z 
2020-04-02T13:39:27.7430030Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --exclude src/tools/tidy
2020-04-02T13:39:27.7431500Z Build completed unsuccessfully in 0:57:21
2020-04-02T13:39:27.7431500Z Build completed unsuccessfully in 0:57:21
2020-04-02T13:39:27.7456986Z == clock drift check ==
2020-04-02T13:39:27.7482418Z   local time: Thu Apr  2 13:39:27 UTC 2020
2020-04-02T13:39:27.9153166Z   network time: Thu, 02 Apr 2020 13:39:27 GMT
2020-04-02T13:39:28.3182193Z 
2020-04-02T13:39:28.3182193Z 
2020-04-02T13:39:28.3254379Z ##[error]Bash exited with code '1'.
2020-04-02T13:39:28.3266148Z ##[section]Finishing: Run build
2020-04-02T13:39:28.3309742Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70566/merge to s
2020-04-02T13:39:28.3314210Z Task         : Get sources
2020-04-02T13:39:28.3314494Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-04-02T13:39:28.3314753Z Version      : 1.0.0
2020-04-02T13:39:28.3314950Z Author       : Microsoft
2020-04-02T13:39:28.3314950Z Author       : Microsoft
2020-04-02T13:39:28.3315251Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-04-02T13:39:28.3315581Z ==============================================================================
2020-04-02T13:39:28.6293639Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-04-02T13:39:28.6353353Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/70566/merge to s
2020-04-02T13:39:28.6431404Z Cleaning up task key
2020-04-02T13:39:28.6432584Z Start cleaning up orphan processes.
2020-04-02T13:39:28.6594696Z Terminate orphan process: pid (3717) (python)
2020-04-02T13:39:28.6823477Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@jumbatm jumbatm force-pushed the exceeding-bitshifts-constprop branch from 4e7b6b6 to 69d0267 Compare April 2, 2020 13:49
@jumbatm
Copy link
Contributor Author

jumbatm commented Apr 3, 2020

This is good for a perf run if there's no further comments. Can someone run rust-timer for me? Thanks!

@oli-obk
Copy link
Contributor

oli-obk commented Apr 3, 2020

@bors try

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 14, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 14, 2020
@Dylan-DPC
Rollup merge of rust-lang#70566 - jumbatm:exceeding-bitshifts-constpr…
bf06312 
…op, r=RalfJung

Don't bail out before linting in generic contexts.

Fixes rust-lang#69021.

cc rust-lang#70017

r? @RalfJung
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 14, 2020
Closed
@RalfJung
Copy link
Member

RalfJung commented Apr 14, 2020 •
edited
Loading

This failed the rollup in #71143 (comment). @bors r-

@jumbatm could you please rebase and re-bless? rustc output changed a bit so the reference files need updating.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 14, 2020
@jumbatm
Amend exceeding-bitshifts test case for rust-lang#69021.
3e6609e 
- Change to warnings so that all lints are emitted
- Expect build-pass
- Change placeholder FIXME to WARN.
@jumbatm
Move early needs_subst bailout to _after_ linting.
99492e4 
This ensures we get still get lints for generic contexts.
@jumbatm
Update stderrs after rebase.
ed73023
@jumbatm jumbatm force-pushed the exceeding-bitshifts-constprop branch from a017a5b to ed73023 Compare April 14, 2020 23:37
@jumbatm
Copy link
Contributor Author

jumbatm commented Apr 16, 2020

This is good to go again.

@Dylan-DPC-zz
Copy link

@bors r=RalfJung

@bors
Copy link
Contributor

bors commented Apr 16, 2020

📌 Commit ed73023 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 16, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 16, 2020
@Dylan-DPC
Rollup merge of rust-lang#70566 - jumbatm:exceeding-bitshifts-constpr…
c540bcc 
…op, r=RalfJung

Don't bail out before linting in generic contexts.

Fixes rust-lang#69021.

cc rust-lang#70017

r? @RalfJung
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 16, 2020
Closed
@RalfJung
Copy link
Member

@jumbatm thanks! Please always leave a message after a force-push as GitHub only unreliably sends email notifications for them.

@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Apr 16, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 16, 2020
@bors
Auto merge of rust-lang#71201 - Dylan-DPC:rollup-23202uf, r=Dylan-DPC
7f3df57 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#70566 (Don't bail out before linting in generic contexts.)
 - rust-lang#71141 (Provide better compiler output when using `?` on `Option` in fn returning `Result` and vice-versa)
 - rust-lang#71149 (remove an impossible branch from check_consts)
 - rust-lang#71179 (fix more clippy warnings)
 - rust-lang#71191 (Clean up E0520 explanation)

Failed merges:

r? @ghost
@bors bors merged commit 33500a2 into rust-lang:master Apr 16, 2020
@jonas-schievink jonas-schievink mentioned this pull request Apr 20, 2020
Closed
@jumbatm jumbatm mentioned this pull request Apr 21, 2020
Closed
@RalfJung RalfJung mentioned this pull request Apr 22, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 25, 2020
@bors
Auto merge of rust-lang#71441 - RalfJung:beta-const-validation-fix, r…
b1162ed 
…=Mark-Simulacrum

[beta] fix failing const validation

This is the **beta branch fix** for rust-lang#71353, by reverting rust-lang#70566.

r? @oli-obk
Not sure if there is any extra process for the beta part. This is not a backport; we intend to "properly" fix this on master but for beta a revert is faster and less risky.
@RalfJung RalfJung mentioned this pull request Apr 25, 2020
Closed
jumbatm added a commit to jumbatm/rust that referenced this pull request May 1, 2020
@jumbatm
Partially unrevert rust-lang#70566.
2887d79 
This partially reverts commit 4b5b6cb,
reversing some changes made to 62b3624.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

@RalfJung RalfJung RalfJung left review comments

@oli-obk oli-obk oli-obk approved these changes

Assignees

@RalfJung RalfJung

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"exceeding_bitshifts" lint does not work in associated consts
9 participants
@jumbatm @Centril @rust-highfive @oli-obk @bors @RalfJung @rust-timer @Dylan-DPC-zz @joelpalmer