Make all uses of ty::Error delay a span bug #70551

mark-i-m · 2020-03-30T02:37:38Z

A second attempt at #70245

resolves #70866

mark-i-m · 2020-04-07T01:57:13Z

Blocked on resolution of #70866

@rustbot modify labels: +S-blocked

@eddyb

De-abuse TyKind::Error in pattern type checking r? @eddyb cc rust-lang#70866 In particular, I would appreciate extra scrutiny over the soundness of these changes. Also, this will go a bit slowly because I'm going to use my other PR (rust-lang#70551) to check if I missed anything.

@eddyb

De-abuse TyKind::Error in pattern type checking r? @eddyb cc rust-lang#70866 In particular, I would appreciate extra scrutiny over the soundness of these changes. Also, this will go a bit slowly because I'm going to use my other PR (rust-lang#70551) to check if I missed anything.

mark-i-m · 2020-04-12T20:08:14Z

Still blocked on resolution of #70866

varkor · 2020-06-15T23:18:11Z

r=me after rebasing.

mark-i-m · 2020-06-15T23:21:32Z

For some reason I'm having a bit of trouble with this rebase... going to squash some commits and try again...

mark-i-m · 2020-06-15T23:28:36Z

Ok, this should be ready I think. I squashed 4 of the original commits together into
268decb

mark-i-m · 2020-06-16T03:31:49Z

Cool! CI is passing :)

src/librustc_middle/ty/sty.rs

Co-authored-by: lzutao <[email protected]>

varkor · 2020-06-17T15:59:25Z

@bors r+

bors · 2020-06-17T15:59:27Z

📌 Commit cfdbbb5 has been approved by varkor

@eddyb

Make all uses of ty::Error delay a span bug r? @eddyb A second attempt at rust-lang#70245 resolves rust-lang#70866

@eddyb

Make all uses of ty::Error delay a span bug r? @eddyb A second attempt at rust-lang#70245 resolves rust-lang#70866

@ghost

…arth Rollup of 17 pull requests Successful merges: - rust-lang#70551 (Make all uses of ty::Error delay a span bug) - rust-lang#71338 (Expand "recursive opaque type" diagnostic) - rust-lang#71976 (Improve diagnostics for `let x += 1`) - rust-lang#72279 (add raw_ref macros) - rust-lang#72628 (Add tests for 'impl Default for [T; N]') - rust-lang#72804 (Further tweak lifetime errors involving `dyn Trait` and `impl Trait` in return position) - rust-lang#72814 (remove visit_terminator_kind from MIR visitor) - rust-lang#72836 (Complete the std::time documentation to warn about the inconsistencies between OS) - rust-lang#72968 (Only highlight doc search results via mouseover if mouse has moved) - rust-lang#73034 (Export `#[inline]` fns with extern indicators) - rust-lang#73315 (Clean up some weird command strings) - rust-lang#73320 (Make new type param suggestion more targetted) - rust-lang#73361 (Tweak "non-primitive cast" error) - rust-lang#73425 (Mention functions pointers in the documentation) - rust-lang#73428 (Fix typo in librustc_ast docs) - rust-lang#73447 (Improve document for `Result::as_deref(_mut)` methods) - rust-lang#73476 (Added tooltip for should_panic code examples) Failed merges: r? @ghost

@eddyb

Add `TyCtxtAt::{ty_error, ty_error_with_message}` ~~Only e2d957d was added, the rest comes from rust-lang#70551.~~ I was unsure where to put the implementation for those methods, please tell me if there is a better place for it. Closes rust-lang#72619, ~~blocked on rust-lang#70551~~. r? @eddyb cc @mark-i-m, maybe this should be part of rust-lang#70551? If so feel free to cherry-pick or ask me to file a PR against your fork.

rust-highfive assigned eddyb Mar 30, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2020