-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure HAS_FREE_LOCAL_NAMES is set for ReFree #69956
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewjasper
added
the
beta-nominated
Nominated for backporting to the compiler in the beta channel.
label
Mar 12, 2020
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Mar 12, 2020
Reassigning to the first suggested reviewer. |
nikomatsakis
approved these changes
Mar 16, 2020
Seems reasonable @bors r+ |
📌 Commit f4eb6ed has been approved by |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 16, 2020
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 17, 2020
…ikomatsakis Ensure HAS_FREE_LOCAL_NAMES is set for ReFree This fixes a bug introduced by rust-lang#69469. I don't have any ideas on how to reate a regression test for this.
Centril
added a commit
to Centril/rust
that referenced
this pull request
Mar 17, 2020
…ikomatsakis Ensure HAS_FREE_LOCAL_NAMES is set for ReFree This fixes a bug introduced by rust-lang#69469. I don't have any ideas on how to reate a regression test for this.
bors
added a commit
that referenced
this pull request
Mar 17, 2020
Rollup of 7 pull requests Successful merges: - #68746 (Make macro metavars respect (non-)hygiene) - #69688 (Move tidy check to mingw-check) - #69735 (bootstrap: Use hash to determine if sanitizers needs to be rebuilt) - #69922 (implement zeroed and uninitialized with MaybeUninit) - #69956 (Ensure HAS_FREE_LOCAL_NAMES is set for ReFree) - #70061 (Cosmetic fixes in documentation) - #70064 (Update books) Failed merges: r? @ghost
Centril
added
the
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
label
Mar 25, 2020
Discussed in T-compiler meeting. Somewhat reluctantly accepted for beta-backport. |
pnkfelix
added
the
beta-accepted
Accepted for backporting to the compiler in the beta channel.
label
Apr 1, 2020
Mark-Simulacrum
removed
the
beta-nominated
Nominated for backporting to the compiler in the beta channel.
label
Apr 3, 2020
Merged
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2020
…ulacrum [beta] backport 4 PRs This backports the following PRs: * parse_and_disallow_postfix_after_cast: account for `ExprKind::Err`. rust-lang#70556 * Account for bad placeholder types in where clauses rust-lang#70294 * Fix "since" field for `Once::is_complete`'s `#[stable]` attribute rust-lang#70018 * Ensure HAS_FREE_LOCAL_NAMES is set for ReFree rust-lang#69956 All commits cherry picked cleanly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
beta-accepted
Accepted for backporting to the compiler in the beta channel.
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug introduced by #69469.
I don't have any ideas on how to reate a regression test for this.