Dogfood half_open_range_patterns

[Centril]

cc #67264

r? @oli-obk

[oli-obk]

@bors r+ rollup

[bors]

📌 Commit b49f4e8 has been approved by oli-obk

[rust-highfive]

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-02-05T10:23:07.1462564Z ========================== Starting Command Output ===========================
2020-02-05T10:23:07.1465137Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/d7b97bd8-8726-49f8-927b-56b8107ec0f2.sh
2020-02-05T10:23:07.1465310Z 
2020-02-05T10:23:07.1506916Z ##[section]Finishing: Disable git automatic line ending conversion
2020-02-05T10:23:07.1515299Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/68859/merge to s
2020-02-05T10:23:07.1517107Z Task         : Get sources
2020-02-05T10:23:07.1517150Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-02-05T10:23:07.1517245Z Version      : 1.0.0
2020-02-05T10:23:07.1517289Z Author       : Microsoft
---
2020-02-05T10:23:08.1484234Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-02-05T10:23:08.1495959Z ##[command]git config gc.auto 0
2020-02-05T10:23:08.1498628Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-02-05T10:23:08.1500789Z ##[command]git config --get-all http.proxy
2020-02-05T10:23:08.1508104Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/68859/merge:refs/remotes/pull/68859/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[Centril]

Bummer. Looks like rustfmt isn't supporting it yet, so I'll need to use a ::skip for now.

@bors r-

[oli-obk]

so I'll need to use a ::skip for now

I strongly prefer not to do that. 0 works just fine right now. Let's fix rustfmt instead.

[Centril]

Works for me; cc @topecongiro.

[Mark-Simulacrum]

To be honest, I find these much harder to read. Maybe I'm just not used to it yet, but it's entirely non obvious to me that we're omitting specifically a zero. It also seems largely useless as I can't really see a case where this is better (i.e. where the zero was in the way before).

I'm not sure what to do with this information. This feature was implemented without an RFC, as far as I can tell.

I think the fact that these ranges don't have iterator impls is part of it...

[Centril]

I'll close this for now then and you can consider what to do with the information. Personally, I think the feature adds a degree of consistency to patterns & expressions (and X.. is generally useful but ..X less so).