Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only assign dep node indices in non-incremental mode if self profiling is active #68687

Closed
wants to merge 1 commit into from
Closed

Only assign dep node indices in non-incremental mode if self profiling is active #68687

wants to merge 1 commit into from

Conversation

Zoxc
Copy link
Contributor

@Zoxc Zoxc commented Jan 31, 2020

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 31, 2020
@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 31, 2020

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion

@bors
Copy link
Contributor

bors commented Jan 31, 2020

⌛ Trying commit d7ea15a with merge afc0bb1be51b24d06a82de45c5418154f212a34e...

@rust-highfive
Copy link
Collaborator

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Jan 31, 2020

💔 Test failed - checks-azure

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 31, 2020
@Zoxc
Copy link
Contributor Author

Zoxc commented Jan 31, 2020

@bors try

@bors
Copy link
Contributor

bors commented Jan 31, 2020

⌛ Trying commit d7ea15a with merge 3fd6f9b...

bors added a commit that referenced this pull request Jan 31, 2020
@bors
Auto merge of #68687 - Zoxc:prof-query-keys, r=<try>
3fd6f9b 
Only assign dep node indices in non-incremental mode if self profiling is active

r? @michaelwoerister
@bors
Copy link
Contributor

bors commented Jan 31, 2020

☀️ Try build successful - checks-azure
Build commit: 3fd6f9b (3fd6f9b34a1a08a43a7bdb34e69179ebdf398bef)

@rust-timer
Copy link
Collaborator

Queued 3fd6f9b with parent 34700c1, future comparison URL.

@michaelwoerister
Copy link
Member

I'm not convinced that this is worth the additional complexity. An atomic fetch_add should be rather cheap.

@Dylan-DPC-zz
Copy link

Closing this based on #68687 (comment) and inactivity. Thanks

@Zoxc Zoxc reopened this Mar 12, 2020
@Zoxc
Copy link
Contributor Author

Zoxc commented Mar 12, 2020

fetch_add isn't too expensive (~17 cycles on Zen) if they are uncontended and spaced out (so the cycle cost can be hidden). In this case the fetch_add potentially from on all CPU cores to a single location and the code is reasonably hot. I'd rather just avoid any potential issues from this with a branch.

@joelpalmer joelpalmer added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 30, 2020
@joelpalmer joelpalmer added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 9, 2020
@nikomatsakis
Copy link
Contributor

Closing this pull request as Zoxc is stepping back from compiler development; see rust-lang/team#316.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Zoxc @rust-timer @bors @rust-highfive @michaelwoerister @Dylan-DPC-zz @nikomatsakis @joelpalmer