Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dyn and true keyword docs #67695

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Added dyn and true keyword docs #67695

merged 1 commit into from
Feb 12, 2020

Conversation

gilescope
Copy link
Contributor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 29, 2019
Dylan-DPC-zz
Dylan-DPC-zz suggested changes Dec 29, 2019
View reviewed changes
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 29, 2019
Centril
Centril reviewed Dec 29, 2019
View reviewed changes
src/libstd/keyword_docs.rs Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
@gilescope
Copy link
Contributor Author

@Centril is v2 any better? I tried to frame it around dyn Trait versus impl Trait.

1tgr
1tgr reviewed Jan 2, 2020
View reviewed changes
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
1tgr
1tgr reviewed Jan 2, 2020
View reviewed changes
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
Centril
Centril reviewed Jan 2, 2020
View reviewed changes
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
@JohnCSimon
Copy link
Member

Ping from triage:
@gilescope please address the change requests. Thanks.

@JohnTitor
Copy link
Member

Ping from triage: @gilescope could you address the change requests?

@rust-highfive

This comment has been minimized.

Sign in to view
@gilescope
Copy link
Contributor Author

(Sorry for the delay! NixOs and I have been getting to know one another. )
@Centril can you have a look at the impl TraitA for dyn TraitB bit I've added. I want to ensure we get this bit right as it's not documented anywhere else - have I overstepped the mark in saying that object safety does not apply on TraitA? I believe you can have generic methods on TraitA.

@rust-highfive

This comment has been minimized.

Sign in to view
Centril
Centril reviewed Feb 10, 2020
View reviewed changes
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
Centril
Centril reviewed Feb 10, 2020
View reviewed changes
src/libstd/keyword_docs.rs Outdated Show resolved Hide resolved
@Centril @1tgr
@petertodd @Dylan-DPC
Keyword docs
8e26ad0 
Co-Authored-By: Mazdak Farrokhzad <[email protected]>
Co-Authored-By: Tim Robinson <[email protected]>
Co-Authored-By: Peter Todd <[email protected]>
Co-Authored-By: Dylan DPC <[email protected]>
@gilescope
Copy link
Contributor Author

@Centril have squashed commits. Are we good to go?

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 11, 2020

📌 Commit 8e26ad0 has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 11, 2020
@Dylan-DPC-zz
Copy link

@bors r=centril

(Sorry xD)

@bors
Copy link
Contributor

bors commented Feb 11, 2020

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Feb 11, 2020

📌 Commit 8e26ad0 has been approved by centril

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 12, 2020
@Dylan-DPC
Rollup merge of rust-lang#67695 - gilescope:truth, r=centril
c7addfb 
Added dyn and true keyword docs

r? @Centril
@Dylan-DPC-zz Dylan-DPC-zz mentioned this pull request Feb 12, 2020
Closed
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Feb 12, 2020
@JohnTitor
Rollup merge of rust-lang#67695 - gilescope:truth, r=centril
b6a9aa9 
Added dyn and true keyword docs

r? @Centril
@JohnTitor JohnTitor mentioned this pull request Feb 12, 2020
Merged
bors added a commit that referenced this pull request Feb 12, 2020
@bors
Auto merge of #69088 - JohnTitor:rollup-x7bk7h7, r=JohnTitor
cd5441f 
Rollup of 11 pull requests

Successful merges:

 - #67695 (Added dyn and true keyword docs)
 - #68487 ([experiment] Support linking from a .rlink file)
 - #68554 (Split lang_items to crates `rustc_hir` and `rustc_passes`.)
 - #68937 (Test failure of unchecked arithmetic intrinsics in const eval)
 - #68947 (Python script PEP8 style guide space formatting and minor Python source cleanup)
 - #68999 (remove dependency on itertools)
 - #69026 (Remove common usage pattern from `AllocRef`)
 - #69027 (Add missing `_zeroed` varants to `AllocRef`)
 - #69058 (Preparation for allocator aware `Box`)
 - #69070 (Add self to .mailmap)
 - #69077 (Fix outdated doc comment.)

Failed merges:

r? @ghost
@bors bors merged commit 8e26ad0 into rust-lang:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

@1tgr 1tgr 1tgr left review comments

@petertodd petertodd petertodd left review comments

@Dylan-DPC-zz Dylan-DPC-zz Dylan-DPC-zz requested changes

Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@gilescope @JohnCSimon @JohnTitor @rust-highfive @Dylan-DPC-zz @bors @petertodd @1tgr @Centril