Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set callbacks globally #67614

Merged
merged 2 commits into from
Dec 29, 2019
Merged

Set callbacks globally #67614

merged 2 commits into from
Dec 29, 2019

Commits on Dec 25, 2019

  1. Store callbacks in global statics 

    The callbacks have precisely two states: the default, and the one
present throughout almost all of the rustc run (the filled in value
which has access to TyCtxt).

We used to store this as a thread local, and reset it on each thread to
the non-default value. But this is somewhat wasteful, since there is no
reason to set it globally -- while the callbacks themselves access TLS,
they do not do so in a manner that fails in when we do not have TLS to
work with.
    @Mark-Simulacrum
    Mark-Simulacrum committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    b98633b View commit details
    Browse the repository at this point in the history

  2. Fix skipped setting of syntax::GLOBALS

    @Mark-Simulacrum
    Mark-Simulacrum committed Dec 25, 2019
    Configuration menu
    Copy the full SHA
    4dcc627 View commit details
    Browse the repository at this point in the history