Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add long error code explanation message for E0627 #67551

Merged
merged 2 commits into from
Dec 24, 2019
Merged

Conversation

ldm0
Copy link
Contributor

@ldm0 ldm0 commented Dec 23, 2019

Part of #61137.

r? @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @GuillaumeGomez (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 23, 2019
src/librustc_error_codes/error_codes/E0627.md Outdated Show resolved Hide resolved
src/librustc_error_codes/error_codes/E0627.md Outdated Show resolved Hide resolved
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-12-23T05:31:53.1397394Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-23T05:31:53.1604277Z ##[command]git config gc.auto 0
2019-12-23T05:31:53.1638585Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-23T05:31:53.1683186Z ##[command]git config --get-all http.proxy
2019-12-23T05:31:53.1825764Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/67551/merge:refs/remotes/pull/67551/merge
---
2019-12-23T05:37:56.6443087Z    Compiling serde_json v1.0.40
2019-12-23T05:37:58.2203260Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-12-23T05:38:08.7356510Z     Finished release [optimized] target(s) in 1m 23s
2019-12-23T05:38:08.7469420Z tidy check
2019-12-23T05:38:09.0224375Z tidy error: /checkout/src/librustc_error_codes/error_codes/E0627.md:1: line longer than 80 chars
2019-12-23T05:38:11.4558200Z some tidy checks failed
2019-12-23T05:38:11.4561966Z Found 485 error codes
2019-12-23T05:38:11.4562631Z Found 0 error codes with no tests
2019-12-23T05:38:11.4562814Z Done!
2019-12-23T05:38:11.4562814Z Done!
2019-12-23T05:38:11.4563049Z 
2019-12-23T05:38:11.4563246Z 
2019-12-23T05:38:11.4564189Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-12-23T05:38:11.4564699Z 
2019-12-23T05:38:11.4564848Z 
2019-12-23T05:38:11.4568086Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-12-23T05:38:11.4568374Z Build completed unsuccessfully in 0:01:27
2019-12-23T05:38:11.4568374Z Build completed unsuccessfully in 0:01:27
2019-12-23T05:38:11.4616624Z == clock drift check ==
2019-12-23T05:38:11.4625502Z   local time: Mon Dec 23 05:38:11 UTC 2019
2019-12-23T05:38:11.7428937Z   network time: Mon, 23 Dec 2019 05:38:11 GMT
2019-12-23T05:38:11.7432161Z == end clock drift check ==
2019-12-23T05:38:13.1569981Z 
2019-12-23T05:38:13.1664161Z ##[error]Bash exited with code '1'.
2019-12-23T05:38:13.1718099Z ##[section]Starting: Checkout
2019-12-23T05:38:13.1720174Z ==============================================================================
2019-12-23T05:38:13.1720249Z Task         : Get sources
2019-12-23T05:38:13.1720299Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@Dylan-DPC-zz
Copy link

r? @Dylan-DPC

@Dylan-DPC-zz
Copy link

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 23, 2019

📌 Commit 587d03b has been approved by Dylan-DPC

@bors
Copy link
Contributor

bors commented Dec 23, 2019

🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2019
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Dec 24, 2019
Add long error code explanation message for E0627

Part of rust-lang#61137.

r? @GuillaumeGomez
Centril added a commit to Centril/rust that referenced this pull request Dec 24, 2019
Add long error code explanation message for E0627

Part of rust-lang#61137.

r? @GuillaumeGomez
bors added a commit that referenced this pull request Dec 24, 2019
Rollup of 7 pull requests

Successful merges:

 - #67337 (Ensure that evaluating or validating a constant never reads from a static)
 - #67543 (Add regression tests for fixed ICEs)
 - #67547 (Cleanup err codes)
 - #67551 (Add long error code explanation message for E0627)
 - #67561 (remove `description` from `Error` impls in docs)
 - #67569 (Clean up unsafety in char::encode_utf8)
 - #67572 (Use the chocolatey CDN directly to avoid the flaky API)

Failed merges:

r? @ghost
@bors bors merged commit 587d03b into rust-lang:master Dec 24, 2019
@ldm0 ldm0 deleted the E0627 branch December 29, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants