Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syntax: Unify macro and attribute arguments in AST #66935

Merged
merged 6 commits into from
Dec 3, 2019
Merged

syntax: Unify macro and attribute arguments in AST #66935

merged 6 commits into from
Dec 3, 2019

Commits on Dec 2, 2019

  1. syntax: Introduce a struct MacArgs for macro arguments

    @petrochenkov
    petrochenkov committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    a81804b View commit details
    Browse the repository at this point in the history

  2. syntax: Remove redundant span from ast::Mac 

    Also remove a couple of redundant `visit_mac` asserts
    @petrochenkov
    petrochenkov committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    0fac567 View commit details
    Browse the repository at this point in the history

  3. syntax: Use ast::MacArgs for attributes

    @petrochenkov
    petrochenkov committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    1a496f3 View commit details
    Browse the repository at this point in the history

  4. syntax: Use ast::MacArgs for macro definitions

    @petrochenkov
    petrochenkov committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    5378955 View commit details
    Browse the repository at this point in the history

  5. syntax: Optimize conversion AttrItem -> MetaItem by avoiding `out… 

    …er_tokens`.
    @petrochenkov
    petrochenkov committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    cf71538 View commit details
    Browse the repository at this point in the history

  6. Address review comments

    @petrochenkov
    petrochenkov committed Dec 2, 2019
    Configuration menu
    Copy the full SHA
    498737c View commit details
    Browse the repository at this point in the history