implement LowerExp and UpperExp for integers #66721

maxbla · 2019-11-24T22:40:36Z

Addresses #39479

This implementation is heavily based on the preexisting macro_rules! impl_Display in the same file. I don't like the liberal use of unsafe in that macro and would like to modify it so unsafe is only present where necessary. What is Rust's policy on doing such modifications?

Also, I couldn't figure out where to put tests, can I have some help with that?

rust-highfive · 2019-11-24T22:40:39Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @kennytm (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

rust-highfive · 2019-11-24T22:57:09Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-24T22:44:42.5388500Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-11-24T22:44:42.5577716Z ##[command]git config gc.auto 0
2019-11-24T22:44:42.5657486Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-11-24T22:44:42.5703578Z ##[command]git config --get-all http.proxy
2019-11-24T22:44:42.5854532Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66721/merge:refs/remotes/pull/66721/merge
---
2019-11-24T22:49:55.8088732Z   = note: `#[warn(unused_imports)]` on by default
2019-11-24T22:49:55.8092986Z 
2019-11-24T22:50:05.6018403Z     Finished release [optimized] target(s) in 1m 18s
2019-11-24T22:50:05.6100531Z tidy check
2019-11-24T22:50:06.4316935Z tidy error: /checkout/src/libcore/fmt/num.rs:264: line longer than 100 chars
2019-11-24T22:50:06.4317701Z tidy error: /checkout/src/libcore/fmt/num.rs:314: line longer than 100 chars
2019-11-24T22:50:07.8744686Z some tidy checks failed
2019-11-24T22:50:07.8744792Z Found 485 error codes
2019-11-24T22:50:07.8745138Z Found 0 error codes with no tests
2019-11-24T22:50:07.8745187Z Done!
2019-11-24T22:50:07.8745187Z Done!
2019-11-24T22:50:07.8748692Z 
2019-11-24T22:50:07.8749013Z 
2019-11-24T22:50:07.8749955Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-11-24T22:50:07.8750466Z 
2019-11-24T22:50:07.8750619Z 
2019-11-24T22:50:07.8752861Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-11-24T22:50:07.8753115Z Build completed unsuccessfully in 0:01:21
2019-11-24T22:50:07.8753115Z Build completed unsuccessfully in 0:01:21
2019-11-24T22:50:07.8790615Z == clock drift check ==
2019-11-24T22:50:07.8797574Z   local time: Sun Nov 24 22:50:07 UTC 2019
2019-11-24T22:50:08.1685606Z   network time: Sun, 24 Nov 2019 22:50:08 GMT
2019-11-24T22:50:08.1689515Z == end clock drift check ==
2019-11-24T22:50:09.5912095Z 
2019-11-24T22:50:09.6003494Z ##[error]Bash exited with code '1'.
2019-11-24T22:50:09.6025858Z ##[section]Starting: Checkout
2019-11-24T22:50:09.6027324Z ==============================================================================
2019-11-24T22:50:09.6027388Z Task         : Get sources
2019-11-24T22:50:09.6027427Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Alexendoo · 2019-12-04T18:13:27Z

Ping from triage, any updates? @kennytm

kennytm · 2019-12-04T18:28:45Z

@Alexendoo This is a Draft PR, it is waiting for author to click "Ready for review".

maxbla · 2019-12-05T01:00:46Z

Sorry, this is my first PR. I was waiting on an answer to the questions higher in the thread, as I knew it would not pass review without some changes. I have now marked it ready for review, because review will probably involve answers to the question of where to put tests.

Dylan-DPC-zz · 2019-12-07T15:30:30Z

@kennytm if you can answer the above question(s) we can proceed with this PR :) thanks

kennytm · 2019-12-07T15:57:38Z

@maxbla Unit tests for libcore should be placed in src/libcore/tests/. For this PR, try src/libcore/tests/fmt/num.rs.

src/libcore/fmt/num.rs

rust-highfive · 2019-12-10T20:49:09Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-10T20:32:37.0351781Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-10T20:32:37.0546542Z ##[command]git config gc.auto 0
2019-12-10T20:32:37.7335452Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-10T20:32:37.7344626Z ##[command]git config --get-all http.proxy
2019-12-10T20:32:37.7350091Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66721/merge:refs/remotes/pull/66721/merge
---
2019-12-10T20:38:52.8853900Z Found 0 error codes with no tests
2019-12-10T20:38:52.8854353Z Done!
2019-12-10T20:38:52.8854500Z 
2019-12-10T20:38:52.8854827Z 
2019-12-10T20:38:52.8856405Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-12-10T20:38:52.8856841Z 
2019-12-10T20:38:52.8856964Z 
2019-12-10T20:38:52.8857116Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-12-10T20:38:52.8857292Z Build completed unsuccessfully in 0:01:32
2019-12-10T20:38:52.8857292Z Build completed unsuccessfully in 0:01:32
2019-12-10T20:38:52.8857436Z some tidy checks failed
2019-12-10T20:38:52.8890142Z == clock drift check ==
2019-12-10T20:38:52.8912970Z   local time: Tue Dec 10 20:38:52 UTC 2019
2019-12-10T20:38:53.1860830Z   network time: Tue, 10 Dec 2019 20:38:53 GMT
2019-12-10T20:38:53.1866832Z == end clock drift check ==
2019-12-10T20:38:54.5206970Z 
2019-12-10T20:38:54.5314071Z ##[error]Bash exited with code '1'.
2019-12-10T20:38:54.5342081Z ##[section]Starting: Checkout
2019-12-10T20:38:54.5343602Z ==============================================================================
2019-12-10T20:38:54.5343650Z Task         : Get sources
2019-12-10T20:38:54.5343693Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/libcore/tests/fmt/num.rs

rust-highfive · 2019-12-25T08:38:24Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-12-25T08:21:03.3493590Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-12-25T08:21:03.3717879Z ##[command]git config gc.auto 0
2019-12-25T08:21:03.3808891Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-12-25T08:21:03.3873511Z ##[command]git config --get-all http.proxy
2019-12-25T08:21:03.4038220Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/66721/merge:refs/remotes/pull/66721/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

maxbla · 2019-12-26T10:02:44Z

81305e2 adds precision support using flt2dec::Part and fmt::pad_formatted_parts().

It feels a tad weird to use a module called flt2dec for integer formatting. I think core::num::flt2dec::Part might fit better in core::fmt and core::num::flt2dec::Formatted definitely would fit better there.

kennytm · 2019-12-26T10:14:30Z

r? @dtolnay

maxbla · 2019-12-27T01:08:57Z

core::fmt::{pad_formatted_parts. write_formatted_parts} both call unsafe fn str::from_utf8_unchecked() on their arguments, but are not marked as unsafe themselves. Is it possible this was done for a reason, or can I change that?

KodrAus · 2020-01-15T23:32:29Z

r? @KodrAus

KodrAus · 2020-01-15T23:38:11Z

It feels a tad weird to use a module called flt2dec for integer formatting. I think core::num::flt2dec::Part might fit better in core::fmt and core::num::flt2dec::Formatted definitely would fit better there.

I think the original implementation came from an external library so it all ended up living together. I wouldn't be against refactoring out commonly useful pieces from it.

KodrAus

Thanks for the PR @maxbla!

I've just left a few comments to start.

src/libcore/fmt/num.rs

KodrAus · 2020-01-15T23:27:51Z

src/libcore/fmt/num.rs

+
+macro_rules! impl_Exp {
+    ($($t:ident),* as $u:ident via $conv_fn:ident named $name:ident) => {
+        fn $name(


Before digging too deeply into the code itself can you offer any background on this implementation? Whether it's based on any common approaches used elsewhere?

It is heavily based on impl_Display! from the same file. It also makes use of some stuff from float's implementation (for precision).

src/libcore/fmt/num.rs

KodrAus

Alrighty, this is looking good to me! Thanks for working on this @maxbla!

Would you like to squash your commits down and I'll merge this one in?

maxbla · 2020-02-10T01:11:17Z

@KodrAus Thanks for the review. I'm excited to get my first contribution merged!
Is now a good time to move core::num::flt2dec::Part and core::num::flt2dec::Formatted to core::fmt or did I miss the window on that?

maxbla · 2020-02-15T02:10:27Z

I think this PR is now ready to merge.

Dylan-DPC-zz · 2020-02-15T02:13:53Z

Not yet xD

We don't do merges here so it will be nice if you could revert the merge and rebase instead.

maxbla · 2020-02-15T02:47:47Z

Alright I think I did it right this time

KodrAus · 2020-02-15T07:37:51Z

Thanks for your patience @maxbla! This looks good to me.

@bors r+

bors · 2020-02-15T07:37:52Z

📌 Commit a8fe47d has been approved by KodrAus

implement LowerExp and UpperExp for integers Addresses rust-lang#39479 This implementation is heavily based on the preexisting `macro_rules! impl_Display` in the same file. I don't like the liberal use of unsafe in that macro and would like to modify it so `unsafe` is only present where necessary. What is Rust's policy on doing such modifications? Also, I couldn't figure out where to put tests, can I have some help with that?

@ghost

Rollup of 6 pull requests Successful merges: - #64069 (Added From<Vec<NonZeroU8>> for CString) - #66721 (implement LowerExp and UpperExp for integers) - #69106 (Fix std::fs::copy on WASI target) - #69154 (Avoid calling `fn_sig` on closures) - #69166 (Check `has_typeck_tables` before calling `typeck_tables_of`) - #69180 (Suggest a comma if a struct initializer field fails to parse) Failed merges: r? @ghost

rust-highfive assigned kennytm Nov 24, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 24, 2019

kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2019

kennytm added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Dec 4, 2019

maxbla marked this pull request as ready for review December 5, 2019 00:57

kennytm reviewed Dec 7, 2019

View reviewed changes

src/libcore/fmt/num.rs Outdated Show resolved Hide resolved

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 11, 2019

kennytm reviewed Dec 12, 2019

View reviewed changes

src/libcore/tests/fmt/num.rs Show resolved Hide resolved

rust-highfive assigned dtolnay and unassigned kennytm Dec 26, 2019

rust-highfive assigned KodrAus and unassigned dtolnay Jan 15, 2020

KodrAus reviewed Jan 15, 2020

View reviewed changes

KodrAus reviewed Jan 28, 2020

View reviewed changes

src/libcore/fmt/num.rs Outdated Show resolved Hide resolved

src/libcore/fmt/num.rs Outdated Show resolved Hide resolved

KodrAus approved these changes Feb 9, 2020

View reviewed changes

implement LowerExp and UpperExp for integers

a8fe47d

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 15, 2020

Dylan-DPC-zz mentioned this pull request Feb 15, 2020

Rollup of 6 pull requests #69182

Merged

bors merged commit a8fe47d into rust-lang:master Feb 15, 2020

cuviper mentioned this pull request Feb 25, 2020

add more formatting traits rust-num/num-rational#56

Merged

4 tasks

maxbla mentioned this pull request Mar 12, 2020

Implement LowerExp and UpperExp for integers #39479

Closed

steffahn mentioned this pull request Sep 11, 2023

scientific notation incorrect decimal places #115737

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

implement LowerExp and UpperExp for integers #66721

implement LowerExp and UpperExp for integers #66721

maxbla commented Nov 24, 2019

rust-highfive commented Nov 24, 2019

rust-highfive commented Nov 24, 2019

Alexendoo commented Dec 4, 2019

kennytm commented Dec 4, 2019

maxbla commented Dec 5, 2019

Dylan-DPC-zz commented Dec 7, 2019

kennytm commented Dec 7, 2019

rust-highfive commented Dec 10, 2019

rust-highfive commented Dec 25, 2019

maxbla commented Dec 26, 2019

kennytm commented Dec 26, 2019

maxbla commented Dec 27, 2019

KodrAus commented Jan 15, 2020

KodrAus commented Jan 15, 2020

KodrAus left a comment

KodrAus Jan 15, 2020

maxbla Jan 16, 2020

KodrAus left a comment

maxbla commented Feb 10, 2020

maxbla commented Feb 15, 2020

Dylan-DPC-zz commented Feb 15, 2020

maxbla commented Feb 15, 2020

KodrAus commented Feb 15, 2020

bors commented Feb 15, 2020

implement LowerExp and UpperExp for integers #66721

implement LowerExp and UpperExp for integers #66721

Conversation

maxbla commented Nov 24, 2019

rust-highfive commented Nov 24, 2019

rust-highfive commented Nov 24, 2019

Alexendoo commented Dec 4, 2019

kennytm commented Dec 4, 2019

maxbla commented Dec 5, 2019

Dylan-DPC-zz commented Dec 7, 2019

kennytm commented Dec 7, 2019

rust-highfive commented Dec 10, 2019

rust-highfive commented Dec 25, 2019

maxbla commented Dec 26, 2019

kennytm commented Dec 26, 2019

maxbla commented Dec 27, 2019

KodrAus commented Jan 15, 2020

KodrAus commented Jan 15, 2020

KodrAus left a comment

Choose a reason for hiding this comment

KodrAus Jan 15, 2020

Choose a reason for hiding this comment

maxbla Jan 16, 2020

Choose a reason for hiding this comment

KodrAus left a comment

Choose a reason for hiding this comment

maxbla commented Feb 10, 2020

maxbla commented Feb 15, 2020

Dylan-DPC-zz commented Feb 15, 2020

maxbla commented Feb 15, 2020

KodrAus commented Feb 15, 2020

bors commented Feb 15, 2020