Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize @file command line arguments #66172

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Stabilize @file command line arguments #66172

merged 1 commit into from
Nov 9, 2019

Conversation

jsgf
Copy link
Contributor

@jsgf jsgf commented Nov 6, 2019

Issue #63576

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 6, 2019
@jonas-schievink jonas-schievink added the relnotes Marks issues that should be documented in the release notes of the next release. label Nov 6, 2019
@jonas-schievink jonas-schievink added this to the 1.40 milestone Nov 6, 2019
@Centril Centril added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Nov 6, 2019
@Centril Centril modified the milestones: 1.40, 1.41 Nov 7, 2019
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Nov 8, 2019 •
edited
Loading

@bors r+

I presume that this text is accurate?

If you specify @path on the command-line, then it will open path and read command line options > from it. These options are one per line; a blank line indicates an empty option. The file can use Unix > or Windows style line endings, and must be encoded as UTF-8.

@bors
Copy link
Contributor

bors commented Nov 8, 2019

📌 Commit 446a43d has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 8, 2019
@bors
Copy link
Contributor

bors commented Nov 8, 2019

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Nov 8, 2019

📌 Commit 446a43d has been approved by nikomatsakis

@jsgf
Copy link
Contributor Author

jsgf commented Nov 8, 2019

@nikomatsakis Yes, it is.

Centril added a commit to Centril/rust that referenced this pull request Nov 8, 2019
@Centril
Rollup merge of rust-lang#66172 - jsgf:stabilize-atfile, r=nikomatsakis
a9d4d2b 
Stabilize @file command line arguments

Issue rust-lang#63576
@Centril Centril mentioned this pull request Nov 8, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Nov 9, 2019
@Centril
Rollup merge of rust-lang#66172 - jsgf:stabilize-atfile, r=nikomatsakis
c02d883 
Stabilize @file command line arguments

Issue rust-lang#63576
@Centril Centril mentioned this pull request Nov 9, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Nov 9, 2019
@Centril
Rollup merge of rust-lang#66172 - jsgf:stabilize-atfile, r=nikomatsakis
648e8bf 
Stabilize @file command line arguments

Issue rust-lang#63576
@Centril Centril mentioned this pull request Nov 9, 2019
Merged
bors added a commit that referenced this pull request Nov 9, 2019
@bors
Auto merge of #66242 - Centril:rollup-h73ztr1, r=Centril
5a50275 
Rollup of 6 pull requests

Successful merges:

 - #65949 (Move promotion into its own pass)
 - #65994 (Point at where clauses where the associated item was restricted)
 - #66050 (Fix C aggregate-passing ABI on powerpc)
 - #66134 (Point at formatting descriptor string when it is invalid)
 - #66172 (Stabilize @file command line arguments)
 - #66226 (add link to unstable book for asm! macro)

Failed merges:

r? @ghost
@bors bors merged commit 446a43d into rust-lang:master Nov 9, 2019
@jsgf jsgf deleted the stabilize-atfile branch November 10, 2019 06:50
@MaulingMonkey MaulingMonkey mentioned this pull request Jan 2, 2020
Closed
@MaulingMonkey MaulingMonkey mentioned this pull request Jan 2, 2020
Closed
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Feb 17, 2020
@jperkin
rust: Update to 1.41.0.
a8c2c99 
Version 1.41.0 (2020-01-30)
===========================

Language
--------

- [You can now pass type parameters to foreign items when implementing
  traits.][65879] E.g. You can now write `impl<T> From<Foo> for Vec<T> {}`.
- [You can now arbitrarily nest receiver types in the `self` position.][64325] E.g. you can
  now write `fn foo(self: Box<Box<Self>>) {}`. Previously only `Self`, `&Self`,
  `&mut Self`, `Arc<Self>`, `Rc<Self>`, and `Box<Self>` were allowed.
- [You can now use any valid identifier in a `format_args` macro.][66847]
  Previously identifiers starting with an underscore were not allowed.
- [Visibility modifiers (e.g. `pub`) are now syntactically allowed on trait items and
  enum variants.][66183] These are still rejected semantically, but
  can be seen and parsed by procedural macros and conditional compilation.

Compiler
--------

- [Rustc will now warn if you have unused loop `'label`s.][66325]
- [Removed support for the `i686-unknown-dragonfly` target.][67255]
- [Added tier 3 support\* for the `riscv64gc-unknown-linux-gnu` target.][66661]
- [You can now pass an arguments file passing the `@path` syntax
  to rustc.][66172] Note that the format differs somewhat from what is
  found in other tooling; please see [the documentation][argfile-docs] for
  more information.
- [You can now provide `--extern` flag without a path, indicating that it is
  available from the search path or specified with an `-L` flag.][64882]

\* Refer to Rust's [platform support page][forge-platform-support] for more
information on Rust's tiered platform support.

[argfile-docs]: https://doc.rust-lang.org/nightly/rustc/command-line-arguments.html#path-load-command-line-flags-from-a-path

Libraries
---------

- [The `core::panic` module is now stable.][66771] It was already stable
  through `std`.
- [`NonZero*` numerics now implement `From<NonZero*>` if it's a smaller integer
  width.][66277] E.g. `NonZeroU16` now implements `From<NonZeroU8>`.
- [`MaybeUninit<T>` now implements `fmt::Debug`.][65013]

Stabilized APIs
---------------

- [`Result::map_or`]
- [`Result::map_or_else`]
- [`std::rc::Weak::weak_count`]
- [`std::rc::Weak::strong_count`]
- [`std::sync::Weak::weak_count`]
- [`std::sync::Weak::strong_count`]

Cargo
-----

- [Cargo will now document all the private items for binary crates
  by default.][cargo/7593]
- [`cargo-install` will now reinstall the package if it detects that it is out
  of date.][cargo/7560]
- [Cargo.lock now uses a more git friendly format that should help to reduce
  merge conflicts.][cargo/7579]
- [You can now override specific dependencies's build settings][cargo/7591] E.g.
  `[profile.dev.overrides.image] opt-level = 2` sets the `image` crate's
  optimisation level to `2` for debug builds. You can also use
  `[profile.<profile>.build_overrides]` to override build scripts and
  their dependencies.

Misc
----

- [You can now specify `edition` in documentation code blocks to compile the block
  for that edition.][66238] E.g. `edition2018` tells rustdoc that the code sample
  should be compiled the 2018 edition of Rust.
- [You can now provide custom themes to rustdoc with `--theme`, and check the
  current theme with `--check-theme`.][54733]
- [You can use `#[cfg(doc)]` to compile an item when building documentation.][61351]

Compatibility Notes
-------------------

- [As previously announced 1.41.0 will be the last tier 1 release for 32-bit
  Apple targets.][apple-32bit-drop] This means that the source code is still
  available to build, but the targets are no longer being tested and release
  binaries for those platforms will no longer be distributed by the Rust project.
  Please refer to the linked blog post for more information.

[54733]: rust-lang/rust#54733
[61351]: rust-lang/rust#61351
[67255]: rust-lang/rust#67255
[66661]: rust-lang/rust#66661
[66771]: rust-lang/rust#66771
[66847]: rust-lang/rust#66847
[66238]: rust-lang/rust#66238
[66277]: rust-lang/rust#66277
[66325]: rust-lang/rust#66325
[66172]: rust-lang/rust#66172
[66183]: rust-lang/rust#66183
[65879]: rust-lang/rust#65879
[65013]: rust-lang/rust#65013
[64882]: rust-lang/rust#64882
[64325]: rust-lang/rust#64325
[cargo/7560]: rust-lang/cargo#7560
[cargo/7579]: rust-lang/cargo#7579
[cargo/7591]: rust-lang/cargo#7591
[cargo/7593]: rust-lang/cargo#7593
[`Result::map_or_else`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.map_or_else
[`Result::map_or`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.map_or
[`std::rc::Weak::weak_count`]: https://doc.rust-lang.org/std/rc/struct.Weak.html#method.weak_count
[`std::rc::Weak::strong_count`]: https://doc.rust-lang.org/std/rc/struct.Weak.html#method.strong_count
[`std::sync::Weak::weak_count`]: https://doc.rust-lang.org/std/sync/struct.Weak.html#method.weak_count
[`std::sync::Weak::strong_count`]: https://doc.rust-lang.org/std/sync/struct.Weak.html#method.strong_count
[apple-32bit-drop]: https://blog.rust-lang.org/2020/01/03/reducing-support-for-32-bit-apple-targets.html
ojeda added a commit to ojeda/rust that referenced this pull request Feb 18, 2021
@ojeda
rustc: Show @path usage in stable
9b9c5ea 
The feature was stabilized in rust-lang#66172, but the usage string was not
updated to be shown.

Signed-off-by: Miguel Ojeda <[email protected]>
@ojeda ojeda mentioned this pull request Feb 18, 2021
Merged
@ojeda ojeda mentioned this pull request Feb 18, 2021
Merged
ojeda added a commit to ojeda/rust that referenced this pull request Feb 19, 2021
@ojeda
rustdoc: Support argument files
755b3fc 
Factors out the `rustc_driver` logic that handles argument files
so that rustdoc supports them as well, e.g.:

    rustdoc @argfile

This is needed to be able to generate docs for projects that
already use argument files when compiling them, e.g. projects
that pass a huge number of `--cfg` arguments.

The feature was stabilized for `rustc` in rust-lang#66172.

Signed-off-by: Miguel Ojeda <[email protected]>
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Feb 19, 2021
@Dylan-DPC
Rollup merge of rust-lang#82261 - ojeda:rustdoc-argfile, r=jyn514
d9bc16c 
rustdoc: Support argument files

Factors out the `rustc_driver` logic that handles argument files so that rustdoc supports them as well, e.g.:

    rustdoc `@argfile`

This is needed to be able to generate docs for projects that already use argument files when compiling them, e.g. projects that pass a huge number of `--cfg` arguments.

The feature was stabilized for `rustc` in rust-lang#66172.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 19, 2021
@GuillaumeGomez
Rollup merge of rust-lang#82260 - ojeda:rustc-argfile, r=jyn514
347b269 
rustc: Show `@path` usage in stable

The feature was stabilized in rust-lang#66172, but the usage string was not updated to be shown.
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 20, 2021
@GuillaumeGomez
Rollup merge of rust-lang#82260 - ojeda:rustc-argfile, r=jyn514
8c09561 
rustc: Show `@path` usage in stable

The feature was stabilized in rust-lang#66172, but the usage string was not updated to be shown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.41
Development

Successfully merging this pull request may close these issues.
6 participants
@jsgf @rust-highfive @nikomatsakis @bors @Centril @jonas-schievink