Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test style in unused parentheses lint test #65507

Merged
merged 5 commits into from
Oct 23, 2019
+66 −754
Merged

Fix test style in unused parentheses lint test #65507

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9bca18
Replaced warn attibute by deny
Oct 17, 2019
43b5dca
Replaced warn attribute by deny
Oct 17, 2019
46a4466
Replaced pretty-json error-format with only json
Oct 17, 2019
a1387e3
Replaced pretty-json error-format with only json
Oct 17, 2019
95d98af
Added text after error messages
Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Replaced pretty-json error-format with only json
Lucas Henry committed Oct 17, 2019

Verified

This commit was signed with the committer’s verified signature.
Kikobeats Kiko Beats
GPG key ID: 8FA93B22CCF04B96
Verified
Learn about vigilant mode
commit a1387e352f36ae6cd80ee25e01a4a6de2aedef45
2 changes: 1 addition & 1 deletion src/test/ui/lint/unused_parens_json_suggestion.fixed
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// compile-flags: --error-format pretty-json -Zunstable-options
// compile-flags: --error-format json -Zunstable-options
// run-rustfix

// The output for humans should just highlight the whole span without showing
2 changes: 1 addition & 1 deletion src/test/ui/lint/unused_parens_json_suggestion.rs
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// compile-flags: --error-format pretty-json -Zunstable-options
// compile-flags: --error-format json -Zunstable-options
// run-rustfix

// The output for humans should just highlight the whole span without showing
108 changes: 4 additions & 104 deletions src/test/ui/lint/unused_parens_json_suggestion.stderr
View file
Original file line number Diff line number Diff line change
@@ -1,96 +1,4 @@
{
"message": "unnecessary parentheses around assigned value",
"code": {
"code": "unused_parens",
"explanation": null
},
"level": "error",
"spans": [
{
"file_name": "$DIR/unused_parens_json_suggestion.rs",
"byte_start": 603,
"byte_end": 616,
"line_start": 16,
"line_end": 16,
"column_start": 14,
"column_end": 27,
"is_primary": true,
"text": [
{
"text": " let _a = (1 / (2 + 3));
"highlight_start": 14,
"highlight_end": 27
}
],
"label": null,
"suggested_replacement": null,
"suggestion_applicability": null,
"expansion": null
}
],
"children": [
{
"message": "lint level defined here",
"code": null,
"level": "note",
"spans": [
{
"file_name": "$DIR/unused_parens_json_suggestion.rs",
"byte_start": 421,
"byte_end": 434,
"line_start": 10,
"line_end": 10,
"column_start": 9,
"column_end": 22,
"is_primary": true,
"text": [
{
"text": "#![deny(unused_parens)]",
"highlight_start": 9,
"highlight_end": 22
}
],
"label": null,
"suggested_replacement": null,
"suggestion_applicability": null,
"expansion": null
}
],
"children": [],
"rendered": null
},
{
"message": "remove these parentheses",
"code": null,
"level": "help",
"spans": [
{
"file_name": "$DIR/unused_parens_json_suggestion.rs",
"byte_start": 603,
"byte_end": 616,
"line_start": 16,
"line_end": 16,
"column_start": 14,
"column_end": 27,
"is_primary": true,
"text": [
{
"text": " let _a = (1 / (2 + 3));
"highlight_start": 14,
"highlight_end": 27
}
],
"label": null,
"suggested_replacement": "1 / (2 + 3)",
"suggestion_applicability": "MachineApplicable",
"expansion": null
}
],
"children": [],
"rendered": null
}
],
"rendered": "error: unnecessary parentheses around assigned value
{"message":"unnecessary parentheses around assigned value","code":{"code":"unused_parens","explanation":null},"level":"error","spans":[{"file_name":"$DIR/unused_parens_json_suggestion.rs","byte_start":596,"byte_end":609,"line_start":16,"line_end":16,"column_start":14,"column_end":27,"is_primary":true,"text":[{"text":" let _a = (1 / (2 + 3));
--> $DIR/unused_parens_json_suggestion.rs:16:14
|
LL | let _a = (1 / (2 + 3));
@@ -102,15 +10,7 @@ note: lint level defined here
LL | #![deny(unused_parens)]
| ^^^^^^^^^^^^^

"
}
{
"message": "aborting due to previous error",
"code": null,
"level": "error",
"spans": [],
"children": [],
"rendered": "error: aborting due to previous error
"}
{"message":"aborting due to previous error","code":null,"level":"error","spans":[],"children":[],"rendered":"error: aborting due to previous error

"
}
"}