Rollup of 18 pull requests #65152
Merged
Rollup of 18 pull requests #65152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tracking issue rust-lang#50264 still has unresolved question for the corresponding `Result` methods.
This is a stylistic change to libstd to reduce the number of checks of `feature = "backtrace"` now that we unconditionally depend on the `backtrace` crate and rely on it having an empty implementation. otherwise.
Co-Authored-By: Mazdak Farrokhzad <[email protected]>
Still debating if this is the right approach
Co-Authored-By: Pietro Albini <[email protected]>
visit_statement default definition does just this, there's no need to redefine it.
It has been fully disabled by default since rust-lang#54639.
Do not ICE when dereferencing non-Copy raw pointer CC rust-lang#52262. Confirmed to remove the unnecessary ICE, but without a repro case.
…by-anyone, r=nikomatsakis permit asyncawait-ondeck to be added by anyone Still debating if this is the right approach but r? @pietroalbini to check the format
…olymorphic_promoted_mir, r=oli-obk [const-prop] Fix ICE when trying to eval polymorphic promoted MIR Fixes rust-lang#64908 r? @oli-obk cc @nikomatsakis @pnkfelix
Replace GeneratorSubsts with SubstsRef Closes rust-lang#42340 r? @nikomatsakis
…ikomatsakis Split out some passes from librustc This is just moving them out to librustc_passes -- I've not measured compile time or run time. I don't expect any significant impact, but this seems prudent regardless.
…r=Centril Allow unused attributes to avoid incremental bug cc rust-lang#65023 This isn't labeled as fixing that issue because it's not really a fix, just a patch.
Fix lonely backtick That backtick won't be sad anymore
…i-obk Remove unneeded visit_statement definition r? @oli-obk
…=rkruppe Update the documented default of -Z mutable-noalias It has been fully disabled by default since rust-lang#54639.
…ebank Account for macro invocation in `let mut $pat` diagnostic. Fixes rust-lang#65122. r? @estebank
Replace some instances of `as *[const | mut] _` with `.cast()` While in `codegen_llvm`, noticed some places for the recent `pointer::cast` method.
Fix typo on `now()` comments Fix typo, update words, and remove some redundant word. Also rustfmt on the rest of the file (hope this is okay :) revival of rust-lang#61433 r? @kennytm
… r=petrochenkov lint: extern non-exhaustive types are improper This PR makes the `improper_ctype` lint trigger for non-exhaustive types when those types aren't defined in the current crate, as per [this comment](rust-lang#44109 (comment)). cc @Centril
…r=tmandry Revert rust-lang#63649 - "Upgrade Emscripten targets to use upstream LLVM backend" This change caused the runtime of the linux-asmjs builder to nearly double from 2+ hours to about 4 hours, which happens to be the bors timeout. (It made it in barely under 4 hours when it was merged.) This is causing timeouts on all new changes. This reverts commit 7870050, reversing changes made to 2e72448.
|
@bors r+ p=18 rollup=never |
|
📌 Commit 69598dc has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 6, 2019
Rollup of 18 pull requests This contains changes from all the successful runs that bors marked as timed out, plus a revert of #63649 which appears to be the immediate cause of the timeouts. Successful merges: - #64708 (Stabilize `Option::as_deref` and `Option::as_deref_mut`) - #64728 (Stabilize UdpSocket::peer_addr) - #64765 (std: Reduce checks for `feature = "backtrace"`) - #64909 (When encountering chained operators use heuristics to recover from bad turbofish) - #65011 (Do not ICE when dereferencing non-Copy raw pointer) - #65064 (permit asyncawait-ondeck to be added by anyone) - #65066 ([const-prop] Fix ICE when trying to eval polymorphic promoted MIR) - #65100 (Replace GeneratorSubsts with SubstsRef) - #65105 (Split out some passes from librustc) - #65106 (Allow unused attributes to avoid incremental bug) - #65113 (Fix lonely backtick) - #65116 (Remove unneeded visit_statement definition) - #65118 (Update the documented default of -Z mutable-noalias) - #65123 (Account for macro invocation in `let mut $pat` diagnostic.) - #65124 (Replace some instances of `as *[const | mut] _` with `.cast()`) - #65126 (Fix typo on `now()` comments) - #65130 (lint: extern non-exhaustive types are improper) - #65151 (Revert #63649 - "Upgrade Emscripten targets to use upstream LLVM backend") Failed merges: r? @ghost
|
☀️ Test successful - checks-azure |
This was referenced Oct 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains changes from all the successful runs that bors marked as timed out, plus a revert of #63649 which appears to be the immediate cause of the timeouts.
Successful merges:
Option::as_derefandOption::as_deref_mut#64708 (StabilizeOption::as_derefandOption::as_deref_mut)feature = "backtrace"#64765 (std: Reduce checks forfeature = "backtrace")let mut $patdiagnostic. #65123 (Account for macro invocation inlet mut $patdiagnostic.)as *[const | mut] _with.cast()#65124 (Replace some instances ofas *[const | mut] _with.cast())now()comments #65126 (Fix typo onnow()comments)Failed merges:
r? @ghost