Add support for relating slices in super_relate_consts
#64858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Centril
reviewed
Sep 27, 2019
|
cc @yodaldevoid, who looked into the issue previously — you might have some thoughts. |
varkor
reviewed
Sep 28, 2019
Centril
reviewed
Sep 28, 2019
|
Thanks @Skinny121, this looks good! @bors r+ |
|
📌 Commit 5cb0039 has been approved by |
bors
added
S-waiting-on-bors
|
Good job fixing this! I don't know if you went through all of the const generics issues, but this might fix a couple more than you noted. |
fbstj
reviewed
Sep 28, 2019
|
@yodaldevoid I think this PR only fixes the two cases I mentioned. #63322, #62579, and #62395 are similar but are for different types than strings/slices. |
Centril
reviewed
Sep 28, 2019
| LL | let _: ConstString<"Hello"> = ConstString::<"World">; | ||
| | ^^^^^^^^^^^^^^^^^^^^^^ expected `"Hello"`, found `"World"` | ||
| | | ||
| = note: expected type `ConstString<>` |
|
@bors r+ |
|
📌 Commit 54bad93 has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 29, 2019
Add support for relating slices in `super_relate_consts` This allows passing strings as generic arguments. Fixes rust-lang#63773 Fixes rust-lang#60813 r? @varkor
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 29, 2019
Add support for relating slices in `super_relate_consts` This allows passing strings as generic arguments. Fixes rust-lang#63773 Fixes rust-lang#60813 r? @varkor
bors
added a commit
that referenced
this pull request
Sep 29, 2019
Rollup of 6 pull requests Successful merges: - #64691 (Point at definition when misusing ADT) - #64735 (Add long error explanation for E0533) - #64825 (Point at enclosing match when expecting `()` in arm) - #64858 (Add support for relating slices in `super_relate_consts`) - #64894 (syntax: fix dropping of attribute on first param of non-method assocated fn) - #64898 (fixed typo) Failed merges: r? @ghost
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows passing strings as generic arguments.
Fixes #63773
Fixes #60813
r? @varkor