Update clippy and rls #64604

tesuji · 2019-09-19T08:35:16Z

r? @oli-obk cc @Manishearth

rust-highfive · 2019-09-19T08:35:26Z

⚠️ Warning ⚠️

These commits modify submodules.

oli-obk · 2019-09-19T13:25:15Z

@bors r+ p=1

bors · 2019-09-19T13:25:16Z

📌 Commit 202e0ac44c1d5c36ff4750a2df47e3217935d728 has been approved by oli-obk

bors · 2019-09-19T15:47:05Z

⌛ Testing commit 202e0ac44c1d5c36ff4750a2df47e3217935d728 with merge 56f22b3d068befa0edb6bebe8a97d030d9c344ce...

bors · 2019-09-19T18:25:07Z

💔 Test failed - checks-azure

rust-highfive · 2019-09-19T18:25:08Z

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-19T18:22:41.3435678Z == clock drift check ==
2019-09-19T18:22:41.3456334Z   local time: Thu Sep 19 18:22:41 UTC 2019
2019-09-19T18:22:41.4098856Z   network time: Thu, 19 Sep 2019 18:22:41 GMT
2019-09-19T18:22:41.4103566Z == end clock drift check ==
2019-09-19T18:22:42.0954902Z ##[error]Bash exited with code '1'.
2019-09-19T18:22:42.0997845Z ##[section]Starting: Upload CPU usage statistics
2019-09-19T18:22:42.1010259Z ==============================================================================
2019-09-19T18:22:42.1010379Z Task         : Bash
2019-09-19T18:22:42.1010452Z Description  : Run a Bash script on macOS, Linux, or Windows

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

tesuji · 2019-09-19T23:44:27Z

2019-09-19T18:22:41.3307957Z The state of "clippy-driver" has changed from "build-fail" to "test-pass"
2019-09-19T18:22:41.3308802Z The state of "rls" has changed from "test-pass" to "build-fail"
2019-09-19T18:22:41.3416512Z The state of "rls" has regressed from "test-pass" to "build-fail"

cc @Xanewok

mati865 · 2019-09-19T23:49:58Z

^^

2019-09-19T18:06:26.4266026Z error[E0433]: failed to resolve: could not find `rustc_driver` in `self`
2019-09-19T18:06:26.4266525Z --> src/tools/rls/rls-rustc/src/clippy.rs:52:15
2019-09-19T18:06:26.4266824Z |
2019-09-19T18:06:26.4268557Z 52 | use self::rustc_driver::plugin::registry::Registry;
2019-09-19T18:06:26.4269338Z | ^^^^^^^^^^^^ could not find `rustc_driver` in `self`

I think it was not found during RLS update because this code is guarded by #[cfg(feature = "clippy")] and clippy feature was disabled because Clippy didn't build.

Fix RLS compile error for rust-lang/rust#64604 (Update clippy)

msizanoen1 · 2019-09-21T05:19:55Z

rust-lang/rls#1556 has been merged. You may want to update RLS too.

tesuji · 2019-09-21T05:34:41Z

Done. Thanks @msizanoen1. Ping @oli-obk

rust-highfive · 2019-09-21T08:42:35Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-21T08:38:12.4806183Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-09-21T08:38:13.4357320Z ##[command]git config gc.auto 0
2019-09-21T08:38:13.4360686Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-09-21T08:38:13.4377539Z ##[command]git config --get-all http.proxy
2019-09-21T08:38:13.4383874Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/64604/merge:refs/remotes/pull/64604/merge
---
2019-09-21T08:42:30.3576594Z == clock drift check ==
2019-09-21T08:42:30.3594986Z   local time: Sat Sep 21 08:42:30 UTC 2019
2019-09-21T08:42:30.6379867Z   network time: Sat, 21 Sep 2019 08:42:30 GMT
2019-09-21T08:42:30.6380778Z == end clock drift check ==
2019-09-21T08:42:31.7512228Z ##[error]Bash exited with code '1'.
2019-09-21T08:42:31.7546068Z ##[section]Starting: Checkout
2019-09-21T08:42:31.7547917Z ==============================================================================
2019-09-21T08:42:31.7548129Z Task         : Get sources
2019-09-21T08:42:31.7548178Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

oli-obk · 2019-09-21T11:37:27Z

@bors r+ p=1

bors · 2019-09-21T11:37:28Z

📌 Commit 074871e has been approved by oli-obk

oli-obk · 2019-09-21T11:39:47Z

Please investigate why we now have two pulldown versions and deduplicate them by using the newer one everywhere

tesuji · 2019-09-21T12:00:27Z

Clippy have just updated pulldown-cmark. We need mdbook updated too.

Edit: But there's a problem: rust-lang/mdBook#1021

bors · 2019-09-22T11:29:25Z

⌛ Testing commit 074871e with merge f177de6...

@oli-obk

Update clippy and rls r? @oli-obk cc @Manishearth

bors · 2019-09-22T14:35:07Z

💔 Test failed - checks-azure

rust-highfive · 2019-09-22T14:35:07Z

The job x86_64-gnu-tools of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-09-22T13:40:50.1143669Z test [ui] ui/float_cmp_const.rs ... ok
2019-09-22T13:40:50.6580476Z test [ui] ui/fn_to_numeric_cast.rs ... ok
2019-09-22T13:40:50.7552302Z test [ui] ui/for_kv_map.rs ... ok
2019-09-22T13:40:51.4112598Z test [ui] ui/for_loop_over_option_result.rs ... ok
2019-09-22T13:40:52.2298157Z test [ui] ui/for_loop_unfixable.rs ... ok
2019-09-22T13:40:53.1455730Z test [ui] ui/for_loop_fixable.rs ... ok
2019-09-22T13:40:53.7396784Z test [ui] ui/format.rs ... ok
2019-09-22T13:40:54.2781639Z test [ui] ui/functions.rs ... ok
2019-09-22T13:40:54.4426206Z test [ui] ui/functions_maxlines.rs ... ok
2019-09-22T13:40:55.4300371Z test [ui] ui/get_last_with_len.rs ... ok
---
2019-09-22T13:42:08.2132073Z normalized stderr:
2019-09-22T13:42:08.2132489Z error: This generic shadows the built-in type `u32`
2019-09-22T13:42:08.2132773Z   --> $DIR/builtin-type-shadow.rs:4:8
2019-09-22T13:42:08.2133102Z    |
2019-09-22T13:42:08.2133463Z LL | fn foo<u32>(a: u32) -> u32 {
2019-09-22T13:42:08.2133862Z    |
2019-09-22T13:42:08.2134254Z    = note: `-D clippy::builtin-type-shadow` implied by `-D warnings`
2019-09-22T13:42:08.2134460Z 
2019-09-22T13:42:08.2134577Z error[E0308]: mismatched types
2019-09-22T13:42:08.2134577Z error[E0308]: mismatched types
2019-09-22T13:42:08.2135219Z   --> $DIR/builtin-type-shadow.rs:5:5
2019-09-22T13:42:08.2135328Z    |
2019-09-22T13:42:08.2135847Z LL | fn foo<u32>(a: u32) -> u32 {
2019-09-22T13:42:08.2136338Z    |                        --- expected `u32` because of return type
2019-09-22T13:42:08.2136696Z    |     ^^ expected type parameter, found integer
2019-09-22T13:42:08.2136786Z    |
2019-09-22T13:42:08.2136864Z    = note: expected type `u32`
2019-09-22T13:42:08.2136864Z    = note: expected type `u32`
2019-09-22T13:42:08.2136936Z               found type `{integer}`
2019-09-22T13:42:08.2137433Z    = help: type parameters must be constrained to match other types
2019-09-22T13:42:08.2137911Z    = note: for more information, visit https://doc.rust-lang.org/book/ch10-02-traits.html#traits-as-parameters
2019-09-22T13:42:08.2138417Z error: aborting due to 2 previous errors
2019-09-22T13:42:08.2138498Z 
2019-09-22T13:42:08.2139005Z For more information about this error, try `rustc --explain E0308`.
2019-09-22T13:42:08.2139226Z 
2019-09-22T13:42:08.2139226Z 
2019-09-22T13:42:08.2139297Z 
2019-09-22T13:42:08.2139377Z expected stderr:
2019-09-22T13:42:08.2139710Z error: This generic shadows the built-in type `u32`
2019-09-22T13:42:08.2140155Z   --> $DIR/builtin-type-shadow.rs:4:8
2019-09-22T13:42:08.2140373Z    |
2019-09-22T13:42:08.2140702Z LL | fn foo<u32>(a: u32) -> u32 {
2019-09-22T13:42:08.2140994Z    |
2019-09-22T13:42:08.2141359Z    = note: `-D clippy::builtin-type-shadow` implied by `-D warnings`
2019-09-22T13:42:08.2141431Z 
2019-09-22T13:42:08.2141647Z error[E0308]: mismatched types
2019-09-22T13:42:08.2141647Z error[E0308]: mismatched types
2019-09-22T13:42:08.2141966Z   --> $DIR/builtin-type-shadow.rs:5:5
2019-09-22T13:42:08.2142188Z    |
2019-09-22T13:42:08.2142513Z LL | fn foo<u32>(a: u32) -> u32 {
2019-09-22T13:42:08.2142985Z    |                        --- expected `u32` because of return type
2019-09-22T13:42:08.2143333Z    |     ^^ expected type parameter, found integer
2019-09-22T13:42:08.2143421Z    |
2019-09-22T13:42:08.2143608Z    = note: expected type `u32`
2019-09-22T13:42:08.2143608Z    = note: expected type `u32`
2019-09-22T13:42:08.2143709Z               found type `{integer}`
2019-09-22T13:42:08.2143872Z error: aborting due to 2 previous errors
2019-09-22T13:42:08.2143918Z 
2019-09-22T13:42:08.2144281Z For more information about this error, try `rustc --explain E0308`.
2019-09-22T13:42:08.2144465Z 
2019-09-22T13:42:08.2144465Z 
2019-09-22T13:42:08.2144551Z 
2019-09-22T13:42:08.2144634Z diff of stderr:
2019-09-22T13:42:08.2144689Z 
2019-09-22T13:42:08.2145455Z  error: This generic shadows the built-in type `u32`
2019-09-22T13:42:08.2145957Z    --> $DIR/builtin-type-shadow.rs:4:8
2019-09-22T13:42:08.2146178Z     |
2019-09-22T13:42:08.2146505Z  LL | fn foo<u32>(a: u32) -> u32 {
2019-09-22T13:42:08.2146826Z     |
2019-09-22T13:42:08.2147195Z     = note: `-D clippy::builtin-type-shadow` implied by `-D warnings`
2019-09-22T13:42:08.2147279Z  
2019-09-22T13:42:08.2147359Z  error[E0308]: mismatched types
2019-09-22T13:42:08.2147359Z  error[E0308]: mismatched types
2019-09-22T13:42:08.2147679Z    --> $DIR/builtin-type-shadow.rs:5:5
2019-09-22T13:42:08.2147914Z     |
2019-09-22T13:42:08.2148244Z  LL | fn foo<u32>(a: u32) -> u32 {
2019-09-22T13:42:08.2148713Z     |                        --- expected `u32` because of return type
2019-09-22T13:42:08.2149078Z     |     ^^ expected type parameter, found integer
2019-09-22T13:42:08.2149170Z     |
2019-09-22T13:42:08.2149267Z     = note: expected type `u32`
2019-09-22T13:42:08.2149267Z     = note: expected type `u32`
2019-09-22T13:42:08.2149358Z                found type `{integer}`
2019-09-22T13:42:08.2149487Z +   = help: type parameters must be constrained to match other types
2019-09-22T13:42:08.2149911Z +   = note: for more information, visit https://doc.rust-lang.org/book/ch10-02-traits.html#traits-as-parameters
2019-09-22T13:42:08.2150268Z  error: aborting due to 2 previous errors
2019-09-22T13:42:08.2150359Z  
2019-09-22T13:42:08.2150718Z  For more information about this error, try `rustc --explain E0308`.
2019-09-22T13:42:08.2150952Z  
---
2019-09-22T13:42:08.2156956Z 
2019-09-22T13:42:08.2157206Z ------------------------------------------
2019-09-22T13:42:08.2157295Z stderr:
2019-09-22T13:42:08.2157754Z ------------------------------------------
2019-09-22T13:42:08.2159267Z {"message":"This generic shadows the built-in type `u32`","code":{"code":"clippy::builtin_type_shadow","explanation":null},"level":"error","spans":[{"file_name":"tests/ui/builtin-type-shadow.rs","byte_start":78,"byte_end":81,"line_start":4,"line_end":4,"column_start":8,"column_end":11,"is_primary":true,"text":[{"text":"fn foo<u32>(a: u32) -> u32 {","highlight_start":8,"highlight_end":11}],"label":null,"suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"`-D clippy::builtin-type-shadow` implied by `-D warnings`","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error: This generic shadows the built-in type `u32`\n  --> tests/ui/builtin-type-shadow.rs:4:8\n   |\nLL | fn foo<u32>(a: u32) -> u32 {\n   |        ^^^\n   |\n   = note: `-D clippy::builtin-type-shadow` implied by `-D warnings`\n\n"}
2019-09-22T13:42:08.2163352Z {"message":"mismatched types","code":{"code":"E0308","explanation":"\nThis error occurs when the compiler was unable to infer the concrete type of a\nvariable. It can occur for several cases, the most common of which is a\nmismatch in the expected type that the compiler inferred for a variable's\ninitializing expression, and the actual type explicitly assigned to the\nvariable.\n\nFor example:\n\n```compile_fail,E0308\nlet x: i32 = \"I am not a number!\";\n//     ~~~   ~~~~~~~~~~~~~~~~~~~~\n//      |             |\n//      |    initializing expression;\n//      |    compiler infers type `&str`\n//      |\n//    type `i32` assigned to variable `x`\n```\n"},"level":"error","spans":[{"file_name":"tests/ui/builtin-type-shadow.rs","byte_start":104,"byte_end":106,"line_start":5,"line_end":5,"column_start":5,"column_end":7,"is_primary":true,"text":[{"text":"    42","highlight_start":5,"highlight_end":7}],"label":"expected type parameter, found integer","suggested_replacement":null,"suggestion_applicability":null,"expansion":null},{"file_name":"tests/ui/builtin-type-shadow.rs","byte_start":94,"byte_end":97,"line_start":4,"line_end":4,"column_start":24,"column_end":27,"is_primary":false,"text":[{"text":"fn foo<u32>(a: u32) -> u32 {","highlight_start":24,"highlight_end":27}],"label":"expected `u32` because of return type","suggested_replacement":null,"suggestion_applicability":null,"expansion":null}],"children":[{"message":"expected type `u32`\n   found type `{integer}`","code":null,"level":"note","spans":[],"children":[],"rendered":null},{"message":"type parameters must be constrained to match other types","code":null,"level":"help","spans":[],"children":[],"rendered":null},{"message":"for more information, visit https://doc.rust-lang.org/book/ch10-02-traits.html#traits-as-parameters","code":null,"level":"note","spans":[],"children":[],"rendered":null}],"rendered":"error[E0308]: mismatched types\n  --> tests/ui/builtin-type-shadow.rs:5:5\n   |\nLL | fn foo<u32>(a: u32) -> u32 {\n   |                        --- expected `u32` because of return type\nLL |     42\n   |     ^^ expected type parameter, found integer\n   |\n   = note: expected type `u32`\n              found type `{integer}`\n   = help: type parameters must be constrained to match other types\n   = note: for more information, visit https://doc.rust-lang.org/book/ch10-02-traits.html#traits-as-parameters\n\n"}
2019-09-22T13:42:08.2166032Z {"message":"For more information about this error, try `rustc --explain E0308`.","code":null,"level":"failure-note","spans":[],"children":[],"rendered":"For more information about this error, try `rustc --explain E0308`.\n"}
2019-09-22T13:42:08.2166191Z 
2019-09-22T13:42:08.2166491Z ------------------------------------------
2019-09-22T13:42:08.2166564Z 
---
2019-09-22T14:32:35.8484795Z Verifying status of rustfmt...
2019-09-22T14:32:35.8499929Z Verifying status of clippy-driver...
2019-09-22T14:32:35.8514873Z This PR updated 'src/tools/clippy', verifying if status is 'test-pass'...
2019-09-22T14:32:35.8525930Z 
2019-09-22T14:32:35.8526988Z ⚠️ We detected that this PR updated 'clippy-driver', but its tests failed.
2019-09-22T14:32:35.8527438Z 
2019-09-22T14:32:35.8528665Z If you do intend to update 'clippy-driver', please check the error messages above and
2019-09-22T14:32:35.8528797Z commit another update.
2019-09-22T14:32:35.8528867Z 
2019-09-22T14:32:35.8529244Z If you do NOT intend to update 'clippy-driver', please ensure you did not accidentally
2019-09-22T14:32:35.8529618Z change the submodule at 'src/tools/clippy'. You may ask your reviewer for the
2019-09-22T14:32:35.8529714Z proper steps.
2019-09-22T14:32:35.8547303Z   local time: Sun Sep 22 14:32:35 UTC 2019
2019-09-22T14:32:35.9370367Z   network time: Sun, 22 Sep 2019 14:32:35 GMT
2019-09-22T14:32:35.9370531Z == end clock drift check ==
2019-09-22T14:32:35.9370531Z == end clock drift check ==
2019-09-22T14:32:36.5337373Z ##[error]Bash exited with code '3'.
2019-09-22T14:32:36.5374953Z ##[section]Starting: Upload CPU usage statistics
2019-09-22T14:32:36.5382077Z ==============================================================================
2019-09-22T14:32:36.5382178Z Task         : Bash
2019-09-22T14:32:36.5382267Z Description  : Run a Bash script on macOS, Linux, or Windows

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

tesuji · 2019-09-22T15:03:28Z

Included rust-lang/rust-clippy#4565 . Ping @oli-obk

oli-obk · 2019-09-22T15:50:37Z

@bors r+ p=1

bors · 2019-09-22T15:50:38Z

📌 Commit d06de5d has been approved by oli-obk

bors · 2019-09-22T18:33:21Z

⌛ Testing commit d06de5d with merge 1dd1884...

@oli-obk

Update clippy and rls r? @oli-obk cc @Manishearth

bors · 2019-09-22T22:34:16Z

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 1dd1884 to master...

rust-highfive · 2019-09-22T22:35:29Z

📣 Toolstate changed by #64604!

Tested on commit 1dd1884.
Direct link to PR: #64604

🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).
🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

@mcarton

Tested on commit rust-lang/rust@1dd1884. Direct link to PR: <rust-lang/rust#64604> 🎉 clippy-driver on windows: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra). 🎉 clippy-driver on linux: build-fail → test-pass (cc @mcarton @oli-obk @Manishearth @flip1995 @yaahc @phansch @llogiq, @rust-lang/infra).

rust-highfive assigned oli-obk Sep 19, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 19, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 19, 2019

msizanoen1 mentioned this pull request Sep 20, 2019

Fix RLS compile error for rust-lang/rust#64604 (Update clippy) rust-lang/rls#1556

Merged

Xanewok added a commit to rust-lang/rls that referenced this pull request Sep 20, 2019

Merge pull request #1556 from msizanoen1/fix-build-fail-64604

80a1d34

Fix RLS compile error for rust-lang/rust#64604 (Update clippy)

tesuji force-pushed the clippyup branch from 202e0ac to a65b526 Compare September 21, 2019 05:29

tesuji changed the title ~~Update clippy~~ Update clippy and rls Sep 21, 2019

tesuji force-pushed the clippyup branch from a65b526 to c882ca0 Compare September 21, 2019 08:37

tesuji force-pushed the clippyup branch from c882ca0 to 074871e Compare September 21, 2019 08:58

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 21, 2019

bors added a commit that referenced this pull request Sep 22, 2019

Auto merge of #64604 - lzutao:clippyup, r=oli-obk

f177de6

Update clippy and rls r? @oli-obk cc @Manishearth

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 22, 2019

tesuji added 2 commits September 22, 2019 15:02

Update clippy

bbce971

Update rls to fix build error

d06de5d

tesuji force-pushed the clippyup branch from 074871e to d06de5d Compare September 22, 2019 15:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2019

bors added a commit that referenced this pull request Sep 22, 2019

Auto merge of #64604 - lzutao:clippyup, r=oli-obk

1dd1884

Update clippy and rls r? @oli-obk cc @Manishearth

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 22, 2019

bors merged commit d06de5d into rust-lang:master Sep 22, 2019

tesuji deleted the clippyup branch September 22, 2019 23:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update clippy and rls #64604

Update clippy and rls #64604

tesuji commented Sep 19, 2019

rust-highfive commented Sep 19, 2019

oli-obk commented Sep 19, 2019

bors commented Sep 19, 2019

bors commented Sep 19, 2019

bors commented Sep 19, 2019

rust-highfive commented Sep 19, 2019

tesuji commented Sep 19, 2019

mati865 commented Sep 19, 2019

msizanoen1 commented Sep 21, 2019

tesuji commented Sep 21, 2019

rust-highfive commented Sep 21, 2019

oli-obk commented Sep 21, 2019

bors commented Sep 21, 2019

oli-obk commented Sep 21, 2019

tesuji commented Sep 21, 2019 •

edited

Loading

bors commented Sep 22, 2019

bors commented Sep 22, 2019

rust-highfive commented Sep 22, 2019

tesuji commented Sep 22, 2019 •

edited

Loading

oli-obk commented Sep 22, 2019

bors commented Sep 22, 2019

bors commented Sep 22, 2019

bors commented Sep 22, 2019

rust-highfive commented Sep 22, 2019

Update clippy and rls #64604

Update clippy and rls #64604

Conversation

tesuji commented Sep 19, 2019

rust-highfive commented Sep 19, 2019

oli-obk commented Sep 19, 2019

bors commented Sep 19, 2019

bors commented Sep 19, 2019

bors commented Sep 19, 2019

rust-highfive commented Sep 19, 2019

tesuji commented Sep 19, 2019

mati865 commented Sep 19, 2019

msizanoen1 commented Sep 21, 2019

tesuji commented Sep 21, 2019

rust-highfive commented Sep 21, 2019

oli-obk commented Sep 21, 2019

bors commented Sep 21, 2019

oli-obk commented Sep 21, 2019

tesuji commented Sep 21, 2019 • edited Loading

bors commented Sep 22, 2019

bors commented Sep 22, 2019

rust-highfive commented Sep 22, 2019

tesuji commented Sep 22, 2019 • edited Loading

oli-obk commented Sep 22, 2019

bors commented Sep 22, 2019

bors commented Sep 22, 2019

bors commented Sep 22, 2019

rust-highfive commented Sep 22, 2019

tesuji commented Sep 21, 2019 •

edited

Loading

tesuji commented Sep 22, 2019 •

edited

Loading