AdtDef is an algebraic data type, not abstract data type
#64357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Centril
commented
Sep 10, 2019
|
I think both "abstract data type" and "algebraic data type" are incorrect. "Abstract" because it's actually concrete and "algebraic" because it includes unions and is also not as general as the usual sense of "algebraic data type". I think @eddyb wasn't happy with the existing name as well; maybe |
varkor
reviewed
Sep 10, 2019
Centril
force-pushed
the
adt-docs-fix
branch
from
482565f
to
288c1b2
Compare
Centril
force-pushed
the
adt-docs-fix
branch
from
288c1b2
to
2fd4e58
Compare
|
@varkor Adjusted to "user-defined..." but also included a note at the bottom re. algebraic data types and how it is slightly wrong. |
|
@bors r+ rollup |
|
📌 Commit 2fd4e58 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 16, 2019
`AdtDef` is an algebraic data type, not abstract data type r? @varkor
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 16, 2019
`AdtDef` is an algebraic data type, not abstract data type r? @varkor
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 16, 2019
`AdtDef` is an algebraic data type, not abstract data type r? @varkor
bors
added a commit
that referenced
this pull request
Sep 16, 2019
Rollup of 4 pull requests Successful merges: - #64357 (`AdtDef` is an algebraic data type, not abstract data type) - #64485 (update Miri) - #64509 (Make some adjustments to the documentation for `std::convert::identity`) - #64518 (Use while let slice_pattern instead of carrying an index around) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @varkor