Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #63408

Merged
merged 24 commits into from
Aug 9, 2019
Merged

Rollup of 7 pull requests #63408

merged 24 commits into from
Aug 9, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Aug 9, 2019

Successful merges:

Failed merges:

r? @ghost

matthewjasper and others added 24 commits August 5, 2019 23:50
* Allow items to be accessible through private modules and fields when a
  macro can access them.
* Don't mark type-private items as reachable.
* Never make items exported/public via macros
They were reachable through opaque macros defined in `core`
Co-Authored-By: Mazdak Farrokhzad <[email protected]>
Co-Authored-By: Oliver Middleton <[email protected]>
Merge recent changes into master
Check rustbook links on all platforms when running locally

cc rust-lang#62739
… r=petrochenkov

Remove gensym in format_args

This also fixes some things to allow us to export opaque macros from libcore:

* Don't consider items that are only reachable through opaque macros as public/exported (so they aren't linted as needing docs)
* Mark private items reachable from the root of libcore as unstable - they are now reachable (in principle) in other crates via macros in libcore

r? @petrochenkov
Improve test output

I'm continuing to improve the test output for liballoc and libcore
enable flt2dec tests in Miri

With ldexp implemented (thanks to @christianpoveda), we can finally enable these tests in Miri. Well, most of them -- some are just too slow.
@Centril
Copy link
Contributor Author

Centril commented Aug 9, 2019

@bors r+ p=7 rollup=never

@bors
Copy link
Contributor

bors commented Aug 9, 2019

📌 Commit 4e3c209 has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 9, 2019
@bors
Copy link
Contributor

bors commented Aug 9, 2019

⌛ Testing commit 4e3c209 with merge 534b423...

bors added a commit that referenced this pull request Aug 9, 2019
Rollup of 7 pull requests

Successful merges:

 - #62672 (Deprecate `try!` macro)
 - #62950 (Check rustbook links on all platforms when running locally)
 - #63114 (Remove gensym in format_args)
 - #63397 (Add tests for some ICEs)
 - #63403 (Improve test output)
 - #63404 (enable flt2dec tests in Miri)
 - #63407 (reduce some test sizes in Miri)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Aug 9, 2019

☀️ Test successful - checks-azure
Approved by: Centril
Pushing 534b423 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 9, 2019
@bors bors merged commit 4e3c209 into rust-lang:master Aug 9, 2019
@Centril Centril deleted the rollup-skqrez3 branch August 9, 2019 15:55
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants