-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #63176
Rollup of 6 pull requests #63176
Conversation
Co-authored-by: eupn <[email protected]> Co-authored-by: Punit Singh Koura <[email protected]>
Co-authored-by: eupn <[email protected]> Co-authored-by: Punit Singh Koura <[email protected]>
Co-Authored-By: varkor <[email protected]>
There is no difference in the code/arguments, so go with the shorter name throughout the code.
MetaItem.span was always equivalent
Always the same as the passed MetaItem
…obody Add keywords item into the sidebar Fixes rust-lang#62939. cc @pravic screenshot of the result: ![Screenshot from 2019-07-25 14-29-48](https://user-images.githubusercontent.com/3050060/61874545-f9512080-aee8-11e9-8e8b-aa50216aec94.png) r? @QuietMisdreavus
Make "see issue" consistent Fixes rust-lang#62976. h/t to @punitkoura for initial patterns search. r? @varkor
Account for `maybe_whole_expr` in range patterns Fixes rust-lang#63115 (fallout from rust-lang#62550). r? @petrochenkov
…chenkov Cleanup syntax::attr Mostly removing needless arguments to constructors r? @petrochenkov
…cramertj Remove redundant method with const variable resolution I've also removed a `bug!()` in const value relation code and replaced it with a `FIXME`. Now `ConstValue::Slice` and `ConstValue::ByRef` will simply fail to unify rather than ICEing, which seems more user-friendly for testers.
cleanup StringReader fields reduce visibility and replace `Lrc<SourceFile>` with `start_pos`: the single bit we actually *need* from the file. r? @petrochenkov
@bors r+ p=6 rollup=never |
📌 Commit cb4c25b has been approved by |
⌛ Testing commit cb4c25b with merge 95a212a2461fd118dcd52773e554f4334ee17add... |
💔 Test failed - checks-azure |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Successful merges:
maybe_whole_expr
in range patterns #63122 (Account formaybe_whole_expr
in range patterns)Failed merges:
r? @ghost