normalize use of backticks in compiler messages for librustc_lint #62810

fakenine · 2019-07-19T18:06:08Z

#60532

rust-highfive · 2019-07-19T18:06:11Z

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

fakenine · 2019-07-19T18:06:35Z

r? @Centril

Centril · 2019-07-19T18:29:33Z

@bors r+

bors · 2019-07-19T18:29:34Z

📌 Commit c25a069b1a2551989ab95a6bea8885f2d106042e has been approved by Centril

rust-highfive · 2019-07-19T19:22:33Z

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-07-19T18:06:40.9074267Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-07-19T18:06:40.9289018Z ##[command]git config gc.auto 0
2019-07-19T18:06:40.9357455Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-07-19T18:06:40.9407080Z ##[command]git config --get-all http.proxy
2019-07-19T18:06:40.9546344Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/62810/merge:refs/remotes/pull/62810/merge
---
2019-07-19T18:07:16.5966855Z do so (now or later) by using -b with the checkout command again. Example:
2019-07-19T18:07:16.5966901Z 
2019-07-19T18:07:16.5967110Z   git checkout -b <new-branch-name>
2019-07-19T18:07:16.5967137Z 
2019-07-19T18:07:16.5967185Z HEAD is now at 712154673 Merge c25a069b1a2551989ab95a6bea8885f2d106042e into 527dce7137f7a3c7bf47d9a503abf25f88ea22de
2019-07-19T18:07:16.6115741Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-07-19T18:07:16.6118241Z ==============================================================================
2019-07-19T18:07:16.6118311Z Task         : Bash
2019-07-19T18:07:16.6118352Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-07-19T19:07:54.1985378Z .................................................................................................... 200/5835
2019-07-19T19:07:58.5428313Z .................................................................................................... 300/5835
2019-07-19T19:08:02.5346846Z .................................................................................................... 400/5835
2019-07-19T19:08:06.3216693Z .................................................................................................... 500/5835
2019-07-19T19:08:10.3283534Z ........................................................................i........................... 600/5835
2019-07-19T19:08:19.5098678Z .................................................................................................... 800/5835
2019-07-19T19:08:25.2511852Z .................................................................................................... 900/5835
2019-07-19T19:08:30.4376744Z ...................................................................................................i 1000/5835
2019-07-19T19:08:30.4376744Z ...................................................................................................i 1000/5835
2019-07-19T19:08:36.2425853Z ...........i........................................................................................ 1100/5835
2019-07-19T19:08:40.5429109Z .............................iiiii.................................................................. 1200/5835
2019-07-19T19:08:46.6832252Z .................................................................................................... 1400/5835
2019-07-19T19:08:49.4880752Z .................................................................................................... 1500/5835
2019-07-19T19:08:53.4239214Z .................................................................................................... 1600/5835
2019-07-19T19:08:56.1487947Z .................................................................................................... 1700/5835
2019-07-19T19:08:56.1487947Z .................................................................................................... 1700/5835
2019-07-19T19:08:59.7285156Z ....................................................................i............................... 1800/5835
2019-07-19T19:09:08.5818991Z .................................................................................................... 2000/5835
2019-07-19T19:09:13.0649335Z .................................................................................................... 2100/5835
2019-07-19T19:09:17.0054921Z .................................................................................................... 2200/5835
2019-07-19T19:09:17.0054921Z .................................................................................................... 2200/5835
2019-07-19T19:09:20.9939970Z ..................................................i................................................. 2300/5835
2019-07-19T19:09:31.4375724Z .................................................................................................... 2500/5835
2019-07-19T19:09:35.8228882Z .................................................................................................... 2600/5835
2019-07-19T19:09:41.1904720Z .................................................................................................... 2700/5835
2019-07-19T19:09:45.5602398Z .................................................................................................... 2800/5835
2019-07-19T19:09:45.5602398Z .................................................................................................... 2800/5835
2019-07-19T19:09:49.9040844Z .................................................................................................... 2900/5835
2019-07-19T19:09:55.3588619Z .................................................................................................... 3000/5835
2019-07-19T19:10:00.5277061Z .................................................................................................... 3100/5835
2019-07-19T19:10:06.0647057Z .................................................................................................... 3200/5835
2019-07-19T19:10:09.5949134Z .................................................................................................... 3300/5835
2019-07-19T19:10:13.5122505Z .................................................................................................... 3400/5835
2019-07-19T19:10:18.8100476Z .................................................................................................... 3500/5835
2019-07-19T19:10:22.7411737Z ............i....................................................................................... 3600/5835
2019-07-19T19:10:27.1130716Z ......................................................................................ii...i..ii.... 3700/5835
2019-07-19T19:10:36.5125444Z .................................................................................................... 3900/5835
2019-07-19T19:10:40.5463226Z .................................................................................................... 4000/5835
2019-07-19T19:10:40.5463226Z .................................................................................................... 4000/5835
2019-07-19T19:10:44.2685341Z ii.................................................................................................. 4100/5835
2019-07-19T19:10:46.4708002Z .....................i.............................................................................. 4200/5835
2019-07-19T19:10:48.6459325Z .......................................................................................i............ 4300/5835
2019-07-19T19:10:57.5102260Z .................................................................................................... 4500/5835
2019-07-19T19:11:14.1873845Z .................................................................................................... 4600/5835
2019-07-19T19:11:17.7272914Z .................................................................................................... 4700/5835
2019-07-19T19:11:21.7151565Z .................................................................................................... 4800/5835
---
2019-07-19T19:11:56.8644603Z .................................................................................................... 5400/5835
2019-07-19T19:12:00.8896718Z .................................................................................................... 5500/5835
2019-07-19T19:12:05.0975150Z .................................................................................................... 5600/5835
2019-07-19T19:12:08.3899798Z .................................................................................................... 5700/5835
2019-07-19T19:12:11.3934533Z ...........................................................................i........................ 5800/5835
2019-07-19T19:12:12.7615319Z test result: ok. 5814 passed; 0 failed; 21 ignored; 0 measured; 0 filtered out
2019-07-19T19:12:12.7615772Z 
2019-07-19T19:12:12.7681741Z  finished in 275.134
2019-07-19T19:12:12.7867016Z Check compiletest suite=run-pass mode=run-pass (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-19T19:12:12.7867016Z Check compiletest suite=run-pass mode=run-pass (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-19T19:12:13.0211722Z 
2019-07-19T19:12:13.0214428Z running 2905 tests
2019-07-19T19:12:28.6768704Z .................................................................................................... 100/2905
2019-07-19T19:12:44.5457572Z ............................................................................i....................... 200/2905
2019-07-19T19:13:10.3193707Z .................................................................................................... 400/2905
2019-07-19T19:13:22.4753445Z .................................................................................................... 500/2905
2019-07-19T19:13:37.4632828Z .................................................................................................... 600/2905
2019-07-19T19:14:00.0069525Z .................................................................................................... 700/2905
2019-07-19T19:14:00.0069525Z .................................................................................................... 700/2905
2019-07-19T19:14:14.4504280Z .................................................................................................... 800/2905
2019-07-19T19:14:26.0795191Z .................................................................................................... 900/2905
2019-07-19T19:14:44.6773287Z .................................................................................................... 1000/2905
2019-07-19T19:14:59.6977860Z .................................................................................................... 1100/2905
2019-07-19T19:15:11.3460209Z .................................................................................................... 1200/2905
2019-07-19T19:15:24.2113933Z .................................................................................................... 1300/2905
2019-07-19T19:15:40.9200015Z ........ii.......................................................................................... 1400/2905
2019-07-19T19:15:53.7770199Z .................................................................................................... 1500/2905
2019-07-19T19:16:06.6347918Z ............................................................i.......i............................... 1600/2905
2019-07-19T19:16:40.3233840Z .................................................................................................... 1800/2905
2019-07-19T19:16:40.3233840Z .................................................................................................... 1800/2905
2019-07-19T19:16:56.3098593Z ...........................................................................................i........ 1900/2905
2019-07-19T19:17:16.4091274Z ...............................................................i.................................... 2000/2905
2019-07-19T19:18:01.1597224Z .................................................................................................... 2200/2905
2019-07-19T19:18:15.9447891Z ..................................................................................................ii 2300/2905
2019-07-19T19:18:35.9842729Z .................................................................................................... 2400/2905
2019-07-19T19:18:50.3745357Z .................................................................................................... 2500/2905
---
2019-07-19T19:21:11.2331411Z  finished in 31.485
2019-07-19T19:21:11.2331865Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-19T19:21:11.2332014Z 
2019-07-19T19:21:11.2333097Z running 146 tests
2019-07-19T19:21:15.2341854Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-07-19T19:21:16.1567598Z iii..............i.........iii.i......ii......
2019-07-19T19:21:16.1568552Z 
2019-07-19T19:21:16.1574751Z  finished in 5.422
2019-07-19T19:21:16.1749502Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-19T19:21:16.3337583Z 
2019-07-19T19:21:16.3337583Z 
2019-07-19T19:21:16.3338218Z running 39 tests
2019-07-19T19:21:18.7350076Z i.........i......................i.....
2019-07-19T19:21:18.7350540Z 
2019-07-19T19:21:18.7350583Z  finished in 2.247
2019-07-19T19:21:18.7350844Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-19T19:21:18.7350879Z 
2019-07-19T19:21:18.7350879Z 
2019-07-19T19:21:18.7350943Z running 9 tests
2019-07-19T19:21:18.7351185Z iiiiiiiii
2019-07-19T19:21:18.7351455Z 
2019-07-19T19:21:18.7351490Z  finished in 0.160
2019-07-19T19:21:18.7352044Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-19T19:21:18.7799502Z 
---
2019-07-19T19:21:37.7441030Z  finished in 18.754
2019-07-19T19:21:37.7441354Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-19T19:21:37.7441397Z 
2019-07-19T19:21:37.7441461Z running 122 tests
2019-07-19T19:22:02.2461640Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-07-19T19:22:06.4213214Z .i.i......iii.i.....ii
2019-07-19T19:22:06.4215070Z 
2019-07-19T19:22:06.4219294Z  finished in 29.025
2019-07-19T19:22:06.4229714Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-07-19T19:22:06.4230357Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-07-19T19:22:13.5112370Z 
2019-07-19T19:22:13.5112762Z 10 LL | #![deny(unused_attributes)]
2019-07-19T19:22:13.5113105Z 11    |         ^^^^^^^^^^^^^^^^^
2019-07-19T19:22:13.5113274Z 12 
2019-07-19T19:22:13.5113724Z - error: crate-level attribute should be an inner attribute: add an exclamation mark: #![foo]
2019-07-19T19:22:13.5114339Z + error: crate-level attribute should be an inner attribute: add an exclamation mark: `#![foo]`
2019-07-19T19:22:13.5115015Z 15    |
2019-07-19T19:22:13.5115182Z 16 LL |     #[bar]
2019-07-19T19:22:13.5115350Z 
2019-07-19T19:22:13.5115503Z 
2019-07-19T19:22:13.5115503Z 
2019-07-19T19:22:13.5115672Z The actual stderr differed from the expected stderr.
2019-07-19T19:22:13.5117314Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-attr-register-deny/plugin-attr-register-deny.stderr
2019-07-19T19:22:13.5117895Z To update references, rerun the tests and pass the `--bless` flag
2019-07-19T19:22:13.5118312Z To only update this specific test, also pass `--test-args plugin-attr-register-deny.rs`
2019-07-19T19:22:13.5118923Z error: 1 errors occurred comparing output.
2019-07-19T19:22:13.5119062Z status: exit code: 1
2019-07-19T19:22:13.5119062Z status: exit code: 1
2019-07-19T19:22:13.5120807Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui-fulldeps/plugin-attr-register-deny.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-attr-register-deny" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps/plugin-attr-register-deny/auxiliary" "-A" "unused"
2019-07-19T19:22:13.5121534Z ------------------------------------------
2019-07-19T19:22:13.5121690Z 
2019-07-19T19:22:13.5122072Z ------------------------------------------
2019-07-19T19:22:13.5122238Z stderr:
---
2019-07-19T19:22:13.5124828Z    |
2019-07-19T19:22:13.5124966Z LL | #![deny(unused_attributes)]
2019-07-19T19:22:13.5125112Z    |         ^^^^^^^^^^^^^^^^^
2019-07-19T19:22:13.5125255Z 
2019-07-19T19:22:13.5125837Z error: crate-level attribute should be an inner attribute: add an exclamation mark: `#![foo]`
2019-07-19T19:22:13.5126547Z    |
2019-07-19T19:22:13.5126669Z LL |     #[bar]
2019-07-19T19:22:13.5126789Z    |     ^^^^^^
2019-07-19T19:22:13.5126934Z 
---
2019-07-19T19:22:13.5134887Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:535:22
2019-07-19T19:22:13.5135131Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.
2019-07-19T19:22:13.5135906Z 
2019-07-19T19:22:13.5136066Z 
2019-07-19T19:22:13.5137671Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui-fulldeps" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui-fulldeps" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-6.0/bin/FileCheck" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "6.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2019-07-19T19:22:13.5138156Z 
2019-07-19T19:22:13.5138288Z 
2019-07-19T19:22:13.5138536Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-07-19T19:22:13.5138719Z Build completed unsuccessfully in 1:08:31
2019-07-19T19:22:13.5138719Z Build completed unsuccessfully in 1:08:31
2019-07-19T19:22:14.2982102Z ##[error]Bash exited with code '1'.
2019-07-19T19:22:14.3039861Z ##[section]Starting: Checkout
2019-07-19T19:22:14.3041648Z ==============================================================================
2019-07-19T19:22:14.3041726Z Task         : Get sources
2019-07-19T19:22:14.3041778Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Centril · 2019-07-20T23:58:54Z

@bors r-

fakenine · 2019-07-21T13:02:09Z

@Centril Tests are now fixed

Centril · 2019-07-21T14:07:49Z

@bors r+

bors · 2019-07-21T14:07:50Z

📌 Commit 0385d64 has been approved by Centril

…_compiler_messages_p10, r=Centril normalize use of backticks in compiler messages for librustc_lint rust-lang#60532

@ghost

Rollup of 14 pull requests Successful merges: - #62709 (Test that maplike FromIter satisfies uniqueness) - #62713 (Stabilize <*mut _>::cast and <*const _>::cast) - #62746 ( do not use assume_init in std::io) - #62787 (Fix typo in src/libstd/net/udp.rs doc comment) - #62788 (normalize use of backticks in compiler messages for libcore/ptr) - #62799 (use const array repeat expressions for uninit_array) - #62810 (normalize use of backticks in compiler messages for librustc_lint) - #62812 (normalize use of backticks in compiler messages for librustc_metadata) - #62832 (normalize use of backticks in compiler messages for librustc_incremental) - #62845 (read: fix doc comment) - #62853 (normalize use of backticks in compiler messages for librustc/hir) - #62854 (Fix typo in Unicode character name) - #62858 (Change wrong variable name.) - #62870 (fix lexing of comments with many \r) Failed merges: r? @ghost

rust-highfive assigned cramertj Jul 19, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 19, 2019

rust-highfive assigned Centril and unassigned cramertj Jul 19, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 19, 2019

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 20, 2019

normalize use of backticks in compiler messages for librustc_lint

0385d64

fakenine force-pushed the normalize_use_of_backticks_compiler_messages_p10 branch from c25a069 to 0385d64 Compare July 21, 2019 09:47

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 21, 2019

Centril added a commit to Centril/rust that referenced this pull request Jul 22, 2019

Rollup merge of rust-lang#62810 - fakenine:normalize_use_of_backticks…

17ddfbe

…_compiler_messages_p10, r=Centril normalize use of backticks in compiler messages for librustc_lint rust-lang#60532

Centril mentioned this pull request Jul 22, 2019

Rollup of 14 pull requests #62873

Merged

bors merged commit 0385d64 into rust-lang:master Jul 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

normalize use of backticks in compiler messages for librustc_lint #62810

normalize use of backticks in compiler messages for librustc_lint #62810

fakenine commented Jul 19, 2019

rust-highfive commented Jul 19, 2019

fakenine commented Jul 19, 2019

Centril commented Jul 19, 2019

bors commented Jul 19, 2019

rust-highfive commented Jul 19, 2019

Centril commented Jul 20, 2019

fakenine commented Jul 21, 2019

Centril commented Jul 21, 2019

bors commented Jul 21, 2019

normalize use of backticks in compiler messages for librustc_lint #62810

normalize use of backticks in compiler messages for librustc_lint #62810

Conversation

fakenine commented Jul 19, 2019

rust-highfive commented Jul 19, 2019

fakenine commented Jul 19, 2019

Centril commented Jul 19, 2019

bors commented Jul 19, 2019

rust-highfive commented Jul 19, 2019

Centril commented Jul 20, 2019

fakenine commented Jul 21, 2019

Centril commented Jul 21, 2019

bors commented Jul 21, 2019