Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain how to search in slice without owned data #62656

Merged
merged 2 commits into from
Jul 23, 2019

Conversation

RalfJung
Copy link
Member

Cc #62367

@rust-highfive
Copy link
Collaborator

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2019
@timvermeulen
Copy link
Contributor

If you only have a borrowed T, use any

contains takes a borrowed T, though. It's only when you have a &U with T: PartialEq<U> that you need to use any instead.

@RalfJung
Copy link
Member Author

Good point. I tried to improve the comment.

@sfackler
Copy link
Member

r? @rust-lang/docs

@Dylan-DPC-zz
Copy link

@bors r+

@bors
Copy link
Contributor

bors commented Jul 21, 2019

📌 Commit 3f77f2c has been approved by Dylan-DPC

@bors
Copy link
Contributor

bors commented Jul 21, 2019

🌲 The tree is currently closed for pull requests below priority 1500, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 22, 2019
explain how to search in slice without owned data

Cc rust-lang#62367
@RalfJung
Copy link
Member Author

@bors rollup

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 23, 2019
explain how to search in slice without owned data

Cc rust-lang#62367
bors added a commit that referenced this pull request Jul 23, 2019
Rollup of 14 pull requests

Successful merges:

 - #60951 (more specific errors in src/librustc/mir/interpret/error.rs)
 - #62523 (Delay bug to resolve HRTB ICE)
 - #62656 (explain how to search in slice without owned data)
 - #62791 (Handle more cases of typos misinterpreted as type ascription)
 - #62804 (rustc_typeck: improve diagnostics for _ const/static declarations)
 - #62808 (Revert "Disable stack probing for gnux32.")
 - #62817 (Tweak span for variant not found error)
 - #62842 (Add tests for issue-58887)
 - #62851 (move unescape module to rustc_lexer)
 - #62859 (Place::as_place_ref is now Place::as_ref)
 - #62869 (add rustc_private as a proper language feature gate)
 - #62880 (normalize use of backticks in compiler messages for librustc_allocator)
 - #62885 (Change "OSX" to "macOS")
 - #62889 (Update stage0.txt)

Failed merges:

r? @ghost
@bors bors merged commit 3f77f2c into rust-lang:master Jul 23, 2019
@RalfJung RalfJung deleted the contains-no-own branch August 9, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants