normalize use of backticks/lowercase in compiler messages for librustc_mir #62436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexreg (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
📌 Commit 79c760a has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 6, 2019
…_compiler_messages_1, r=Centril normalize use of backticks/lowercase in compiler messages for librustc_mir normalize use of backticks/lowercase in compiler messages for librustc_mir rust-lang#60532 r? @alexreg
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 6, 2019
Rollup of 4 pull requests [1] Successful merges: - rust-lang#62243 (Improve documentation for built-in macros) - rust-lang#62422 (Remove some uses of mem::uninitialized) - rust-lang#62432 (Update rustfmt to 1.3.2) - rust-lang#62436 (normalize use of backticks/lowercase in compiler messages for librustc_mir) Failed merges: r? @ghost
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 6, 2019
…_compiler_messages_1, r=Centril normalize use of backticks/lowercase in compiler messages for librustc_mir normalize use of backticks/lowercase in compiler messages for librustc_mir rust-lang#60532 r? @alexreg
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 6, 2019
…_compiler_messages_1, r=Centril normalize use of backticks/lowercase in compiler messages for librustc_mir normalize use of backticks/lowercase in compiler messages for librustc_mir rust-lang#60532 r? @alexreg
bors
added a commit
that referenced
this pull request
Jul 6, 2019
Rollup of 6 pull requests Successful merges: - #60081 (Refactor unicode.py script) - #61862 (Make the Weak::{into,as}_raw methods) - #62243 (Improve documentation for built-in macros) - #62422 (Remove some uses of mem::uninitialized) - #62432 (Update rustfmt to 1.3.2) - #62436 (normalize use of backticks/lowercase in compiler messages for librustc_mir) Failed merges: r? @ghost
|
Failed in #62449 (comment), @bors r- rollup- You forgot to |
bors
added
S-waiting-on-author
|
CI really needs to start checking that. |
fakenine
force-pushed
the
normalize_use_of_backticks_compiler_messages_1
branch
from
79c760a
to
7a2a17a
Compare
|
@Centril Sorry! I forgot the --compare-mode option at the end. The missing updated tests in |
|
@bors r+ |
|
📌 Commit 7a2a17a has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 6, 2019
…_compiler_messages_1, r=Centril normalize use of backticks/lowercase in compiler messages for librustc_mir normalize use of backticks/lowercase in compiler messages for librustc_mir rust-lang#60532 r? @alexreg
bors
added a commit
that referenced
this pull request
Jul 6, 2019
Rollup of 5 pull requests Successful merges: - #60081 (Refactor unicode.py script) - #61862 (Make the Weak::{into,as}_raw methods) - #62243 (Improve documentation for built-in macros) - #62422 (Remove some uses of mem::uninitialized) - #62436 (normalize use of backticks/lowercase in compiler messages for librustc_mir) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
normalize use of backticks/lowercase in compiler messages for librustc_mir
#60532
r? @alexreg