Exit arm scopes #62233
Merged
Exit arm scopes #62233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r? @pnkfelix |
|
☔ The latest upstream changes (presumably #62099) made this pull request unmergeable. Please resolve the merge conflicts. |
When a match evaluates to false we jump to the next arm, when we do so we need to make sure that we exit the scope for that arm.
matthewjasper
force-pushed
the
exit-arm-scopes
branch
from
9f1ed45
to
de5c6ec
Compare
|
@bors r+ rollup |
|
📌 Commit de5c6ec has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 9, 2019
Exit arm scopes Due to a bug in the HIR CFG construction, borrows for arm scopes were incorrectly leaking into other arms. This PR also includes some drive-by improvements to `-Zunpretty=hir,identified` that would have been helpful while investigating this. Closes #62107
|
☀️ Test successful - checks-azure, checks-travis, status-appveyor |
|
☔ The latest upstream changes made this pull request unmergeable. Please resolve the merge conflicts. Edit: Sorry, this was mistakenly posted. |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Jul 9, 2019
Tested on commit rust-lang/rust@b8ec4c4. Direct link to PR: <rust-lang/rust#62233> 🎉 rls on linux: test-fail → test-pass (cc @Xanewok, @rust-lang/infra).
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a bug in the HIR CFG construction, borrows for arm scopes were incorrectly leaking into other arms.
This PR also includes some drive-by improvements to
-Zunpretty=hir,identifiedthat would have been helpful while investigating this.Closes #62107