Fix an ICE with uninhabited consts #61814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
varkor
commented
Jun 13, 2019
| | ^^^^^^^^^^^^^^^^^^ | ||
| | | | ||
| | reached the configured maximum number of stack frames | ||
| | inside call to `hint_unreachable` at $DIR/uninhabited-const-issue-61744.rs:4:5 |
oli-obk
reviewed
Jun 14, 2019
oli-obk
added
S-waiting-on-author
varkor
added
S-waiting-on-review
varkor
force-pushed
the
uninhabited-const-61744
branch
from
22fc7db to
8aa42ed
Compare
|
@bors r+ |
|
📌 Commit b7a0e40 has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit b7a0e40 with merge 1651cc62cf8d612318996a4397b535085b808d2e... |
|
💔 Test failed - checks-travis |
bors
added
S-waiting-on-review
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@bors retry |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jun 25, 2019
…li-obk Fix an ICE with uninhabited consts Fixes rust-lang#61744. r? @oli-obk
|
⌛ Testing commit b7a0e40 with merge 9f2d3d3c03e4fe52c83d986625e4658adce4344a... |
|
@bors retry yield prio to r0llup |
bors
added a commit
that referenced
this pull request
Jun 25, 2019
Rollup of 7 pull requests Successful merges: - #61814 (Fix an ICE with uninhabited consts) - #61987 (rustc: produce AST instead of HIR from `hir::lowering::Resolver` methods.) - #62055 (Fix error counting) - #62078 (Remove built-in derive macros `Send` and `Sync`) - #62085 (Add test for issue-38591) - #62091 (HirIdification: almost there) - #62096 (Implement From<Local> for Place and PlaceBase) Failed merges: r? @ghost
|
Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
RalfJung
reviewed
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #61744.
r? @oli-obk