Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hamburger button from source code page #60489

Merged
merged 1 commit into from
May 7, 2019
Merged

Remove hamburger button from source code page #60489

merged 1 commit into from
May 7, 2019

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented May 2, 2019 •
edited
Loading

Fixes #60483.

Screenshot:

Screenshot 2019-05-03 at 00 12 51

cc @rust-lang/rustdoc

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 2, 2019
@GuillaumeGomez
Copy link
Member Author

@pietroalbini: However, highfive isn't called in here whereas it should. Maybe the condition is too specific? I'll take a look!

@pietroalbini
Copy link
Member

You probably made highfive crash with r? @rust-lang/rustdoc.

@GuillaumeGomez
Copy link
Member Author

Ah? Do you have a log so I can prevent it? :)

@pietroalbini
Copy link
Member

The problem is that GitHub returns a 422 status code when you try to assign someone who's not an org member in an issue/PR, so an exception is thrown. There is no way for us to assign those people, so the only thing we could do is gracefully handle that.

Note that this behavior is also abused for r? @ghost to prevent highfive commenting at all on rollups.

@GuillaumeGomez
Copy link
Member Author

Hmmm... Not convenient! Well, let's edit the first comment and re-open the PR then! :D

@GuillaumeGomez GuillaumeGomez reopened this May 3, 2019
@pietroalbini pietroalbini reopened this May 3, 2019
@pietroalbini
Copy link
Member

Oooh, highfive doesn't listen for the reopened event.

@GuillaumeGomez
Copy link
Member Author

Ok, next PR then! XD

@QuietMisdreavus
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 7, 2019

📌 Commit 2e20da5 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2019
Centril added a commit to Centril/rust that referenced this pull request May 7, 2019
@Centril
Rollup merge of rust-lang#60489 - GuillaumeGomez:remove-hamburger, r=…
4e23358 
…QuietMisdreavus

Remove hamburger button from source code page

Fixes rust-lang#60483.

Screenshot:

<img width="575" alt="Screenshot 2019-05-03 at 00 12 51" src="https://user-images.githubusercontent.com/3050060/57110298-61ec8f00-6d38-11e9-85fd-d13be94b9c52.png">

cc @rust-lang/rustdoc
@Centril Centril mentioned this pull request May 7, 2019
Merged
bors added a commit that referenced this pull request May 7, 2019
@bors
Auto merge of #60612 - Centril:rollup-61drhqt, r=Centril
cfdc84a 
Rollup of 5 pull requests

Successful merges:

 - #60489 (Remove hamburger button from source code page)
 - #60535 (Correct handling of arguments in async fn)
 - #60579 (Rename `ParamTy::idx` to `ParamTy::index`)
 - #60583 (Fix parsing issue with negative literals as const generic arguments)
 - #60609 (Be a bit more explicit asserting over the vec rather than the len)

Failed merges:

r? @ghost
@bors bors merged commit 2e20da5 into rust-lang:master May 7, 2019
@bors
Copy link
Contributor

bors commented May 7, 2019

☔ The latest upstream changes (presumably #60612) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 7, 2019
@GuillaumeGomez GuillaumeGomez deleted the remove-hamburger branch May 7, 2019 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hamburger button shouldn't appear on mobile view in source code page
5 participants
@GuillaumeGomez @pietroalbini @QuietMisdreavus @bors @rust-highfive