Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix equivalent string in escape_default docs #59946

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Conversation

mernen
Copy link
Contributor

@mernen mernen commented Apr 13, 2019

This newline should be escaped.

@rust-highfive
Copy link
Collaborator

r? @Kimundi

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 13, 2019
@mernen mernen changed the title Fix equivalent string in escape_default Fix equivalent string in escape_default docs Apr 13, 2019
@jonas-schievink jonas-schievink added the A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools label Apr 13, 2019
@Centril
Copy link
Contributor

Centril commented Apr 28, 2019

r? @ehuss

@rust-highfive rust-highfive assigned ehuss and unassigned Kimundi Apr 28, 2019
@ehuss
Copy link
Contributor

ehuss commented Apr 29, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 29, 2019

@ehuss: 🔑 Insufficient privileges: not in try users

@bors

This comment has been minimized.

@ehuss
Copy link
Contributor

ehuss commented Apr 29, 2019

Oh, @Centril you need to delegate=ehuss when you assign me.

@Centril
Copy link
Contributor

Centril commented Apr 29, 2019

@bors delegate=ehuss

@pietroalbini Can you give @ehuss r+ rights?

@bors
Copy link
Contributor

bors commented Apr 29, 2019

✌️ @ehuss can now approve this pull request

@Centril
Copy link
Contributor

Centril commented Apr 29, 2019

@bors r=ehuss rollup

@bors
Copy link
Contributor

bors commented Apr 29, 2019

📌 Commit e2613f5 has been approved by ehuss

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 29, 2019
@pietroalbini
Copy link
Member

@pietroalbini Can you give @ehuss r+ rights?

I'm not the one who should decide who gets r+ perms... Ask the compiler team.

@Centril
Copy link
Contributor

Centril commented Apr 29, 2019

@rust-lang/compiler ^-- asking you =P

Centril added a commit to Centril/rust that referenced this pull request Apr 29, 2019
Fix equivalent string in escape_default docs

This newline should be escaped.
bors added a commit that referenced this pull request Apr 29, 2019
Rollup of 9 pull requests

Successful merges:

 - #59946 (Fix equivalent string in escape_default docs)
 - #60256 (Option::flatten)
 - #60305 (hir: remove LoweredNodeId)
 - #60334 (Stabilized vectored IO)
 - #60353 (Add test not to forget resolved ICE)
 - #60356 (Stabilize str::as_mut_ptr)
 - #60358 (Clarify the short explanation of E0207)
 - #60359 (resolve: Consider erroneous imports used to avoid duplicate diagnostics)
 - #60360 (Add test case for labeled break in const assignment)

Failed merges:

r? @ghost
@bors bors merged commit e2613f5 into rust-lang:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants