Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track changes to robots.txt #59213

Merged
merged 1 commit into from
Mar 24, 2019
Merged

Track changes to robots.txt #59213

merged 1 commit into from
Mar 24, 2019

Conversation

kornelski
Copy link
Contributor

@kornelski kornelski commented Mar 15, 2019

Currently robots.txt of doc.rust-lang.org is not part of any repo, so there's no way to contribute any changes to it, such as needed for #44894 and countless dupes of this issue.

I propose adding it to this repo. I'm not in control of the infrastructure, so I can't help to automate deployment of it, but even just having the file under source control is IMHO a step forward.

@rust-highfive
Copy link
Collaborator

r? @QuietMisdreavus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 15, 2019
@kennytm kennytm added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Mar 15, 2019
@QuietMisdreavus
Copy link
Member

cc @rust-lang/infra in case this requires a change to RCS. Does the doc publishing code grab everything in the doc output? (Does bootstrap require a change to copy this file into the output when x.py doc is run?)

@QuietMisdreavus
Copy link
Member

I also want to rope in @rust-lang/release since this will add another step to the stable release process. We probably want to include all the old versions in this listing, right? That will mean we need to keep it updated when a new version is released.

@QuietMisdreavus
Copy link
Member

In general, i'm in favor of adding this to the repo, so if the teams i tagged are okay with whatever process changes are needed, r=me.

@kennytm kennytm added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). T-release Relevant to the release subteam, which will review and decide on the PR/issue. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2019
@kornelski
Copy link
Contributor Author

Right, I do plan to add more entries to the robots.txt ASAP, but for this issue I've copied exactly what's live to discuss further changes in a separate issue.

@pietroalbini
Copy link
Member

We probably want to include all the old versions in this listing, right? That will mean we need to keep it updated when a new version is released.

I played around with Google's validator (requires a Google account) and we could use wildcards to automatically include every release without having to update the file manually:

User-Agent: *
Disallow: /0.*
Disallow: /1.*

That would be great from a release team point of view.

@pietroalbini
Copy link
Member

Does the doc publishing code grab everything in the doc output?

Yep, RCS copies all the contents of the tarball in the S3 bucket.

Does bootstrap require a change to copy this file into the output when x.py doc is run?

I think you need to copy the file here, but I'm not too familiar with rustbuild. Anyway, I'd prefer to land this only when it's automatically synchronized with the website.

@pietroalbini
Copy link
Member

Discussed this at the infra team meeting, there should be no problem with deploying that file from the repo.

@pietroalbini pietroalbini removed the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Mar 19, 2019
@steveklabnik
Copy link
Member

So, one small thing I'm worried about here: does this mean we lose all of the google juice we've built up over the years? This just disallows the old pages, but doesn't redirect them to the new ones, right?

@kornelski
Copy link
Contributor Author

This PR only commits to the repo what's already live, so it doesn't affect SEO.

As for excluding old docs in the future, I expect it to be beneficial for SEO, but perhaps that should be discussed in depth in a separate issue?

@Mark-Simulacrum
Copy link
Member

r? @Mark-Simulacrum

Going to re-assign this to myself -- I'll try to check the dist process and make sure this doesn't cause any problems for us. Should hopefully have some time later this week.

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Mar 22, 2019
@Mark-Simulacrum
Copy link
Member

@bors r+

I think this should be fine; if not we can always revert.

@bors
Copy link
Contributor

bors commented Mar 23, 2019

📌 Commit fbc4326 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2019
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Mar 23, 2019
Track changes to robots.txt

Currently `robots.txt` of doc.rust-lang.org is not part of any repo, so there's [no way to contribute any changes to it](https://internals.rust-lang.org/t/deadlock-about-fixing-outdated-documentation-links-in-search-engines/9374), such as needed for rust-lang#44894 and countless dupes of this issue.

I propose adding it to this repo. I'm not in control of the infrastructure, so I can't help to automate deployment of it, but even just having the file under source control is IMHO a step forward.
kennytm added a commit to kennytm/rust that referenced this pull request Mar 24, 2019
Track changes to robots.txt

Currently `robots.txt` of doc.rust-lang.org is not part of any repo, so there's [no way to contribute any changes to it](https://internals.rust-lang.org/t/deadlock-about-fixing-outdated-documentation-links-in-search-engines/9374), such as needed for rust-lang#44894 and countless dupes of this issue.

I propose adding it to this repo. I'm not in control of the infrastructure, so I can't help to automate deployment of it, but even just having the file under source control is IMHO a step forward.
bors added a commit that referenced this pull request Mar 24, 2019
Rollup of 7 pull requests

Successful merges:

 - #59213 (Track changes to robots.txt)
 - #59239 (Remove inline assembly from hint::spin_loop)
 - #59251 (Use a valid name for graphviz graphs)
 - #59296 (Do not encode gensymed imports in metadata)
 - #59328 (Implement specialized nth_back() for Box and Windows.)
 - #59355 (Fix ICE with const generic param in struct)
 - #59377 (Correct minimum system LLVM version in tests)
@bors bors merged commit fbc4326 into rust-lang:master Mar 24, 2019
@kornelski kornelski deleted the robots branch March 14, 2020 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants