-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track changes to robots.txt #59213
Track changes to robots.txt #59213
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
cc @rust-lang/infra in case this requires a change to RCS. Does the doc publishing code grab everything in the doc output? (Does bootstrap require a change to copy this file into the output when |
I also want to rope in @rust-lang/release since this will add another step to the stable release process. We probably want to include all the old versions in this listing, right? That will mean we need to keep it updated when a new version is released. |
In general, i'm in favor of adding this to the repo, so if the teams i tagged are okay with whatever process changes are needed, r=me. |
Right, I do plan to add more entries to the |
I played around with Google's validator (requires a Google account) and we could use wildcards to automatically include every release without having to update the file manually:
That would be great from a release team point of view. |
Yep, RCS copies all the contents of the tarball in the S3 bucket.
I think you need to copy the file here, but I'm not too familiar with rustbuild. Anyway, I'd prefer to land this only when it's automatically synchronized with the website. |
Discussed this at the infra team meeting, there should be no problem with deploying that file from the repo. |
So, one small thing I'm worried about here: does this mean we lose all of the google juice we've built up over the years? This just disallows the old pages, but doesn't redirect them to the new ones, right? |
This PR only commits to the repo what's already live, so it doesn't affect SEO. As for excluding old docs in the future, I expect it to be beneficial for SEO, but perhaps that should be discussed in depth in a separate issue? |
Going to re-assign this to myself -- I'll try to check the dist process and make sure this doesn't cause any problems for us. Should hopefully have some time later this week. |
@bors r+ I think this should be fine; if not we can always revert. |
📌 Commit fbc4326 has been approved by |
Track changes to robots.txt Currently `robots.txt` of doc.rust-lang.org is not part of any repo, so there's [no way to contribute any changes to it](https://internals.rust-lang.org/t/deadlock-about-fixing-outdated-documentation-links-in-search-engines/9374), such as needed for rust-lang#44894 and countless dupes of this issue. I propose adding it to this repo. I'm not in control of the infrastructure, so I can't help to automate deployment of it, but even just having the file under source control is IMHO a step forward.
Track changes to robots.txt Currently `robots.txt` of doc.rust-lang.org is not part of any repo, so there's [no way to contribute any changes to it](https://internals.rust-lang.org/t/deadlock-about-fixing-outdated-documentation-links-in-search-engines/9374), such as needed for rust-lang#44894 and countless dupes of this issue. I propose adding it to this repo. I'm not in control of the infrastructure, so I can't help to automate deployment of it, but even just having the file under source control is IMHO a step forward.
Rollup of 7 pull requests Successful merges: - #59213 (Track changes to robots.txt) - #59239 (Remove inline assembly from hint::spin_loop) - #59251 (Use a valid name for graphviz graphs) - #59296 (Do not encode gensymed imports in metadata) - #59328 (Implement specialized nth_back() for Box and Windows.) - #59355 (Fix ICE with const generic param in struct) - #59377 (Correct minimum system LLVM version in tests)
Currently
robots.txt
of doc.rust-lang.org is not part of any repo, so there's no way to contribute any changes to it, such as needed for #44894 and countless dupes of this issue.I propose adding it to this repo. I'm not in control of the infrastructure, so I can't help to automate deployment of it, but even just having the file under source control is IMHO a step forward.