-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace TimeLine LLVM profiling with the self profiler #58488
Conversation
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
Yes, I think this is going in the right direction. However, I'd hold off on doing "instant" events at the moment and only use events with a distinct beginning and end. That is, basically, add a label to Let me do another pass over the existing |
Thanks for all the feedback @michaelwoerister! |
☔ The latest upstream changes (presumably #58495) made this pull request unmergeable. Please resolve the merge conflicts. |
ping from triage @wesleywiser any updates? |
⌛ Testing commit 4c8cc14 with merge c9665aa9498cda868eee9a81ef1b93d194254994... |
💥 Test timed out |
@bors retry 4 hour timeout, a job didn't start at all. |
⌛ Testing commit 4c8cc14 with merge 557a419e76b9372c1369c2e685549e4b90e00757... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Looks spurious to me @bors retry |
⌛ Testing commit 4c8cc14 with merge 2a936b710fe891cdfb86df82d231066d94c27412... |
💥 Test timed out |
@bors retry |
Replace TimeLine LLVM profiling with the self profiler
☀️ Test successful - checks-travis, status-appveyor |
No description provided.