hir: add HirId to main Hir nodes #58079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Zoxc
reviewed
Feb 2, 2019
Zoxc
reviewed
Feb 2, 2019
Zoxc
reviewed
Feb 2, 2019
|
I've looked over this and it looks good. r=me when you've addressed the comments |
ljedrz
force-pushed
the
HirIdification_phase_1
branch
from
94a9507 to
55ef78e
Compare
|
@Zoxc thanks; comments addressed. |
|
@bors r+ |
|
📌 Commit 55ef78e has been approved by |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 55ef78e with merge 1c02eaefaea5870575f46c3edc77a1a5e9182664... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
Is this spurious? Looks like it failed only in one of the environments. |
|
I hope so, yes. If not we'll need to investigate which resource limit was exceeded -- I suspect disk, but not sure. @bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Feb 3, 2019
hir: add HirId to main Hir nodes This is the 1st PR in a series dedicated to `HirId`-ification, i.e. deprecating `ast::NodeId`s after the AST > HIR lowering process. The bigger proof of concept can be seen in #57578. **Phase 1**: store `HirId` in all remaining (some already have it) main HIR nodes (excluding `*Id` objects). - [x] `Field` - [x] `FieldPat` - [x] `ForeignItem` - [x] `GenericParam` - [x] `Lifetime` - [x] `MacroDef` - [x] `PathSegment` - [x] `PatKind::Binding` - [x] `Stmt` - [x] `StructField` - [x] `TypeBinding` - [x] `VariantData` - [x] `WhereClause` - [x] `WhereEqPredicate` r? @Zoxc Cc @varkor
|
☀️ Test successful - checks-travis, status-appveyor |
|
📣 Toolstate changed by #58079! Tested on commit ec7ecb3. 💔 clippy-driver on windows: test-fail → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). |
rust-highfive
added a commit
to rust-lang-nursery/rust-toolstate
that referenced
this pull request
Feb 3, 2019
Tested on commit rust-lang/rust@ec7ecb3. Direct link to PR: <rust-lang/rust#58079> 💔 clippy-driver on windows: test-fail → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra). 💔 clippy-driver on linux: test-fail → build-fail (cc @Manishearth @llogiq @mcarton @oli-obk, @rust-lang/infra).
bors
added a commit
to rust-lang/rust-clippy
that referenced
this pull request
Feb 3, 2019
Fix breakage due to rust-lang/rust#58079 The rustc change added HirId to a few nodes. As I understand it, the plan is to remove the NodeId from these nodes eventually. Where the NodeId was not being matched, I used `..` to try and avoid further breakage. Where it was, I used `_` to make the fix easier when NodeId is removed.
bors
added a commit
that referenced
this pull request
Feb 3, 2019
submodule: update clippy from 6ce78d1 to 3bda548 rust-lang/rust-clippy@6ce78d1...3bda548 Rustup: unused trim result Auto merge of #3727 - phansch:rustup_unused_trim, r=matthiaskrgr … Travis: Don't run integration tests on every PR commit … Auto merge of #3726 - phansch:some_renaming, r=oli-obk … Fix ICE in vec_box lint and add run-rustfix … Make vec_box MachineApplicable Remove conditionals from base builds … Adding lint for too many lines. Updating number of lines for the failing test to be > 100. … Running util/dev to update README/CHANGELOG Reworking function logic, and adding doc example. … Moving tests to ui-toml to make use of clippy.toml rustfmt Adding back tests, but also reducing threshold by 1 Updating to just warn for one test. Fix test broken by removing comment. Skipping check if in external macro. Adding lint for too many lines. Updating number of lines for the failing test to be > 100. … Moving tests to ui-toml to make use of clippy.toml rustfmt Adding back tests, but also reducing threshold by 1 Updating to just warn for one test. Fix test broken by removing comment. Changing single character string to a character match. Updated readme. Updating code to ignore rustfmt issue. phansch and avborhanian Update clippy_lints/src/types.rs … Update clippy_lints/src/types.rs … Auto merge of #3732 - phansch:fix_ice_3720, r=oli-obk … Auto merge of #3731 - phansch:travis, r=phansch … Auto merge of #2857 - avborhanian:master, r=phansch … Fix breakage due to #58079 … Auto merge of #3736 - mikerite:fix-build-20190203, r=phansch … related with: #58024
g-bartoszek
pushed a commit
to g-bartoszek/rust-clippy
that referenced
this pull request
Feb 7, 2019
The rustc change added HirId to a few nodes. As I understand it, the plan is to remove the NodeId from these nodes eventually. Where the NodeId was not being matched, I used `..` to try and avoid further breakage. Where it was, I used `_` to make the fix easier when NodeId is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the 1st PR in a series dedicated to
HirId-ification, i.e. deprecatingast::NodeIds after the AST > HIR lowering process. The bigger proof of concept can be seen in #57578.Phase 1: store
HirIdin all remaining (some already have it) main HIR nodes (excluding*Idobjects).FieldFieldPatForeignItemGenericParamLifetimeMacroDefPathSegmentPatKind::BindingStmtStructFieldTypeBindingVariantDataWhereClauseWhereEqPredicater? @Zoxc
Cc @varkor