Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated suggestion functions #57907

Merged
merged 2 commits into from
Jan 27, 2019

Conversation

euclio
Copy link
Contributor

@euclio euclio commented Jan 25, 2019

This PR removes the (now unused) deprecated suggestion functions and removes _with_applicability from their replacements' names.

This PR will break clippy, but I'll open a clippy PR once this is merged.

@euclio euclio force-pushed the applicability-rename branch from 9af59d6 to 6086e37 Compare January 25, 2019 21:18
@estebank
Copy link
Contributor

r=me once it passes ci

DO NOT ROLLUP

@estebank estebank added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 25, 2019
@estebank estebank self-requested a review January 25, 2019 21:42
@Centril
Copy link
Contributor

Centril commented Jan 25, 2019

r? @estebank

@estebank
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 25, 2019

📌 Commit 6086e370b0c18cfaa08ee4f148ccef8658f7f1cb has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 25, 2019
@bors
Copy link
Contributor

bors commented Jan 26, 2019

☔ The latest upstream changes (presumably #57898) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 26, 2019
@estebank
Copy link
Contributor

After you fix, let's give this high prio

@Centril
Copy link
Contributor

Centril commented Jan 26, 2019

@bors p=1

@euclio euclio force-pushed the applicability-rename branch from 6086e37 to 5876659 Compare January 26, 2019 18:03
@euclio
Copy link
Contributor Author

euclio commented Jan 26, 2019

@estebank Rebased, and travis looks good so far.

@Centril
Copy link
Contributor

Centril commented Jan 26, 2019

@bors r=estebank

@bors
Copy link
Contributor

bors commented Jan 26, 2019

📌 Commit 58766595c7418eb3af006f8562a28a9394245d46 has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 26, 2019
@Centril
Copy link
Contributor

Centril commented Jan 26, 2019

@bors r- p=10

You'll need to rebase, but I'd wait until after #57899 is merged since that will likely mess with this PR as well.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 26, 2019
@bors
Copy link
Contributor

bors commented Jan 26, 2019

☔ The latest upstream changes (presumably #57918) made this pull request unmergeable. Please resolve the merge conflicts.

@Centril
Copy link
Contributor

Centril commented Jan 27, 2019

#57899 was r-ed so you might want to quickly rebase and get this in before that one while the bors queue is relatively small.

@euclio euclio force-pushed the applicability-rename branch from 5876659 to 0897ffc Compare January 27, 2019 04:08
@Centril
Copy link
Contributor

Centril commented Jan 27, 2019

Let's hope travis goes green while waiting on the other PRs in the queue... meanwhile:

@bors r=estebank

@bors
Copy link
Contributor

bors commented Jan 27, 2019

📌 Commit 0897ffc has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 27, 2019
@bors
Copy link
Contributor

bors commented Jan 27, 2019

⌛ Testing commit 0897ffc with merge 1484d0d...

bors added a commit that referenced this pull request Jan 27, 2019
remove deprecated suggestion functions

This PR removes the (now unused) deprecated suggestion functions and removes `_with_applicability` from their replacements' names.

This PR will break clippy, but I'll open a clippy PR once this is merged.
@bors
Copy link
Contributor

bors commented Jan 27, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: estebank
Pushing 1484d0d to master...

@bors bors merged commit 0897ffc into rust-lang:master Jan 27, 2019
matthiaskrgr added a commit to matthiaskrgr/rust-clippy that referenced this pull request Jan 27, 2019
for file in `fd \.rs$` ; do sed  -i  s/span_suggestion_with_applicability/span_suggestion/g $file ; done

for file in `fd \.rs$` ; do sed  -i  s/span_suggestion_short_with_applicability/span_suggestion_short/g $file ; done

for file in `fd \.rs$` ; do sed  -i  s/span_suggestions_with_applicability/span_suggestions/g $file ; done
bors added a commit to rust-lang/rust-clippy that referenced this pull request Jan 27, 2019
@euclio euclio deleted the applicability-rename branch January 27, 2019 15:38
matthiaskrgr added a commit to matthiaskrgr/rls that referenced this pull request Jan 27, 2019
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 30, 2019
Changes:
````
wildcard_match_arm: Update lint count.
wildcard_match_arm: add nesting issue to known.
wildcard_match_arm: lint only enum matches.
wildcard_match_arm: update ui test stderr
wildcard_match_arm: format test.
wilcard_match_arm: run rustfmt.
wildcard_match_arm: add lint properly.
wildcard_match_arm: rename function.
wildcard_match_arm: add simple ui test.
wildcard_match_arm: expand lint scope.
Change match_wild lint name to WILDCARD_MATCH_ARM.
Add match_wild lint (rust-lang#3649).
fetch_prs_between: add .sh file ending
cargo fmt
Update various docs
Use built-in entry_fn detection over self-built
cargo fmt
Reorganize conditionals: Run faster checks first
Maybe fix ICE?
Add initial version of const_fn lint
Fix `unit_arg` false positive
Rustfmt
Check hypothetically failing conversion
Remove tests for deprecated items
Update more changed iterator paths
Atomics constants are now handled by the deprecation lint
Update changed iterator paths
Update const slice processing
update test stderr
run cargo fmt
rustup rust-lang#57907
Fix documentation for `slow_vector_initialization`
rustup rust-lang#57726
Remove unsafe_vector_initialization from added lints
Prevent incorrect cast_lossless suggestion in const_fn
Incorporate review suggestions
Fix dogfood tests on Appveyor
test(versioncheck): Use .no_deps()
test(versioncheck): Fix version equality check
chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1
dependencies: update itertools from 0.7 to 0.8
Add script to fetch GitHub PRs between two commits
gitattributes: Treat .fixed files as rust files
Update changelog with all changes since 0.0.212
Fix `expect_fun_call` lint suggestions
````
bors added a commit that referenced this pull request Jan 30, 2019
submodules: update clippy from f175352 to 6ce78d1

Should fix clippy toolstate

Changes:
````
wildcard_match_arm: Update lint count.
wildcard_match_arm: add nesting issue to known.
wildcard_match_arm: lint only enum matches.
wildcard_match_arm: update ui test stderr
wildcard_match_arm: format test.
wilcard_match_arm: run rustfmt.
wildcard_match_arm: add lint properly.
wildcard_match_arm: rename function.
wildcard_match_arm: add simple ui test.
wildcard_match_arm: expand lint scope.
Change match_wild lint name to WILDCARD_MATCH_ARM.
Add match_wild lint (#3649).
fetch_prs_between: add .sh file ending
cargo fmt
Update various docs
Use built-in entry_fn detection over self-built
cargo fmt
Reorganize conditionals: Run faster checks first
Maybe fix ICE?
Add initial version of const_fn lint
Fix `unit_arg` false positive
Rustfmt
Check hypothetically failing conversion
Remove tests for deprecated items
Update more changed iterator paths
Atomics constants are now handled by the deprecation lint
Update changed iterator paths
Update const slice processing
update test stderr
run cargo fmt
rustup #57907
Fix documentation for `slow_vector_initialization`
rustup #57726
Remove unsafe_vector_initialization from added lints
Prevent incorrect cast_lossless suggestion in const_fn
Incorporate review suggestions
Fix dogfood tests on Appveyor
test(versioncheck): Use .no_deps()
test(versioncheck): Fix version equality check
chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1
dependencies: update itertools from 0.7 to 0.8
Add script to fetch GitHub PRs between two commits
gitattributes: Treat .fixed files as rust files
Update changelog with all changes since 0.0.212
Fix `expect_fun_call` lint suggestions
````

r? @oli-obk
g-bartoszek pushed a commit to g-bartoszek/rust-clippy that referenced this pull request Feb 5, 2019
for file in `fd \.rs$` ; do sed  -i  s/span_suggestion_with_applicability/span_suggestion/g $file ; done

for file in `fd \.rs$` ; do sed  -i  s/span_suggestion_short_with_applicability/span_suggestion_short/g $file ; done

for file in `fd \.rs$` ; do sed  -i  s/span_suggestions_with_applicability/span_suggestions/g $file ; done
g-bartoszek pushed a commit to g-bartoszek/rust-clippy that referenced this pull request Feb 7, 2019
for file in `fd \.rs$` ; do sed  -i  s/span_suggestion_with_applicability/span_suggestion/g $file ; done

for file in `fd \.rs$` ; do sed  -i  s/span_suggestion_short_with_applicability/span_suggestion_short/g $file ; done

for file in `fd \.rs$` ; do sed  -i  s/span_suggestions_with_applicability/span_suggestions/g $file ; done
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request May 5, 2020
Changes:
````
wildcard_match_arm: Update lint count.
wildcard_match_arm: add nesting issue to known.
wildcard_match_arm: lint only enum matches.
wildcard_match_arm: update ui test stderr
wildcard_match_arm: format test.
wilcard_match_arm: run rustfmt.
wildcard_match_arm: add lint properly.
wildcard_match_arm: rename function.
wildcard_match_arm: add simple ui test.
wildcard_match_arm: expand lint scope.
Change match_wild lint name to WILDCARD_MATCH_ARM.
Add match_wild lint (rust-lang#3649).
fetch_prs_between: add .sh file ending
cargo fmt
Update various docs
Use built-in entry_fn detection over self-built
cargo fmt
Reorganize conditionals: Run faster checks first
Maybe fix ICE?
Add initial version of const_fn lint
Fix `unit_arg` false positive
Rustfmt
Check hypothetically failing conversion
Remove tests for deprecated items
Update more changed iterator paths
Atomics constants are now handled by the deprecation lint
Update changed iterator paths
Update const slice processing
update test stderr
run cargo fmt
rustup rust-lang/rust#57907
Fix documentation for `slow_vector_initialization`
rustup rust-lang/rust#57726
Remove unsafe_vector_initialization from added lints
Prevent incorrect cast_lossless suggestion in const_fn
Incorporate review suggestions
Fix dogfood tests on Appveyor
test(versioncheck): Use .no_deps()
test(versioncheck): Fix version equality check
chore(cargo/dependencies/cargo-metadata): Upgrade to 0.7.1
dependencies: update itertools from 0.7 to 0.8
Add script to fetch GitHub PRs between two commits
gitattributes: Treat .fixed files as rust files
Update changelog with all changes since 0.0.212
Fix `expect_fun_call` lint suggestions
````
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants