Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 25 pull requests #57063

Merged
merged 61 commits into from
Dec 23, 2018
Merged

Rollup of 25 pull requests #57063

merged 61 commits into from
Dec 23, 2018

Commits on Dec 17, 2018

  1. Configuration menu
    Copy the full SHA
    3e7a4ca View commit details
    Browse the repository at this point in the history
  2. static eval: Do not ICE on layout size overflow

    Layout size overflow and typeck eval errors are reported. Trigger a bug
    only when the eval error is strictly labeled as TooGeneric.
    dlrobertson committed Dec 17, 2018
    Configuration menu
    Copy the full SHA
    e7e17f9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6130fc8 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2018

  1. rename div_euc -> div_euclid, and mod_euc -> rem_euclid

    logic is written up in rust-lang#49048
    
    Also, update the documentation slightly
    ubsan committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    e36b628 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82e55c1 View commit details
    Browse the repository at this point in the history
  3. fix tests

    ubsan committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    de39aea View commit details
    Browse the repository at this point in the history
  4. Fix rustdoc-js tests

    Fixes rustdoc-js tests by teaching tester.js how to handle single-line js comments.
    
    Also, added speculative support for template strings, and warnings for future debuggers.
    JohnHeitmann committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    5056669 View commit details
    Browse the repository at this point in the history
  5. Explain the math

    oli-obk committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    50eb5f6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3d8a066 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2018

  1. Configuration menu
    Copy the full SHA
    00bd306 View commit details
    Browse the repository at this point in the history
  2. Updates based on comment

    Firstyear committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    0829d0c View commit details
    Browse the repository at this point in the history
  3. Fix tidy error

    Firstyear committed Dec 19, 2018
    Configuration menu
    Copy the full SHA
    b2d8040 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    202904b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    885cf2a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    81a45e2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    818ed69 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ae3f6b0 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    7eb67c2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a153d48 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    036ce5c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    90726e1 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2018

  1. Configuration menu
    Copy the full SHA
    7b6cf6e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fb18dda View commit details
    Browse the repository at this point in the history
  3. Update src/libcore/num/mod.rs

    Co-Authored-By: ubsan <[email protected]>
    dtolnay and ubsan authored Dec 20, 2018
    Configuration menu
    Copy the full SHA
    66bb34c View commit details
    Browse the repository at this point in the history
  4. fix nits

    ubsan committed Dec 20, 2018
    Configuration menu
    Copy the full SHA
    455bc95 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0b0a00c View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8dc8d7a View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2018

  1. Optimize away a move

    Zoxc committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    edd08e0 View commit details
    Browse the repository at this point in the history
  2. Inline tweaks

    Zoxc committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    4f30a24 View commit details
    Browse the repository at this point in the history
  3. Fix feature gate to point to 1.32.0 for path_from_str

    When the feature has been added back (rust-lang#55148) the feature gate has not
    been adjusted accordingly. We have it enabled for 1.32.0, currently in
    Beta, so adjust it.
    
    Refs: rust-lang#44431.
    
    Signed-off-by: Otavio Salvador <[email protected]>
    otavio committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    8c40aed View commit details
    Browse the repository at this point in the history
  4. Stabilize #[repr(packed(N))]

    cramertj committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    87c8cdd View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e5e19d9 View commit details
    Browse the repository at this point in the history
  6. Fixed typo in HashMap documentation

    Previously "with a custom type as key", now "with a custom key type"
    RyanMarcus authored Dec 21, 2018
    Configuration menu
    Copy the full SHA
    51e4c1f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    34dc5c8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    0203a1c View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2018

  1. Update migrate warning wording.

    This commit modifies the wording of the warning for
    backwards-incompatible changes in migrate mode. The warning messages are
    changed to be lowercase and not include line-breaks in order to be
    consistent with other compiler diagnostics.
    davidtwco committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    22b2bd8 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#56802 - clarcharr:nth_back, r=alexcrichton

    Add DoubleEndedIterator::nth_back
    
    As suggested by rust-lang#54054. This doesn't fix that issue, as this doesn't add enough implementations to optimise that specific use case, but it adds the method and a few (relatively) trivial overrides to work as an initial implementation.
    
    It's probably going to be a lot of work adding `nth_back` implementations everywhere, and I don't have the time to include it all in this commit. But, it's a start. :)
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    2d6927e View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#56909 - dlrobertson:fix_56762, r=estebank

    static eval: Do not ICE on layout size overflow
    
    Layout size overflow and typeck eval errors are reported. Trigger a bug
    only when the eval error is strictly labeled as TooGeneric.
    
    Fixes: rust-lang#56762
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    a92e21c View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#56914 - glaubitz:ignore-tests, r=alexcrichton

    Ignore ui/target-feature-gate on sparc, sparc64, powerpc, powerpc64 and powerpc64le
    
    The test ui/target-feature-gate is not applicable on sparc, sparc64, powerpc, powerpc64 and powerpc64le and consequently fails there. So just ignore it on these targets.
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    beaf071 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#56919 - oli-obk:null_ref_array_tuple, r=Ral…

    …fJung
    
    Remove a wrong multiplier on relocation offset computation
    
    r? @RalfJung
    
    fixes rust-lang#56800
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    54d4e26 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#56933 - clarcharr:xpy_progress, r=Mark-Simu…

    …lacrum
    
    Add --progress to git submodule commands in x.py
    
    This is a relatively new flag, but it means that git will indicate the progress of the update as it would with regular clones. This is especially helpful as some of the submodules are really big and it's difficult to tell if it's hanging or still updating.
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    660eca6 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#56936 - ubsan:euclidean_div_rem, r=dtolnay

    rename div_euc -> div_euclid, and mod_euc -> rem_euclid
    
    logic is written up in rust-lang#49048
    
    Also, update the documentation slightly.
    
    cc @alexcrichton @clarcharr @varkor
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    314e61f View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#56941 - euclio:deny-libstd-resolution-failu…

    …res, r=QuietMisdreavus
    
    deny intra-doc link resolution failures in libstd
    
    Fixes rust-lang#56693.
    
    Until we land a fix for the underlying issue (rust-lang#56922), we can at least fix the failures in libstd so they don't propagate to downstream crates.
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    14ebca5 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#56967 - GuillaumeGomez:regen-search-index, …

    …r=QuietMisdreavus
    
    Replace current crate's searchIndex when regenerating
    
    Fixes rust-lang#56921.
    
    r? @QuietMisdreavus
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    1c76a2f View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#56970 - Firstyear:mem_uninit_doc_ptr_drop, …

    …r=Manishearth
    
    Mem uninit doc ptr drop
    
    Extend the mem::uninitialized documentation to account for partially initialized arrays and how to correctly handle these. These are used in some datastructures (trees for example) or in FFI.
    
    r? @Manishearth
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    22dfa2b View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#56973 - RalfJung:miri-trace, r=oli-obk

    make basic CTFE tracing available on release builds
    
    Debugging things going wrong in miri is currently pretty much impossible with a nightly Rust.
    
    r? @oli-obk
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    de2ba78 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#56979 - VardhanThigle:Vardhan/rust-sgx-unwi…

    …nd-support, r=alexcrichton
    
    Adding unwinding support for x86_64_fortanix_unknown_sgx target.
    
    Unwinding support is provided by our port of LLVM's libunwind which is available from https://github.com/fortanix/libunwind/tree/release_50.
    
    libunwind requires support for rwlock and printing to stderr, which is only provided by `std` for this target. This poses two problems: 1) how to expose the `std` functionality to C and 2) dependency inversion.
    
    ### Exposing `std`
    
    For exposing the functionality we chose to expose the following symbols:
    
    * __rust_rwlock_rdlock
    * __rust_rwlock_wrlock
    * __rust_rwlock_unlock
    * __rust_print_err
    * __rust_abort
    
    Also, the following are needed from `alloc`:
    
    * __rust_alloc
    * __rust_dealloc
    
    #### Rust RWLock in C
    
    In `libunwind`, RWLock is initialized as a templated static variable:
    
    ```c
    pthread_rwlock_t DwarfFDECache<A>::_lock = PTHREAD_RWLOCK_INITIALIZER;
    ```
    
    I don't know of a good way to use the Rust sys::rwlock::RWLock type and initializer there. We could have a static global variable in Rust, but that doesn't work with the templating. The variable needs to be initialized statically, since this target doesn't support the .init section. Currently, I just used a byte array and standard C array initialization. The mapping between this C type and the Rust type needs to be manually maintained. There is a compile-time check and a unit test to make sure the Rust versions of these C definitions match the actual Rust type. If any reviewer knows of a better solution, please do tell.
    
    ### Dependency inversion issue
    
    `std` depends on `panic_unwind` which depends on `libunwind`, and `libunwind` depends on `std`. This is not normally supported by Rust's linking system. Therefore we use raw C exports from `std` *and* `libunwind.a` is linked last in the target `post_link_objects` instead of being built as part of the Rust `libunwind`. Currently, all C exports are defined in `src/libstd/sys/sgx/rwlock.rs` to overcome LTO issues. Only the `__rust_rwlock_*` definitions *need* to live there for privacy reasons. Once again, if any reviewer knows of a better solution, please do tell.
    
    r? @alexcrichton
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    10d949a View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#56981 - RalfJung:miri-infallible-alloc, r=o…

    …li-obk
    
    miri: allocation is infallible
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    40dc787 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#56984 - ljedrz:dropck_outlives_tweaks, r=ol…

    …i-obk
    
    A few tweaks to dropck_outlives
    
    - remove an unnecessary call to `cloned()`
    - simplify common patterns
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    afe572b View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#56989 - phansch:fix_compiletest_trim_deprec…

    …ations, r=Mark-Simulacrum
    
    Fix compiletest `trim` deprecation warnings
    
    None
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    10e4330 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#56992 - euclio:unknown-lint-suggestion, r=o…

    …li-obk
    
    suggest similar lint names for unknown lints
    
    Fixes rust-lang#54737.
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    7bb40eb View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#57002 - scottmcm:stabilize-resize_with, r=r…

    …kruppe
    
    Stabilize Vec(Deque)::resize_with
    
    Closes rust-lang#41758
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    5ba6a34 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#57011 - QuietMisdreavus:static-root-path, r…

    …=GuillaumeGomez
    
    rustdoc: add new CLI flag to load static files from a different location
    
    This PR adds a new CLI flag to rustdoc, `--static-root-path`, which controls how rustdoc links pages to the CSS/JS/font static files bundled with the output. By default, these files are linked with a series of `../` which is calculated per-page to link it to the documentation root - i.e. a relative link to the directory given by `-o`. This is causing problems for docs.rs, because even though docs.rs has saved one copy of these files and is dispatching them dynamically, browsers have no way of knowing that these are the same files and can cache them. This can allow it to link these files as, for example, `/rustdoc.css` instead of `../../rustdoc.css`, creating a single location that the files are loaded from.
    
    I made sure to only change links for the *static* files, those that don't change between crates. Files like the search index, aliases, the source files listing, etc, are still linked with relative links.
    
    r? @GuillaumeGomez
    
    cc @onur
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    4446c65 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    9b2331d View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    5e727a4 View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#57040 - otavio:topic/adjust-path_from_str-f…

    …eature-gate, r=Centril
    
    Fix feature gate to point to 1.32.0 for `path_from_str`
    
    When the feature has been added back (rust-lang#55148) the feature gate has not
    been adjusted accordingly. We have it enabled for 1.32.0, currently in
    Beta, so adjust it.
    
    Refs: rust-lang#44431.
    
    Signed-off-by: Otavio Salvador <[email protected]>
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    e4430e0 View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#57049 - cramertj:repr-packed, r=Centril

    Stabilize #[repr(packed(N))]
    
    Fixes rust-lang#33158
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    60b4ea0 View commit details
    Browse the repository at this point in the history
  23. Rollup merge of rust-lang#57050 - RyanMarcus:master, r=zackmdavis

    Fixed typo in HashMap documentation
    
    Previously "with a custom type as key", now "with a custom key type"
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    bba398e View commit details
    Browse the repository at this point in the history
  24. Rollup merge of rust-lang#57052 - Centril:fix-eip-stable-version, r=v…

    …arkor
    
    Fix stabilization version numbers (exhaustive_integer_patterns + macro_literal_matcher)
    
    + `exhaustive_integer_patterns` slipped 1.32; merged in 1.33 -- rust-lang#56362
    + `macro_literal_matcher` isn't stable on current stable (1.31) but is on beta (1.32).
    
    r? @varkor
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    5ffd1a6 View commit details
    Browse the repository at this point in the history
  25. Rollup merge of rust-lang#57039 - davidtwco:migrate-warning-wording, …

    …r=pnkfelix
    
    Update migrate warning wording.
    
    This PR modifies the wording of the warning for backwards-incompatible changes in migrate mode. The warning messages are changed to be lowercase and not include line-breaks in order to be consistent with other compiler diagnostics.
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    26842ae View commit details
    Browse the repository at this point in the history
  26. Rollup merge of rust-lang#56945 - JohnHeitmann:rustdoc-js-tester-fix,…

    … r=GuillaumeGomez
    
    Fix rustdoc-js tests
    
    Fixes rustdoc-js tests by teaching tester.js how to handle single-line js comments.
    
    Also, added speculative support for template strings, and warnings for future debuggers.
    kennytm committed Dec 22, 2018
    Configuration menu
    Copy the full SHA
    628c6d8 View commit details
    Browse the repository at this point in the history