Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: remove static lifetimes from consts #56500

Merged
merged 1 commit into from
Dec 6, 2018
Merged

cleanup: remove static lifetimes from consts #56500

merged 1 commit into from
Dec 6, 2018

Conversation

ljedrz
Copy link
Contributor

@ljedrz ljedrz commented Dec 4, 2018

A follow-up to #56497.

@rust-highfive
Copy link
Collaborator

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 4, 2018
@zackmdavis
Copy link
Member

@ljedrz I haven't worked on rustbuild much and can't estimate the work involved, but I wonder if you would have any interest in making it easy/possible to make Clippy and cargo fix work on this repository (#53896)? (I haven't found the time to attempt it yet.) The benefit of cleanup PRs like this one is that our codebase is tidier and easier to read, but I can't help but dream about the efficiency of "run Clippy once, and be done" (at least, with the things Clippy knows about) in contrast to many small manually-composed PRs.

In any case, thanks for all your work!! 💖

@bors r+

@bors
Copy link
Contributor

bors commented Dec 4, 2018

📌 Commit d0c64bb has been approved by zackmdavis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2018
@ljedrz
Copy link
Contributor Author

ljedrz commented Dec 4, 2018

That would be cool indeed; sounds fun, I can try giving it a shot 👍.

pietroalbini added a commit to pietroalbini/rust that referenced this pull request Dec 5, 2018
@pietroalbini
Rollup merge of rust-lang#56500 - ljedrz:cleanup_rest_of_const_lifeti…
97452d9 
…mes, r=zackmdavis

cleanup: remove static lifetimes from consts

A follow-up to rust-lang#56497.
@pietroalbini pietroalbini mentioned this pull request Dec 5, 2018
Closed
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Dec 6, 2018
@pietroalbini
Rollup merge of rust-lang#56500 - ljedrz:cleanup_rest_of_const_lifeti…
e941e1a 
…mes, r=zackmdavis

cleanup: remove static lifetimes from consts

A follow-up to rust-lang#56497.
@pietroalbini pietroalbini mentioned this pull request Dec 6, 2018
Merged
bors added a commit that referenced this pull request Dec 6, 2018
@bors
Auto merge of #56557 - pietroalbini:rollup, r=pietroalbini
367e783 
Rollup of 11 pull requests

Successful merges:

 - #56315 (Rustdoc inline macro reexport)
 - #56332 ([rustdoc] Specific crate search)
 - #56362 (Stabilise exhaustive integer patterns)
 - #56426 (libsyntax_pos: A few tweaks)
 - #56441 (rustbuild: Fix issues with compiler docs)
 - #56446 (pass the parameter environment to `traits::find_associated_item`)
 - #56500 (cleanup: remove static lifetimes from consts)
 - #56525 (Avoid extra copy and syscall in std::env::current_exe)
 - #56528 (Remove unused dependency (rustc_lint -> rustc_mir))
 - #56548 (Optimized string FromIterator + Extend impls)
 - #56553 (Don't print the profiling summary to stdout when -Zprofile-json is set)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Dec 6, 2018

☔ The latest upstream changes (presumably #56557) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 6, 2018
@bors bors merged commit d0c64bb into rust-lang:master Dec 6, 2018
@ljedrz ljedrz deleted the cleanup_rest_of_const_lifetimes branch December 6, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zackmdavis zackmdavis

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ljedrz @rust-highfive @zackmdavis @bors