A few iterator-related improvements #55067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
sinkuu
reviewed
Oct 14, 2018
ljedrz
force-pushed
the
generic_iterator_related_improvements
branch
from
4bf5948
to
a14a950
Compare
|
Errors fixed, comment addressed. |
|
@bors r+ |
|
📌 Commit a14a950 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Oct 16, 2018
…r=petrochenkov A few iterator-related improvements - typeck: don't collect into a vector when unnecessary - create only one vector when winnowing candidates - change a cloning map to `into_iter`
|
☀️ Test successful - status-appveyor, status-travis |
pnkfelix
reviewed
Nov 9, 2018
| @@ -626,7 +626,7 @@ https://doc.rust-lang.org/reference/types.html#trait-objects"); | |||
|
|
|||
| // Typecheck the patterns first, so that we get types for all the | |||
| // bindings. | |||
| let all_arm_pats_diverge: Vec<_> = arms.iter().map(|arm| { | |||
| let all_arm_pats_diverge = arms.iter().map(|arm| { | |||
There was a problem hiding this comment.
I think this change injected #55810, because it delayed our type-checking of the patterns. (Note the comment right above this line.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
into_iter