Fix "cannot encode region variables" error #5467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expr_call(expr_field(...)) rather than an expr_method_call. There is probably more such code in trans that should be removed.
problem and which seem like they could be useful in the future.
… astconv and from typeck, which is verboten. We are supposed to write inference results into the FnCtxt and then these get copied over in writeback. Add assertions that no inference by-products are added to this table. Fixes rust-lang#3888 Fixes rust-lang#4036 Fixes rust-lang#4492
bors
added a commit
that referenced
this pull request
Mar 26, 2013
…encode-region-variables, r=nikomatsakis The basic problem was that vtables were not being resolved. The fix uncovered another issue, which was that the syntax extensions were not creating method calls properly and were relying on outdated code in typeck, so I fixed that too. Resolves issues #3888, #4036, #4492. r? @catamorphism
nikomatsakis
deleted the
issues-3888-4036-4492-cannot-encode-region-variables
branch
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
May 2, 2020
rustup rust-lang#71116 changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic problem was that vtables were not being resolved. The fix uncovered another issue, which was that the syntax extensions were not creating method calls properly and were relying on outdated code in typeck, so I fixed that too.
Resolves issues #3888, #4036, #4492.
r? @catamorphism