Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update clippy submodule to a72e786c #54561

Merged
merged 1 commit into from
Sep 26, 2018
Merged

update clippy submodule to a72e786c #54561

merged 1 commit into from
Sep 26, 2018

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 25, 2018
@kennytm
Copy link
Member

kennytm commented Sep 26, 2018

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 26, 2018

📌 Commit 7703928f83366e90276299f1aed6fec4262ff575 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2018
@matthiaskrgr
Copy link
Member Author

#53824 broke the clippy build so this won't pass CI in its current state.

I filed a PR to fix clippy and will update this PR once that is merged into clippy.

@kennytm
Copy link
Member

kennytm commented Sep 26, 2018

Ok.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 26, 2018
@kennytm kennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 26, 2018
@matthiaskrgr
Copy link
Member Author

rebased to include fix-pr

@kennytm

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 26, 2018
@kennytm
Copy link
Member

kennytm commented Sep 26, 2018

Needs to update Cargo.lock...

@matthiaskrgr
Copy link
Member Author

Ah yes, sorry, I forgot to git add that..

@matthiaskrgr matthiaskrgr changed the title update clippy submodule to cdde22c2 update clippy submodule to a72e786c Sep 26, 2018
@kennytm
Copy link
Member

kennytm commented Sep 26, 2018

@bors r+

@bors
Copy link
Contributor

bors commented Sep 26, 2018

📌 Commit 45f45e5 has been approved by kennytm

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 26, 2018
@bors
Copy link
Contributor

bors commented Sep 26, 2018

⌛ Testing commit 45f45e5 with merge ae7fe84...

bors added a commit that referenced this pull request Sep 26, 2018
@bors
Auto merge of #54561 - matthiaskrgr:clippy_up, r=kennytm
ae7fe84 
update clippy submodule to a72e786
@bors
Copy link
Contributor

bors commented Sep 26, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing ae7fe84 to master...

@bors bors merged commit 45f45e5 into rust-lang:master Sep 26, 2018
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #54561!

Tested on commit ae7fe84.
Direct link to PR: #54561

🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.
🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Sep 26, 2018
@rust-highfive
📣 Toolstate changed by rust-lang/rust#54561!
cf425dc 
Tested on commit rust-lang/rust@ae7fe84.
Direct link to PR: <rust-lang/rust#54561>

🎉 clippy-driver on windows: build-fail → test-pass.
🎉 clippy-driver on linux: build-fail → test-pass.
🎉 rls on windows: build-fail → test-pass.
🎉 rls on linux: build-fail → test-pass.
@matthiaskrgr matthiaskrgr deleted the clippy_up branch October 15, 2018 15:08
@pnkfelix pnkfelix mentioned this pull request Nov 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthiaskrgr @rust-highfive @kennytm @bors @aturon