Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate how to move value out of Box in docs. #54544

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Indicate how to move value out of Box in docs. #54544

merged 1 commit into from
Oct 1, 2018

Conversation

frewsxcv
Copy link
Member

Fixes #53634.

@rust-highfive
Copy link
Collaborator

r? @aidanhs

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 25, 2018
@frewsxcv frewsxcv mentioned this pull request Sep 25, 2018
Closed
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:58:45] ....................................................................................................
[00:58:48] .....................................................i..............................................
[00:58:51] ....................................................................................................
[00:58:54] ....................................................................................................
[00:58:56] ..iiiiiiiii.........................................................................................
[00:59:02] ....................................................................................................
[00:59:05] ......................................................................................i.............
[00:59:08] ....................................................................................................
[00:59:11] .........................................i.i..ii....................................................
---
[01:31:17] travis_fold:end:stage0-linkchecker

[01:31:17] travis_time:end:stage0-linkchecker:start=1537846164596359862,finish=1537846167158960093,duration=2562600231

[01:33:21] alloc/boxed/index.html:11: broken link - alloc/ops/trait.Deref.html
[01:33:48] thread 'main' panicked at 'found some broken links', tools/linkchecker/main.rs:49:9
[01:33:48] 
[01:33:48] 
[01:33:48] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/linkchecker" "/checkout/obj/build/x86_64-unknown-linux-gnu/doc"
[01:33:48] expected success, got: exit code: 101
[01:33:48] expected success, got: exit code: 101
[01:33:48] 
[01:33:48] 
[01:33:48] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:33:48] Build completed unsuccessfully in 0:43:59
[01:33:48] make: *** [check] Error 1
[01:33:48] Makefile:58: recipe for target 'check' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:25db7bd8
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@frewsxcv
Copy link
Member Author

r? @rust-lang/docs

GuillaumeGomez
GuillaumeGomez reviewed Sep 27, 2018
View reviewed changes
src/liballoc/boxed.rs Outdated
@@ -16,10 +16,18 @@
//!
//! # Examples
//!
//! Creating a box:
//! Move a value from the stack to the heap by creating a `Box`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to Box.

GuillaumeGomez
GuillaumeGomez reviewed Sep 27, 2018
View reviewed changes
src/liballoc/boxed.rs Outdated
//! let boxed: Box<u8> = Box::new(val);
//! ```
//!
//! Move a value from a `Box` back to the stack by [dereferencing]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same.

@GuillaumeGomez
Copy link
Member

r=me once links added.

@frewsxcv
Copy link
Member Author

@bors r=GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Sep 29, 2018

📌 Commit 8d10f96 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Oct 1, 2018
@kennytm
Rollup merge of rust-lang#54544 - frewsxcv:frewsxcv-deref, r=Guillaum…
4941670 
…eGomez

Indicate how to move value out of Box in docs.

Fixes rust-lang#53634.
@kennytm kennytm mentioned this pull request Oct 1, 2018
Merged
bors added a commit that referenced this pull request Oct 1, 2018
@bors
Auto merge of #54711 - kennytm:rollup, r=kennytm
6188c58 
Rollup of 13 pull requests

Successful merges:

 - #53784 (Document that slices cannot be larger than `isize::MAX` bytes)
 - #54308 (Better user experience when attempting to call associated functions with dot notation)
 - #54488 (in which we include attributes in unused `extern crate` suggestion spans)
 - #54544 (Indicate how to move value out of Box in docs.)
 - #54623 (Added help message for `impl_trait_in_bindings` feature gate)
 - #54641 (A few cleanups and minor improvements to rustc/infer)
 - #54656 (Correct doc for WorkQueue<T>::pop().)
 - #54674 (update miri)
 - #54676 (Remove `-Z disable_ast_check_for_mutation_in_guard`)
 - #54679 (Improve bug! message for impossible case in Relate)
 - #54681 (Rename sanitizer runtime libraries on OSX)
 - #54708 (Make ./x.py help <cmd> invoke ./x.py <cmd> -h on its own)
 - #54713 (Add nightly check for tool_lints warning)
@bors bors merged commit 8d10f96 into rust-lang:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

Assignees
No one assigned
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@frewsxcv @rust-highfive @GuillaumeGomez @bors @aidanhs