Added graphviz visualization for obligation forests. #54486

orium · 2018-09-22T20:18:57Z

This can be a big help when debugging the trait resolver.

rust-highfive · 2018-09-22T20:19:00Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @varkor (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

orium · 2018-09-22T20:21:28Z

This is something I did to help me debug issue #40827 (CC #53255) and I think can be helpful in the future for other people debugging trait resolution.

varkor · 2018-09-23T23:17:02Z

src/librustc_data_structures/obligation_forest/graphviz.rs

+    ///  * `sed 's,std::[a-z]*::,,g'` — Deletes the `std::<package>::` prefix of paths.
+    ///  * `sed 's,"Binder(TraitPredicate(<\(.*\)>)) (\([^)]*\))","\1 (\2)",'` — Transforms
+    ///    `Binder(TraitPredicate(<predicate>))` into just `<predicate>`.
+    #[allow(dead_code)]


Why is this necessary?

This function is not used. The idea is that people can temporarily call it while debugging stuff.

varkor · 2018-09-24T22:03:44Z

I've not worked with obligation_forest before, so I think it'd be more helpful for someone who has to judge whether there are any ways this could be more useful. r? @arielb1

arielb1 · 2018-09-24T22:13:08Z

Hi @orium - are you trying to debug something in particular?

memoryruins · 2018-09-24T23:30:53Z

@arielb1

(I'm glad I added graphviz to the obligations forest. It make things much easier to understand. I will open a PR soon with that.)

#53255 (comment)

edit: I see you already replied ^^

arielb1 · 2018-09-25T21:50:29Z

This looks like an OK idea, but I don't know the graphviz API that well - or what's the best way to integrate tooling like that into the compiler - r? @nikomatsakis for that.

bors · 2018-09-26T12:45:03Z

☔ The latest upstream changes (presumably #53824) made this pull request unmergeable. Please resolve the merge conflicts.

nikomatsakis · 2018-10-04T20:14:49Z

I have no objection to landing this code, though I don't expect the obligation forest to live much longer.

nikomatsakis · 2018-10-04T20:14:53Z

@bors r+

bors · 2018-10-04T20:14:54Z

📌 Commit dde82aa3d78115533136aa58a6da7a8b0a468cbd has been approved by nikomatsakis

nikomatsakis · 2018-10-04T20:14:58Z

The code itself seems fine :)

bors · 2018-10-04T20:28:52Z

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

git checkout obligation-forest-graphviz (switch to your branch)
git fetch upstream master (retrieve the latest master)
git rebase upstream/master -p (rebase on top of it)
Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
git push self obligation-forest-graphviz --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

warning: Cannot merge binary files: src/Cargo.lock (HEAD vs. heads/homu-tmp)
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your merge.renamelimit variable to at least 2791 and retry the command.
Auto-merging src/librustc_data_structures/obligation_forest/mod.rs
Auto-merging src/librustc_data_structures/lib.rs
Auto-merging src/Cargo.lock
CONFLICT (content): Merge conflict in src/Cargo.lock
Automatic merge failed; fix conflicts and then commit the result.

orium · 2018-10-05T08:59:27Z

@nikomatsakis rebased :)

nikomatsakis · 2018-10-09T17:44:07Z

@bors r

nikomatsakis · 2018-10-09T17:44:10Z

@bors r+

bors · 2018-10-09T17:44:11Z

📌 Commit bb2c8052cb410195b1e5b9f5b4a0522cdecd27b2 has been approved by nikomatsakis

bors · 2018-10-09T19:57:49Z

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

git checkout obligation-forest-graphviz (switch to your branch)
git fetch upstream master (retrieve the latest master)
git rebase upstream/master -p (rebase on top of it)
Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
git push self obligation-forest-graphviz --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

warning: Cannot merge binary files: src/Cargo.lock (HEAD vs. heads/homu-tmp)
Auto-merging src/Cargo.lock
CONFLICT (content): Merge conflict in src/Cargo.lock
Automatic merge failed; fix conflicts and then commit the result.

rust-highfive · 2018-10-11T09:44:43Z

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

######################################################################## 100.0%
[00:02:16] extracting /checkout/obj/build/cache/2018-09-23/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:02:16] warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest
[00:02:17]     Updating crates.io index
[00:02:21] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:21] Build completed unsuccessfully in 0:00:34
[00:02:21] make: *** [prepare] Error 1
[00:02:21] Makefile:81: recipe for target 'prepare' failed
[00:02:22] Command failed. Attempt 2/5:
[00:02:22] Command failed. Attempt 2/5:
[00:02:22] warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest
[00:02:22] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:22] Build completed unsuccessfully in 0:00:00
[00:02:22] make: *** [prepare] Error 1
[00:02:22] Makefile:81: recipe for target 'prepare' failed
[00:02:24] Command failed. Attempt 3/5:
[00:02:24] Command failed. Attempt 3/5:
[00:02:24] warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest
[00:02:24] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:24] Build completed unsuccessfully in 0:00:00
[00:02:24] make: *** [prepare] Error 1
[00:02:24] Makefile:81: recipe for target 'prepare' failed
[00:02:27] Command failed. Attempt 4/5:
[00:02:27] Command failed. Attempt 4/5:
[00:02:28] warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest
[00:02:28] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:28] Build completed unsuccessfully in 0:00:00
[00:02:28] make: *** [prepare] Error 1
[00:02:28] Makefile:81: recipe for target 'prepare' failed
[00:02:32] Command failed. Attempt 5/5:
[00:02:32] Command failed. Attempt 5/5:
[00:02:32] warning: the cargo feature `edition` is now stable and is no longer necessary to be listed in the manifest
[00:02:32] error: the lock file needs to be updated but --locked was passed to prevent this
[00:02:32] Build completed unsuccessfully in 0:00:00
[00:02:32] make: *** [prepare] Error 1
[00:02:32] Makefile:81: recipe for target 'prepare' failed
[00:02:32] The command has failed after 5 attempts.
---
travis_time:end:076218ba:start=1539251045610849976,finish=1539251045615404233,duration=4554257
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:1209290c
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0baf9bf4
travis_time:start:0baf9bf4
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:113ab0d6
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

orium · 2018-10-13T14:54:36Z

@nikomatsakis Should be mergeable now. Btw, is there any way to avoid or reduce merge conflicts because of Cargo.lock?

This can be a big help when debugging the trait resolver.

nikomatsakis · 2018-10-16T15:58:15Z

@bors r+

@orium not that I know of

bors · 2018-10-16T15:58:17Z

📌 Commit 3fc275d has been approved by nikomatsakis

bors · 2018-10-16T20:30:49Z

⌛ Testing commit 3fc275d with merge bef62cc...

Added graphviz visualization for obligation forests. This can be a big help when debugging the trait resolver.

bors · 2018-10-16T23:27:38Z

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing bef62cc to master...

rust-highfive assigned varkor Sep 22, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2018

varkor reviewed Sep 23, 2018

View reviewed changes

rust-highfive assigned arielb1 and unassigned varkor Sep 24, 2018

rust-highfive assigned nikomatsakis and unassigned arielb1 Sep 25, 2018

orium force-pushed the obligation-forest-graphviz branch from 5797483 to dde82aa Compare September 26, 2018 16:14

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 4, 2018

orium force-pushed the obligation-forest-graphviz branch from dde82aa to bb2c805 Compare October 5, 2018 01:04

bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 9, 2018

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 9, 2018

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 9, 2018

orium force-pushed the obligation-forest-graphviz branch 2 times, most recently from 272ef52 to d9fc4e2 Compare October 11, 2018 09:39

orium force-pushed the obligation-forest-graphviz branch 2 times, most recently from 1923275 to 34fbef7 Compare October 13, 2018 14:44

Added graphviz visualization for obligation forests.

3fc275d

This can be a big help when debugging the trait resolver.

orium force-pushed the obligation-forest-graphviz branch from 34fbef7 to 3fc275d Compare October 14, 2018 15:12

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 16, 2018

bors added a commit that referenced this pull request Oct 16, 2018

Auto merge of #54486 - orium:obligation-forest-graphviz, r=nikomatsakis

bef62cc

Added graphviz visualization for obligation forests. This can be a big help when debugging the trait resolver.

bors merged commit 3fc275d into rust-lang:master Oct 16, 2018

bors mentioned this pull request Oct 16, 2018

Update Cargo, build curl/OpenSSL statically via features #54919

Merged

orium deleted the obligation-forest-graphviz branch October 16, 2018 23:35

pnkfelix mentioned this pull request Nov 9, 2018

romaji fails to build on beta, #55810

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added graphviz visualization for obligation forests. #54486

Added graphviz visualization for obligation forests. #54486

orium commented Sep 22, 2018

rust-highfive commented Sep 22, 2018

orium commented Sep 22, 2018

varkor Sep 23, 2018

orium Sep 23, 2018

varkor commented Sep 24, 2018

arielb1 commented Sep 24, 2018

memoryruins commented Sep 24, 2018 •

edited

Loading

arielb1 commented Sep 25, 2018

bors commented Sep 26, 2018

nikomatsakis commented Oct 4, 2018

nikomatsakis commented Oct 4, 2018

bors commented Oct 4, 2018

nikomatsakis commented Oct 4, 2018

bors commented Oct 4, 2018

orium commented Oct 5, 2018

nikomatsakis commented Oct 9, 2018

nikomatsakis commented Oct 9, 2018

bors commented Oct 9, 2018

bors commented Oct 9, 2018

rust-highfive commented Oct 11, 2018

orium commented Oct 13, 2018

nikomatsakis commented Oct 16, 2018

bors commented Oct 16, 2018

bors commented Oct 16, 2018

bors commented Oct 16, 2018

Added graphviz visualization for obligation forests. #54486

Added graphviz visualization for obligation forests. #54486

Conversation

orium commented Sep 22, 2018

rust-highfive commented Sep 22, 2018

orium commented Sep 22, 2018

varkor Sep 23, 2018

Choose a reason for hiding this comment

orium Sep 23, 2018

Choose a reason for hiding this comment

varkor commented Sep 24, 2018

arielb1 commented Sep 24, 2018

memoryruins commented Sep 24, 2018 • edited Loading

arielb1 commented Sep 25, 2018

bors commented Sep 26, 2018

nikomatsakis commented Oct 4, 2018

nikomatsakis commented Oct 4, 2018

bors commented Oct 4, 2018

nikomatsakis commented Oct 4, 2018

bors commented Oct 4, 2018

orium commented Oct 5, 2018

nikomatsakis commented Oct 9, 2018

nikomatsakis commented Oct 9, 2018

bors commented Oct 9, 2018

bors commented Oct 9, 2018

rust-highfive commented Oct 11, 2018

orium commented Oct 13, 2018

nikomatsakis commented Oct 16, 2018

bors commented Oct 16, 2018

bors commented Oct 16, 2018

bors commented Oct 16, 2018

memoryruins commented Sep 24, 2018 •

edited

Loading